Skip to content

Ensure all test projects disable AppHost on macOS#7582

Merged
Youssef1313 merged 3 commits intomainfrom
copilot/remove-apphost-from-test-projects
Mar 20, 2026
Merged

Ensure all test projects disable AppHost on macOS#7582
Youssef1313 merged 3 commits intomainfrom
copilot/remove-apphost-from-test-projects

Conversation

Copy link
Contributor

Copilot AI commented Mar 20, 2026

Dump-related issues on macOS require UseAppHost=false for test projects. This was already applied to the two acceptance integration test projects but missing from the remaining ~45 test projects.

Changes

  • Added <UseAppHost Condition="$([MSBuild]::IsOSPlatform('OSX'))">false</UseAppHost> to test/Directory.Build.props
  • Removed the now-redundant UseAppHost lines from MSTest.Acceptance.IntegrationTests.csproj and Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj

This single change in test/Directory.Build.props propagates the setting to all test projects via MSBuild inheritance, replacing the need for per-project declarations.

Original prompt

This section details on the original issue you should resolve

<issue_title>Ensure all test projects don't use apphost for macOS</issue_title>
<issue_description>To workaround dump-related issues on macOS, we should ensure we have the following in all test projects.

Today we have that already in acceptance test projects.

<UseAppHost Condition="$([MSBuild]::IsOSPlatform('OSX'))">false</UseAppHost>
```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copilot AI changed the title [WIP] Ensure all test projects don't use apphost for macOS Ensure all test projects disable AppHost on macOS Mar 20, 2026
Copilot AI requested a review from Youssef1313 March 20, 2026 12:13
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
@Youssef1313 Youssef1313 marked this pull request as ready for review March 20, 2026 12:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Propagates a macOS-specific MSBuild workaround across the entire test tree by disabling AppHost for all test projects on macOS, removing the need for per-project settings.

Changes:

  • Added UseAppHost=false (conditioned on IsOSPlatform('OSX')) to test/Directory.Build.props so it applies to all test projects via inheritance.
  • Removed redundant UseAppHost entries from the two acceptance integration test projects.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/Directory.Build.props Centralizes the macOS AppHost disablement for all test projects.
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj Removes now-redundant per-project UseAppHost setting.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/MSTest.Acceptance.IntegrationTests.csproj Removes now-redundant per-project UseAppHost setting.

@Youssef1313
Copy link
Member

@Evangelink Now hangdump works correctly :

  Hang dump timeout of '00:15:00' expired
  Dumping process 17542 - dotnet
  The following tests were still running when dump was taken (format: [<time-elapsed-since-start>] <name>):
  [00:16:21] AnsiTerminal_OutputProgressFrameIsCorrect
  Creating dump file '/Users/runner/work/1/s/artifacts/TestResults/Debug/dotnet_17542_hang.dmp'

@Evangelink Evangelink enabled auto-merge March 20, 2026 13:03
@Youssef1313 Youssef1313 disabled auto-merge March 20, 2026 15:46
@Youssef1313 Youssef1313 merged commit a8d9bb6 into main Mar 20, 2026
13 of 15 checks passed
@Youssef1313 Youssef1313 deleted the copilot/remove-apphost-from-test-projects branch March 20, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure all test projects don't use apphost for macOS

4 participants