Ensure all test projects disable AppHost on macOS#7582
Merged
Youssef1313 merged 3 commits intomainfrom Mar 20, 2026
Merged
Conversation
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Ensure all test projects don't use apphost for macOS
Ensure all test projects disable AppHost on macOS
Mar 20, 2026
Youssef1313
reviewed
Mar 20, 2026
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Youssef1313
approved these changes
Mar 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Propagates a macOS-specific MSBuild workaround across the entire test tree by disabling AppHost for all test projects on macOS, removing the need for per-project settings.
Changes:
- Added
UseAppHost=false(conditioned onIsOSPlatform('OSX')) totest/Directory.Build.propsso it applies to all test projects via inheritance. - Removed redundant
UseAppHostentries from the two acceptance integration test projects.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Directory.Build.props | Centralizes the macOS AppHost disablement for all test projects. |
| test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj | Removes now-redundant per-project UseAppHost setting. |
| test/IntegrationTests/MSTest.Acceptance.IntegrationTests/MSTest.Acceptance.IntegrationTests.csproj | Removes now-redundant per-project UseAppHost setting. |
Member
|
@Evangelink Now hangdump works correctly : |
Evangelink
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dump-related issues on macOS require
UseAppHost=falsefor test projects. This was already applied to the two acceptance integration test projects but missing from the remaining ~45 test projects.Changes
<UseAppHost Condition="$([MSBuild]::IsOSPlatform('OSX'))">false</UseAppHost>totest/Directory.Build.propsUseAppHostlines fromMSTest.Acceptance.IntegrationTests.csprojandMicrosoft.Testing.Platform.Acceptance.IntegrationTests.csprojThis single change in
test/Directory.Build.propspropagates the setting to all test projects via MSBuild inheritance, replacing the need for per-project declarations.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.