Cleanup dead code for exception handling#7546
Merged
Youssef1313 merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Cleans up exception-handling logic in the MSTest adapter’s TestMethodRunner.ExecuteAsync path by removing specialized/duplicated handling and standardizing unexpected exceptions as error results.
Changes:
- Removed the dedicated
catch (TestFailedException)and the “patch last result” logic inExecuteAsync. - Simplified the generic exception path to always return a single error
TestResultcontaining a wrappedTestFailedException.
You can also share your feedback on Copilot code review. Take the survey.
src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodRunner.cs
Outdated
Show resolved
Hide resolved
Youssef1313
force-pushed
the
dev/ygerges/deadcode
branch
from
6ea5edb to
07ca305
Compare
nohwnd
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.