feat(workspace_git_outbound_policy): onboard new resource and data source#850
Open
catalina-gav wants to merge 1 commit intomainfrom
Open
feat(workspace_git_outbound_policy): onboard new resource and data source#850catalina-gav wants to merge 1 commit intomainfrom
catalina-gav wants to merge 1 commit intomainfrom
Conversation
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for managing and reading Microsoft Fabric Workspace Git Outbound Policy via a new Terraform resource and data source, and wires them into the provider to close issues #841 and #842.
Changes:
- Introduces
fabric_workspace_git_outbound_policyresource (CRUD via Set/Get API; delete resets to defaults). - Introduces
fabric_workspace_git_outbound_policydata source (read via Get API). - Registers both in the provider and adds docs, examples, changelog entries, and unit/acceptance tests.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/services/workspacegop/base.go | Defines type metadata (name/type/docs URL/SPN support). |
| internal/services/workspacegop/base_test.go | Exposes ItemTypeInfo for tests. |
| internal/services/workspacegop/schema.go | Adds shared schema for resource/data source (workspace_id, default_action, timeouts). |
| internal/services/workspacegop/models.go | Adds TF models and request mapping to SDK types. |
| internal/services/workspacegop/resource_workspace_git_outbound_policy.go | Implements resource CRUD using WorkspacesClient Get/SetGitOutboundPolicy. |
| internal/services/workspacegop/data_workspace_git_outbound_policy.go | Implements data source read using WorkspacesClient GetGitOutboundPolicy. |
| internal/services/workspacegop/fake_test.go | Adds fakes for Get/Set Git outbound policy for unit tests. |
| internal/services/workspacegop/resource_workspace_git_outbound_policy_test.go | Adds unit tests for schema validation + CRUD, plus acceptance CRUD. |
| internal/services/workspacegop/data_workspace_git_outbound_policy_test.go | Adds unit + acceptance tests for data source read scenarios. |
| internal/provider/provider.go | Registers the new resource and data source with the provider. |
| examples/resources/fabric_workspace_git_outbound_policy/providers.tf | Adds example provider configuration for the new resource. |
| examples/resources/fabric_workspace_git_outbound_policy/resource.tf | Adds example resource usage. |
| examples/resources/fabric_workspace_git_outbound_policy/outputs.tf | Adds example output for the resource. |
| examples/data-sources/fabric_workspace_git_outbound_policy/providers.tf | Adds example provider configuration for the new data source. |
| examples/data-sources/fabric_workspace_git_outbound_policy/data-source.tf | Adds example data source usage. |
| examples/data-sources/fabric_workspace_git_outbound_policy/outputs.tf | Adds example output for the data source. |
| docs/resources/workspace_git_outbound_policy.md | Generated docs for the new resource. |
| docs/data-sources/workspace_git_outbound_policy.md | Generated docs for the new data source. |
| .changes/unreleased/added-20260309-142940.yaml | Changelog entry for data source addition (Issue 841). |
| .changes/unreleased/added-20260309-143029.yaml | Changelog entry for resource addition (Issue 842). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CatalinDabuleanu
approved these changes
Mar 10, 2026
| return func(_ context.Context, _ string, workspaceGitOutboundPolicy fabcore.NetworkRules, _ *fabcore.WorkspacesClientSetGitOutboundPolicyOptions) (resp azfake.Responder[fabcore.WorkspacesClientSetGitOutboundPolicyResponse], errResp azfake.ErrorResponder) { | ||
| if workspaceGitOutboundPolicy.DefaultAction != nil { | ||
| entity.DefaultAction = workspaceGitOutboundPolicy.DefaultAction | ||
| } else { |
Collaborator
There was a problem hiding this comment.
when is it null?
|
|
||
| reqDelete := fabcore.NetworkRules{} | ||
|
|
||
| _, err := r.client.SetGitOutboundPolicy(ctx, state.WorkspaceID.ValueString(), reqDelete, nil) |
Collaborator
There was a problem hiding this comment.
what is the default value?
should we have another property for behavior on deletion?
preserving or allowing with one as default value?
Contributor
Author
There was a problem hiding this comment.
When having sent an empty request body to the API i received DefaultAction set to Deny and rules as []. So I would assume Deny is the default value, but it is not documented anywhere so I think that if this is meant to reset to defaults, sending the empty request body is the most accurate one in getting the default values as intended. For other resources for example, default value seems to be Allow, so it's not consistent
catalina-gav
had a problem deploying
to
development
GitHub Actions
Error
catalina-gav
had a problem deploying
to
development
GitHub Actions
Error
catalina-gav
had a problem deploying
to
development
GitHub Actions
Error
catalina-gav
had a problem deploying
to
development
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
❓ What are you trying to address
Close #841
Close #842