feat(shortcut): add new shortcut_conflict_policy for fabric_shortcut by CatalinDabuleanu · Pull Request #770 · microsoft/terraform-provider-fabric

CatalinDabuleanu · 2025-12-09T21:55:49Z

📥 Pull Request

❓ What are you trying to address

This onboards new shortcut_conflict_policy attribute for fabric_shortcut. Closes #765

github-actions · 2025-12-09T21:56:29Z

Changelog Preview

v1.8.1-dev - March 11, 2026

✨ Added

#765 Onboard new shortcut_conflict_policy in fabric_shortcut

Copilot

Pull request overview

This PR adds a new shortcut_conflict_policy attribute to the fabric_shortcut resource, enabling users to control how conflicts are handled when a shortcut with the same name and path already exists. The attribute accepts values like Abort, CreateOrOverwrite, GenerateUniqueName, and OverwriteOnly, with Abort as the default.

Key Changes:

Added shortcut_conflict_policy optional string attribute to the resource schema with enum validation
Updated resource Create, Update, and Read methods to handle the new policy parameter
Extended the model to include the new field and properly serialize it to API requests

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`internal/services/shortcut/schema.go`	Adds the `shortcut_conflict_policy` attribute definition to the schema with validators for allowed enum values
`internal/services/shortcut/models.go`	Extends `resourceShortcutModel` with the new field and implements setter/getter methods to handle the policy parameter
`internal/services/shortcut/resource_shortcut.go`	Updates Create, Update, and Read operations to use the new conflict policy parameter when interacting with the API
`internal/services/shortcut/resource_shortcut_test.go`	Adds test coverage for the new attribute in the acceptance test's Create step
`examples/resources/fabric_shortcut/resource.tf`	Adds example usage of the new `shortcut_conflict_policy` attribute with a comment explaining the default behavior
`docs/resources/shortcut.md`	Documents the new optional attribute with its description and valid values
`docs/data-sources/shortcuts.md`	Documents the attribute for the data source (though this may be incorrect as it's a write-only parameter)
`docs/data-sources/shortcut.md`	Documents the attribute for the data source (though this may be incorrect as it's a write-only parameter)
`.changes/unreleased/added-20251209-215321.yaml`	Changelog entry documenting the new feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/services/shortcut/schema.go

internal/services/shortcut/resource_shortcut_test.go

docs/data-sources/shortcuts.md

docs/data-sources/shortcut.md

Copilot · 2025-12-09T22:05:25Z

internal/services/shortcut/schema.go

 			},
+			"shortcut_conflict_policy": superschema.StringAttribute{
+				Common: &schemaR.StringAttribute{
+					MarkdownDescription: "When provided, it defines the action to take when a shortcut with the same name and path already exists. The default action is 'Abort'",


[nitpick] The markdown description is missing a period at the end. For consistency with other attribute descriptions in the schema, add a period:

MarkdownDescription: "When provided, it defines the action to take when a shortcut with the same name and path already exists. The default action is 'Abort'.",

Suggested change

MarkdownDescription: "When provided, it defines the action to take when a shortcut with the same name and path already exists. The default action is 'Abort'",

MarkdownDescription: "When provided, it defines the action to take when a shortcut with the same name and path already exists. The default action is 'Abort'.",

github-actions · 2025-12-10T13:14:16Z

Package	Line Rate	Health
github.com/microsoft/terraform-provider-fabric/internal/auth	84%	✔
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes	66%	✔
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers	53%	➖
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils	50%	➖
github.com/microsoft/terraform-provider-fabric/internal/framework/validators	69%	✔
github.com/microsoft/terraform-provider-fabric/internal/functions	75%	✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem	76%	✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/tftypeinfo	75%	✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms	77%	✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils	85%	✔
github.com/microsoft/terraform-provider-fabric/internal/provider/client	91%	✔
github.com/microsoft/terraform-provider-fabric/internal/provider/config	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/provider	80%	✔
github.com/microsoft/terraform-provider-fabric/internal/provider/utils	63%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/activator	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/apacheairflowjob	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/capacity	84%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/connection	72%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/connectionra	71%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/copyjob	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/dataflow	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/datamart	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/deploymentpipeline	68%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/deploymentpipelinera	70%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/digitaltwinbuilder	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/domain	77%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/domainra	62%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/domainwa	71%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/environment	86%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse	93%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventstreamsourceconnection	83%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/folder	75%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/gateway	79%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/gatewayra	55%	➖
github.com/microsoft/terraform-provider-fabric/internal/services/graphqlapi	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/itemjobscheduler	72%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqldashboard	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase	87%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse	86%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/lakehousetable	80%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/mirroreddatabase	84%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/mounteddatafactory	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/notebook	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/report	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/shortcut	79%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/sparkcustompool	70%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/sparkenvsettings	79%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition	89%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/sparkwssettings	83%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/sqldatabase	90%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint	100%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/variablelibrary	90%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse	91%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/warehousesnapshot	90%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/workspace	79%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/workspacegit	69%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/workspacempe	77%	✔
github.com/microsoft/terraform-provider-fabric/internal/services/workspacera	76%	✔
Summary	76% (18901 / 24805)	✔

Minimum allowed line rate is 40%

OrBaubergMicrosoft · 2026-01-29T10:17:25Z

internal/services/shortcut/schema.go

 					Computed: isList,
 				},
 			},
+			"actual_name": superschema.StringAttribute{


this approach seems off,
do we need it if we do not support in the create new random name option?

No, if we do not support GenerateUniqueName we no longer need this attribute

…r-fabric into catalindabuleanu/shortcut

…t policy

feat(shortcut): add new shortcut_conflict_policy for fabric_shortcut

a7f64ab

Copilot AI review requested due to automatic review settings December 9, 2025 21:55

CatalinDabuleanu requested a review from a team as a code owner December 9, 2025 21:55

github-actions bot assigned CatalinDabuleanu Dec 9, 2025

CatalinDabuleanu temporarily deployed to development December 9, 2025 21:56 — with GitHub Actions Inactive

CatalinDabuleanu had a problem deploying to development December 9, 2025 21:56 — with GitHub Actions Failure

CatalinDabuleanu temporarily deployed to development December 9, 2025 21:56 — with GitHub Actions Inactive

CatalinDabuleanu had a problem deploying to development December 9, 2025 21:56 — with GitHub Actions Failure

Copilot started reviewing on behalf of CatalinDabuleanu December 9, 2025 22:01 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

removed shortcut_conflict_policy from datasource

8c0bd2e

CatalinDabuleanu temporarily deployed to development December 10, 2025 12:25 — with GitHub Actions Inactive

CatalinDabuleanu had a problem deploying to development December 10, 2025 12:25 — with GitHub Actions Failure

CatalinDabuleanu temporarily deployed to development December 10, 2025 12:25 — with GitHub Actions Inactive

Merge branch 'main' into catalindabuleanu/shortcut

e509ff6

CatalinDabuleanu had a problem deploying to development January 27, 2026 22:26 — with GitHub Actions Failure

CatalinDabuleanu temporarily deployed to development January 27, 2026 22:26 — with GitHub Actions Inactive

CatalinDabuleanu had a problem deploying to development January 27, 2026 22:26 — with GitHub Actions Failure

CatalinDabuleanu temporarily deployed to development January 27, 2026 22:26 — with GitHub Actions Inactive

CatalinDabuleanu had a problem deploying to development January 27, 2026 22:26 — with GitHub Actions Failure

improved shortcut_conflict_policy

079ae43

CatalinDabuleanu had a problem deploying to development January 28, 2026 00:41 — with GitHub Actions Failure

CatalinDabuleanu temporarily deployed to development January 28, 2026 00:41 — with GitHub Actions Inactive

CatalinDabuleanu had a problem deploying to development January 28, 2026 00:41 — with GitHub Actions Failure

CatalinDabuleanu temporarily deployed to development January 28, 2026 00:41 — with GitHub Actions Inactive

OrBaubergMicrosoft reviewed Jan 29, 2026

View reviewed changes

badeamarjieh added this to the 2026-03 milestone Feb 3, 2026

CatalinDabuleanu added 2 commits March 11, 2026 19:55

Merge branch 'main' of https://github.com/microsoft/terraform-provide…

ad43cd7

…r-fabric into catalindabuleanu/shortcut

removed generate unique name from possible values in shortcut conflic…

1e8e3a2

…t policy

CatalinDabuleanu temporarily deployed to development March 11, 2026 22:54 — with GitHub Actions Inactive

CatalinDabuleanu had a problem deploying to development March 11, 2026 22:54 — with GitHub Actions Error

CatalinDabuleanu temporarily deployed to development March 11, 2026 22:54 — with GitHub Actions Inactive

CatalinDabuleanu had a problem deploying to development March 11, 2026 22:54 — with GitHub Actions Error

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(shortcut): add new shortcut_conflict_policy for fabric_shortcut#770

feat(shortcut): add new shortcut_conflict_policy for fabric_shortcut#770
CatalinDabuleanu wants to merge 6 commits intomainfrom
catalindabuleanu/shortcut

CatalinDabuleanu commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 9, 2025

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

OrBaubergMicrosoft Jan 29, 2026

Uh oh!

CatalinDabuleanu Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	MarkdownDescription: "When provided, it defines the action to take when a shortcut with the same name and path already exists. The default action is 'Abort'",
	MarkdownDescription: "When provided, it defines the action to take when a shortcut with the same name and path already exists. The default action is 'Abort'.",

Conversation

CatalinDabuleanu commented Dec 9, 2025

📥 Pull Request

❓ What are you trying to address

Uh oh!

github-actions bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog Preview

v1.8.1-dev - March 11, 2026

✨ Added

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

OrBaubergMicrosoft Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

CatalinDabuleanu Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Dec 9, 2025 •

edited

Loading