feat(workspace): add capability to assign domain id to workspace#738
Open
CatalinDabuleanu wants to merge 9 commits intomainfrom
Open
feat(workspace): add capability to assign domain id to workspace#738CatalinDabuleanu wants to merge 9 commits intomainfrom
CatalinDabuleanu wants to merge 9 commits intomainfrom
Conversation
1 task
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the capability to assign a domain ID to a workspace in the fabric_workspace resource and data sources. The implementation allows users to assign, update, and unassign domains from workspaces.
Key changes:
- Added
domain_idattribute to workspace schema as an optional UUID field - Implemented domain assignment/unassignment logic in Create and Update operations
- Added comprehensive test coverage for domain CRUD operations
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/services/workspace/schema.go | Added domain_id SuperStringAttribute with UUID type validation, following the same pattern as capacity_id |
| internal/services/workspace/models.go | Added DomainID field to workspace models and created assignWorkspaceToDomainRequest helper struct |
| internal/services/workspace/resource_workspace.go | Implemented domain assignment in Create operation and domain assignment/unassignment in Update operation |
| internal/services/workspace/resource_workspace_test.go | Added unit test for invalid UUID validation and comprehensive acceptance test for domain CRUD operations |
| docs/resources/workspace.md | Updated resource documentation to include the new domain_id optional attribute |
| docs/data-sources/workspace.md | Updated data source documentation to include the new domain_id read-only attribute |
| docs/data-sources/workspaces.md | Updated data sources list documentation to include the new domain_id read-only attribute |
| .changes/unreleased/added-20251120-142738.yaml | Added changelog entry for the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
badeamarjieh
reviewed
Dec 1, 2025
badeamarjieh
reviewed
Dec 3, 2025
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
❓ What are you trying to address
Add capability to
fabric_workspaceto assign domain id to a workspaceThis closes #659