fix(shortcut): resource acc test should use WorkspaceRS#634
Open
catalina-gav wants to merge 1 commit intomainfrom
Open
fix(shortcut): resource acc test should use WorkspaceRS#634catalina-gav wants to merge 1 commit intomainfrom
catalina-gav wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the shortcut resource acceptance test to use WorkspaceRS instead of workspace data source for resource creation. The change improves test isolation by creating dedicated lakehouse resources instead of relying on shared test data.
Key changes:
- Switch from using workspace data source to WorkspaceRS for workspace ID lookup
- Create dedicated lakehouse resources dynamically within the test
- Separate workspace concerns by using different workspace IDs for the main resource and target references
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/services/shortcut/resource_shortcut_test.go | Updated acceptance test to use WorkspaceRS and create dedicated lakehouse resources |
| internal/services/shortcut/base_test.go | Added helper function to generate lakehouse resources for tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
Minimum allowed line rate is |
| ) | ||
|
|
||
| var itemTypeInfo = shortcut.ItemTypeInfo | ||
|
|
Collaborator
There was a problem hiding this comment.
why is this needed here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
❓ What are you trying to address
Use WorkspaceRS for shortcut resource creation acc test instead of workspace DS