feat(wellknown): add mirrored azure databricks catalog support #628
feat(wellknown): add mirrored azure databricks catalog support #628catalina-gav wants to merge 14 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Azure Databricks Mirrored Catalogs in Fabric by introducing the necessary configuration, naming conventions, and test fixtures.
- Adds
MirroredAzureDatabricksCatalogitem type support with endpoint mappings and naming conventions - Creates a new
Set-AzureDatabricksfunction to provision and configure Azure Databricks workspaces - Introduces test fixture templates for mirrored Azure Databricks catalog configurations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/scripts/Set-WellKnown.ps1 | Adds MirroredAzureDatabricksCatalog support, including endpoint mapping, naming conventions, item type registration, and a new Set-AzureDatabricks function with provisioning logic |
| internal/testhelp/fixtures/mirrored_azure_databricks_catalog/mirroringAzureDatabricksCatalog.json.tmpl | Adds test fixture template for mirroring configuration with a typo in the property name |
| internal/testhelp/fixtures/mirrored_azure_databricks_catalog/mirroredAzureDatabricksCatalog.json.tmpl | Adds test fixture template for mirrored catalog definition with proper schema reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...esthelp/fixtures/mirrored_azure_databricks_catalog/mirroringAzureDatabricksCatalog.json.tmpl
Outdated
Show resolved
Hide resolved
| name = $databricksWorkspace.Name | ||
| workspaceUrl = $databricksWorkspace.Properties.workspaceUrl | ||
| databricksWorkspaceConnectionId = $Env:FABRIC_TESTACC_WELLKNOWN_DATABRICKS_WS_CONNECTION_ID | ||
| catalogName = $catalogName |
There was a problem hiding this comment.
what happens if catalog is not found? and catalog is catalogName = ""
There was a problem hiding this comment.
the acc tests will fail
…-databricks-catalog
…-databricks-catalog
…-databricks-catalog
| "autoSync": "Enabled", | ||
| "catalogName": "{{.CATALOG_NAME}}", | ||
| "databricksWorkspaceConnectionId": "{{.DATABRICKS_WORKSPACE_CONNECTION_ID}}", | ||
| "mirroringMode": "{{.MIRRORING_MODE}}" |
There was a problem hiding this comment.
Documentation also gives you the possibility to configure storageConnectionId and mirrorConfiguration
Why haven't you also added those?
There was a problem hiding this comment.
Those aren't required and I do not have anything configured for those values. In this wellknown i've just created an az databricks containing a default unity catalog and don't have any table or storageConnID
📥 Pull Request
❓ What are you trying to address
Implement support for mirrored azure databricks catalog in WellKnown script