feat(mirrored_azure_databricks_catalog): onboard new mirrored azure databricks catalog DS and RS#627
Open
catalina-gav wants to merge 19 commits intomainfrom
Open
Conversation
added 6 commits
June 17, 2025 06:35
catalina-gav
had a problem deploying
to
development
GitHub Actions
Error
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
had a problem deploying
to
development
GitHub Actions
Error
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
had a problem deploying
to
development
GitHub Actions
Error
catalina-gav
had a problem deploying
to
development
GitHub Actions
Error
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR onboards a new mirrored Azure Databricks catalog feature by implementing both data source and resource support for managing Fabric Mirrored Azure Databricks Catalogs. The implementation follows the established patterns in the provider and includes comprehensive test coverage and documentation.
- Adds resource for creating and managing mirrored Azure Databricks catalogs
- Adds data sources for retrieving single catalogs or lists of catalogs
- Implements fake server support for testing
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/testhelp/fakes/fake_server.go | Registers the new mirrored Azure Databricks catalog entity handler |
| internal/testhelp/fakes/fabric_mirrored_azure_databricks_catalog.go | Implements fake server operations for testing |
| internal/services/mirroredazuredatabrickscatalog/* | Complete service implementation including models, schemas, resources, and data sources |
| internal/provider/provider.go | Registers the new resource and data sources with the provider |
| examples/* | Provides usage examples for both resources and data sources |
| docs/* | Generated documentation for the new features |
| .changes/* | Change log entries for the new features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
examples/data-sources/fabric_mirrored_azure_databricks_catalog/data-source.tf
Outdated
Show resolved
Hide resolved
examples/resources/fabric_mirrored_azure_databricks_catalog/resource.tf
Outdated
Show resolved
Hide resolved
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
changed the title
| func() datasource.DataSource { | ||
| return mirroredazuredatabrickscatalog.NewDataSourceMirroredAzureDatabricksCatalog(ctx) | ||
| }, | ||
| func() datasource.DataSource { |
Collaborator
There was a problem hiding this comment.
please make each entry a single line
Contributor
Author
There was a problem hiding this comment.
this is how the formatting is enforced upon saving the file and i dont think it can be bypassed
| // }, | ||
| // ), | ||
| // Check: resource.ComposeAggregateTestCheckFunc( | ||
| // resource.TestCheckResourceAttr(testDataSourceItemFQN, "workspace_id", workspaceID), |
Collaborator
There was a problem hiding this comment.
why commented out?
Contributor
Author
There was a problem hiding this comment.
this getDefinition is currently not working from the API's side for items that have been created without a definition (fails with Resource NotFound error message)
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
catalina-gav
had a problem deploying
to
development
GitHub Actions
Error
catalina-gav
had a problem deploying
to
development
GitHub Actions
Error
catalina-gav
had a problem deploying
to
development
GitHub Actions
Error
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
had a problem deploying
to
development
GitHub Actions
Error
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
catalina-gav
temporarily deployed
to
development
GitHub Actions
Inactive
| ExpectError: regexp.MustCompile(common.ErrorReadHeader), | ||
| }, | ||
|
|
||
| // // read by id with definition |
Contributor
There was a problem hiding this comment.
remove commented out code
Contributor
Author
There was a problem hiding this comment.
this getDefinition is currently not working from the API's side, will decide what to do with this test (uncomment or delete) after receiving an response from the API team
catalina-gav
had a problem deploying
to
development
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
Close #626
Close #625
❓ What are you trying to address
Onboard new fabric_mirrored_azure_databricks_catalog data source and resource