Add Presidio Evaluator to AI Evaluation Assistant#1905
Open
negruber1 wants to merge 9 commits intoronshakutai/presidio-evaluation-repofrom
Open
Add Presidio Evaluator to AI Evaluation Assistant#1905negruber1 wants to merge 9 commits intoronshakutai/presidio-evaluation-repofrom
negruber1 wants to merge 9 commits intoronshakutai/presidio-evaluation-repofrom
Conversation
RonShakutai
requested changes
Mar 12, 2026
Collaborator
RonShakutai
left a comment
There was a problem hiding this comment.
Great PR !!,
One bug all the rest looks good
Lets take it together next week.
| from models import Entity, EntityMiss, EvaluationRun, MissType, RiskLevel | ||
| from models import Entity, EntityMiss, MissType, RiskLevel | ||
| from presidio_evaluator import InputSample, Span, span_to_tag | ||
| from presidio_evaluator.evaluation import EvaluationResult, SpanEvaluator |
Collaborator
There was a problem hiding this comment.
there is an issue when in the ground truth there are two entities that overlap.
In this case the page is broken.
This raises a question: if the user tags the same area twice and they overlap, the page crashes. Should we limit the user in the UI, or should we resolve it in the backend?
We need to decide.

If I go back to the tagging and make sure there are no overlapping entities in the golden dataset, the error is resolved.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to the AI Assistant evaluation backend and frontend, focusing on dataset portability, evaluation metrics visualization, and dependency management. The most significant changes include making dataset paths portable across machines, enhancing the evaluation UI to display metrics per entity type, and updating dependencies for smoother setup and operation.
Dataset portability and management:
stored_pathandpathare saved in the registry to be relative instead of absolute, making dataset references portable across different machines. The loader now gracefully handles legacy absolute paths and attempts to resolve them if not found.datasets.json, using relativestored_pathvalues. [1] [2]Evaluation UI improvements:
API and dependency updates:
presidio-evaluatoras a backend dependency and updated setup instructions to include the required spaCy model download for local evaluation. [1] [2]Miscellaneous fixes:
package-lock.jsonby removing unnecessary"peer": truefields from several dependencies. [1] [2] [3] [4] [5] [6] [7] [8]These changes improve the robustness, usability, and maintainability of the evaluation workflow for AI Assistant.