fix: replace 1 bare except clauses with except Exception#1881
Merged
SharonHart merged 2 commits intomicrosoft:mainfrom Mar 3, 2026
Merged
fix: replace 1 bare except clauses with except Exception#1881SharonHart merged 2 commits intomicrosoft:mainfrom
SharonHart merged 2 commits intomicrosoft:mainfrom
Conversation
diastidean
approved these changes
Mar 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a test in presidio-image-redactor to replace a bare except: with except Exception: to align with Python/PEP 8 guidance and avoid catching BaseException subclasses like KeyboardInterrupt/SystemExit.
Changes:
- Replace one bare
except:clause withexcept Exception:in a DICOM verify engine unit test.
SharonHart
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bare
except:clauses withexcept Exception:for PEP 8 compliance.