[AI Generated] Azure: surface per-resource errors on truncated DeploymentFailed#4438
Open
[AI Generated] Azure: surface per-resource errors on truncated DeploymentFailed#4438
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Azure ARM deployment failure diagnostics in LISA by collecting and surfacing per-resource deployment operation errors when Azure returns truncated or otherwise unactionable top-level HttpResponseError details.
Changes:
- Add a helper to list ARM deployment operations and extract failed sub-resource errors.
- Extend
_deploy()error handling to optionally append these sub-resource errors when top-level deployment failures are aggregated/truncated or missing details.
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-arm64 latest
Test case details
|
LiliDeng
added a commit
that referenced
this pull request
Apr 27, 2026
Catch Azure-specific exceptions (HttpResponseError, ResourceNotFoundError) explicitly and log them at debug. Keep a broad fallback for unexpected errors but log with exc_info=True so the traceback is preserved instead of being silently swallowed. The original error path is unchanged: this helper still never raises. Addresses review comment on PR #4438.
LiliDeng
added a commit
that referenced
this pull request
Apr 27, 2026
Catch Azure-specific exceptions (HttpResponseError, ResourceNotFoundError) explicitly and log them at debug. Keep a broad fallback for unexpected errors but log with exc_info=True so the traceback is preserved instead of being silently swallowed. The original error path is unchanged: this helper still never raises. Addresses review comment on PR #4438.
LiliDeng
force-pushed
the
feat/log-deployment-operation-errors
branch
from
f446593 to
a95fe38
Compare
⏭️ AI Test Selection — SKIPPED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-arm64 latest Selected test cases |
LiliDeng
added a commit
that referenced
this pull request
Apr 27, 2026
Catch Azure-specific exceptions (HttpResponseError, ResourceNotFoundError) explicitly and log them at debug. Keep a broad fallback for unexpected errors but log with exc_info=True so the traceback is preserved instead of being silently swallowed. The original error path is unchanged: this helper still never raises. Addresses review comment on PR #4438.
LiliDeng
force-pushed
the
feat/log-deployment-operation-errors
branch
from
a95fe38 to
20caf6d
Compare
LiliDeng
added a commit
that referenced
this pull request
Apr 27, 2026
Catch Azure-specific exceptions (HttpResponseError, ResourceNotFoundError) explicitly and log them at debug. Keep a broad fallback for unexpected errors but log with exc_info=True so the traceback is preserved instead of being silently swallowed. The original error path is unchanged: this helper still never raises. Addresses review comment on PR #4438.
LiliDeng
force-pushed
the
feat/log-deployment-operation-errors
branch
from
20caf6d to
08ad4be
Compare
⏭️ AI Test Selection — SKIPPED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-arm64 latest Selected test cases |
LiliDeng
added a commit
that referenced
this pull request
Apr 27, 2026
Catch Azure-specific exceptions (HttpResponseError, ResourceNotFoundError) explicitly and log them at debug. Keep a broad fallback for unexpected errors but log with exc_info=True so the traceback is preserved instead of being silently swallowed. The original error path is unchanged: this helper still never raises. Addresses review comment on PR #4438.
LiliDeng
force-pushed
the
feat/log-deployment-operation-errors
branch
from
08ad4be to
5ad13c5
Compare
⏭️ AI Test Selection — SKIPPED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-arm64 latest Selected test cases |
LiliDeng
added a commit
that referenced
this pull request
Apr 27, 2026
Catch Azure-specific exceptions (HttpResponseError, ResourceNotFoundError) explicitly and log them at debug. Keep a broad fallback for unexpected errors but log with exc_info=True so the traceback is preserved instead of being silently swallowed. The original error path is unchanged: this helper still never raises. Addresses review comment on PR #4438.
LiliDeng
force-pushed
the
feat/log-deployment-operation-errors
branch
from
5ad13c5 to
1c1b0f0
Compare
⏭️ AI Test Selection — SKIPPED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-arm64 latest Selected test cases |
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-arm64 latest
Test case details
|
Catch Azure-specific exceptions (HttpResponseError, ResourceNotFoundError) explicitly and log them at debug. Keep a broad fallback for unexpected errors but log with exc_info=True so the traceback is preserved instead of being silently swallowed. The original error path is unchanged: this helper still never raises. Addresses review comment on PR #4438.
LiliDeng
force-pushed
the
feat/log-deployment-operation-errors
branch
from
1c1b0f0 to
48a3d30
Compare
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-arm64 latest
Test case details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an Azure ARM deployment fails, LISA currently only surfaces the top-level
HttpResponseError. In several common cases the top-level message is unactionable:DeploymentFailedwith the body"aggregated deployment error is too large"(Azure truncates the inner details when there are many failed sub-operations).ResourceDeploymentFailure: Encountered internal server error. Diagnostic information: timestamp '...', subscription id '...', tracking id '...'— only a tracking id is returned, no per-resource error.DeploymentFailedwith no nesteddetails.In these cases users have to re-run with
keep_environment:alwaysand dig through the Portal /az deployment operation group listto find which resource actually failed and why.Change
In
lisa/sut_orchestrator/azure/platform_.py:_collect_deployment_operation_errors()which callsself._rm_client.deployment_operations.list(resource_group_name, AZURE_DEPLOYMENT_NAME)after a failed deploy and extracts per-resourcetargetResource+ nestedstatusMessage.errorfor every operation whoseprovisioningState == "Failed"._deploy()'sHttpResponseErrorhandler, call this helper as a fallback when the top-level message looks aggregated/truncated, the code isResourceDeploymentFailure, orDeploymentFailedhas no nesteddetails. Append the collected sub-resource errors to both the log and the raisedLisaException.try/exceptand logs at debug on failure, so this never makes diagnostics worse.After this change a previously opaque error becomes:
Validation
smoke_test(success path) —Provisioning.smoke_test: PASSED(134.981 s case, 539 s total). Fallback does not affect the success path.smoke_testwithoutosdisk_size_in_gb:64(deliberate failure) — produces a normalDeploymentFailedwith details intact, fallback correctly skipped, error message identical to current behavior.The fallback branch itself triggers on real-world
ResourceDeploymentFailure/ aggregated-error responses, which are non-deterministic from Azure's side and can't be reliably synthesized; the helper is defensive and is exercised through the success / normal-failure paths above.🤖 Generated with the assistance of GitHub Copilot.