Skip to content

[AI Generated] BugFix: fix IndexError in _hot_add_disk_serial when no new device appears #4435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LiliDeng merged 1 commit into from
Apr 29, 2026
+13 −7
Merged

[AI Generated] BugFix: fix IndexError in _hot_add_disk_serial when no new device appears #4435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions lisa/microsoft/testsuites/core/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,16 +847,22 @@ def _hot_add_disk_serial(

# verify the lun number from linux VM
linux_device_luns_after = disk.get_luns()
linux_device_lun_diff = [
linux_device_luns_after[k]
for k in set(linux_device_luns_after) - set(linux_device_luns)
][0]
log.debug(f"linux_device_luns: {linux_device_luns}")
log.debug(f"linux_device_luns_after: {linux_device_luns_after}")
log.debug(f"linux_device_lun_diff: {linux_device_lun_diff}")
new_device_keys = set(linux_device_luns_after) - set(linux_device_luns)
assert_that(
linux_device_lun_diff, "No new device lun found on VM"
).is_equal_to(lun)
list(new_device_keys),
f"Expected new device at lun {lun} but no new device "
f"appeared. Before: {linux_device_luns}, "
f"After: {linux_device_luns_after}. This may indicate "
f"the VM size does not support this many data disks "
f"(max_data_disk_count={max_data_disk_count}).",
).is_not_empty()
linux_device_lun_diff = linux_device_luns_after[next(iter(new_device_keys))]
log.debug(f"linux_device_lun_diff: {linux_device_lun_diff}")
assert_that(linux_device_lun_diff, "New device lun mismatch").is_equal_to(
lun
)
Comment thread
LiliDeng marked this conversation as resolved.
Comment thread
LiliDeng marked this conversation as resolved.

# Remove all attached data disks
for disk_added in disks_added:
Expand Down
Loading