Migrate tests to import from @jest/globals instead of using globals

CLAUDE.md

@@ -70,7 +70,10 @@ Task functions can: return a Promise, call a `done` callback, or return a stream
 
 - TypeScript target: `es2019`, module: `commonjs`, strict mode
 - Prettier: 120 print width, single quotes, trailing commas, 2-space indent
-- Tests: Jest with ts-jest, test files in `src/**/__tests__/*.(test|spec).ts`
+- Tests:
+  - Jest with ts-jest
+  - Test files in `src/**/__tests__/*.(test|spec).ts`
+  - Functions such as `describe`, `it`, `expect` must be imported from `@jest/globals` (they are not implicitly available)
 - Each package compiles to `lib/` directory
 
 ## CI / Release

package.json

@@ -27,6 +27,7 @@
     "node": ">=14"
   },
   "devDependencies": {
+    "@jest/globals": "^29.5.0",
     "@microsoft/api-extractor": "7.52.9",
     "@types/fs-extra": "^11.0.0",
     "@types/jest": "^29.4.0",

packages/just-scripts/src/__tests__/getMockScript.ts

@@ -1,3 +1,4 @@
+import { expect } from '@jest/globals';
 import * as fs from 'fs';
 import * as path from 'path';
 

packages/just-scripts/src/copy/__tests__/CopyInstruction.spec.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it } from '@jest/globals';
 import { copyFilesToDestinationDirectory } from '../CopyInstruction';
 import { normalize } from 'path';
 

packages/just-scripts/src/copy/__tests__/executeCopyInstructions.spec.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it, beforeEach, afterEach } from '@jest/globals';
 import * as mockfs from 'mock-fs';
 import * as path from 'path';
 import * as fs from 'fs';

packages/just-scripts/src/tasks/__tests__/getNormalizedSpawnArgs.ts

@@ -1,3 +1,4 @@
+import { expect, jest } from '@jest/globals';
 import * as path from 'path';
 import type { spawn } from '../../utils/exec';
 

packages/just-scripts/src/tasks/__tests__/nodeExecTask.test.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it, jest, beforeEach, afterEach, afterAll } from '@jest/globals';
 import { fail } from 'assert';
 import type { TaskFunction } from 'just-task';
 import * as path from 'path';

packages/just-scripts/src/tasks/__tests__/tscTask.spec.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it, jest, beforeEach, afterEach } from '@jest/globals';
 import * as mockfs from 'mock-fs';
 import { spawn } from '../../utils';
 import { tscTask, tscWatchTask } from '../tscTask';
@@ -6,7 +7,7 @@ import { getNormalizedSpawnArgs } from './getNormalizedSpawnArgs';
 
 // Jest will hoist these before the imports above, so these modules will be mocked first
 jest.mock('../../utils/exec', () => {
-  const originalModule = jest.requireActual('../../utils/exec');
+  const originalModule = jest.requireActual('../../utils/exec') as typeof import('../../utils/exec');
   return {
     // Use real implementation of most exports
     ...originalModule,

packages/just-scripts/src/utils/__tests__/exec.spec.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it, jest, afterEach } from '@jest/globals';
 import * as cp from 'child_process';
 import * as path from 'path';
 import { encodeArgs, spawn } from '../exec';

packages/just-scripts/src/utils/__tests__/mergePackageJson.spec.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it } from '@jest/globals';
 import { mergePackageJson, _shouldUpdateDep } from '../mergePackageJson';
 import { PackageJson } from '../../interfaces/PackageJson';
 

packages/just-scripts/src/utils/__tests__/paths.spec.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it, afterEach } from '@jest/globals';
 import * as path from 'path';
 import * as os from 'os';
 import { paths } from '../paths';

packages/just-scripts/src/utils/__tests__/readPackageJson.spec.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it, beforeEach, afterEach } from '@jest/globals';
 import { readPackageJson } from '../readPackageJson';
 import * as mockfs from 'mock-fs';
 

packages/just-task/src/__tests__/chain.spec.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it, jest } from '@jest/globals';
 import { task } from '../task';
 import { chain } from '../chain';
 import { parallel } from '../undertaker';

packages/just-task/src/__tests__/logger.spec.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it, jest, beforeAll, beforeEach, afterAll } from '@jest/globals';
 import { logger } from '../logger';
 import chalk = require('chalk');
 

packages/just-task/src/__tests__/resolve.spec.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it, jest, afterEach, beforeEach } from '@jest/globals';
 import * as path from 'path';
 import {
   _isFileNameLike,

packages/just-task/src/__tests__/task.spec.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it, jest, beforeAll, beforeEach, afterAll } from '@jest/globals';
 import { task } from '../task';
 import { parallel, undertaker } from '../undertaker';
 import { logger } from '../logger';

packages/just-task/src/__tests__/watch.spec.ts

@@ -1,3 +1,4 @@
+import { describe, expect, it } from '@jest/globals';
 import { watch } from '../watch';
 import * as fs from 'fs';
 import * as path from 'path';
@@ -25,7 +26,7 @@ describe('watch', () => {
         done();
       } catch (error) {
         cleanup();
-        done(error);
+        done(error instanceof Error ? error : new Error(String(error)));
       }
     };
 

scripts/jest.config.js

@@ -10,6 +10,7 @@ module.exports = {
   testEnvironment: 'node',
   testMatch: ['**/?(*.)+(spec|test).[jt]s'],
   verbose: true,
+  injectGlobals: false,
   transform: {
     '^.+\\.tsx?$': [
       'ts-jest',

tsconfig.json

@@ -17,6 +17,6 @@
     "skipLibCheck": true,
     "esModuleInterop": false,
     "allowSyntheticDefaultImports": false,
-    "types": ["node", "jest"]
+    "types": ["node"]
   }
 }

yarn.lock

@@ -427,7 +427,7 @@
     jest-mock "^29.7.0"
     jest-util "^29.7.0"
 
-"@jest/globals@^29.7.0":
+"@jest/globals@^29.5.0", "@jest/globals@^29.7.0":
   version "29.7.0"
   resolved "https://registry.yarnpkg.com/@jest/globals/-/globals-29.7.0.tgz#8d9290f9ec47ff772607fa864ca1d5a2efae1d4d"
   integrity sha512-mpiz3dutLbkW2MNFubUGUEVLkTGiqW6yLVTA+JbP6fI6J5iL9Y0Nlg8k95pcF8ctKwCS7WVxteBs29hhfAotzQ==