Conversation
… .NET 11 exception Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
…nore Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Rename custom events to avoid browser event naming conflicts
fix: rename custom events whose name matches browserEventName to avoid .NET 11 exception
Mar 8, 2026
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.8%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Fluent UI Blazor’s custom event registrations to avoid the .NET 11 runtime exception that occurs when a registerCustomEventType() name matches its browserEventName, by renaming the Blazor-side event types while keeping the underlying DOM event names unchanged.
Changes:
- Renamed custom event type registrations:
listboxchange→fluentlistboxchange,immediate→fluentimmediate. - Updated corresponding Blazor bindings (
[EventHandler]attributes and Razor@on*usages) to the new event names. - Updated bUnit tests to trigger the renamed custom events; added a
.gitignoreentry related tosrc/Core.Scripts/obj*.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Core.Scripts/src/FluentUICustomEvents.ts | Renames custom event type identifiers to differ from browserEventName (DOM event name unchanged). |
| src/Core/Events/EventHandlers.cs | Updates [EventHandler] attributes to the new onfluent* event names. |
| src/Core/Components/List/FluentListbox.razor | Updates internal handler binding to @onfluentlistboxchange. |
| src/Core/Components/TextInput/FluentTextInput.razor | Updates internal handler binding to @onfluentimmediate. |
| src/Core/Components/TextArea/FluentTextArea.razor | Updates internal handler binding to @onfluentimmediate. |
| tests/Core/Components/TextInput/FluentTextInputTests.razor | Updates test event triggering to onfluentimmediate. |
| tests/Core/Components/TextArea/FluentTextAreaTests.razor | Updates test event triggering to onfluentimmediate. |
| .gitignore | Adds ignore pattern for src/Core.Scripts/obj*. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
dvoituron
requested changes
Mar 8, 2026
Collaborator
|
@copilot implement the changes mentioned by @dvoituron. Also undo the change to the gitignore file. |
…ignore Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
…fact Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Contributor
Author
Done — renamed to |
vnbaaij
approved these changes
Mar 8, 2026
dvoituron
requested changes
Mar 9, 2026
Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Contributor
Author
All done — renamed to |
dvoituron
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
.NET 11 throws a runtime exception when a custom Blazor event registered via
blazor.registerCustomEventType()has the same name as itsbrowserEventName. Two events inFluentUICustomEvents.tsviolated this constraint:The new names
listchangeandtextimmediatefollow the short, descriptive naming style used by other custom events in this file (e.g.tabchange,radiochange,treechanged), consistent with the pattern established in #4605.Affected files:
FluentUICustomEvents.ts— rename both registrationsEventHandlers.cs—onlistboxchange→onlistchange,onimmediate→ontextimmediateFluentListbox.razor—@onlistboxchange→@onlistchangeFluentTextInput.razor/FluentTextArea.razor—@onimmediate→@ontextimmediate🎫 Issues
👩💻 Reviewer Notes
Pure rename — no behavioral change. The actual DOM events fired by the web components (
listboxchange,immediate) are unchanged; only the Blazor-side event type names are updated. Review focus: confirm all@on*usages and[EventHandler]attributes are consistently updated.No unrelated files are modified — the
src/Core.Scripts/.gitignoreandsrc/Core.Scripts/package-lock.jsonchanges that appeared in earlier commits have been reverted.📑 Test Plan
Existing bUnit tests for
FluentListbox,FluentTextInput, andFluentTextAreaupdated to use the renamed event names. All 103 tests pass.Smoke test: load any page using
FluentListbox,FluentTextInput, orFluentTextAreaon .NET 11 Preview and confirm no console exception about duplicate event names.✅ Checklist
General
Component-specific
⏭ Next Steps
No further follow-up expected — all known same-name violations are now resolved.
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.