Skip to content

Maintain Old Consent State for Invalid values #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Niyibitanga wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Maintain Old Consent State for Invalid values #994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/clarity-js/src/data/metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,9 @@ export function consentv2(consentState: ConsentState = defaultStatus, source: nu
function getConsentData(consentState: ConsentState): ConsentData {
let consent: ConsentData = {
source: consentState.source ?? ConsentSource.Implicit,
ad_Storage: consentState.ad_Storage === Constant.Granted ? BooleanFlag.True : BooleanFlag.False,
analytics_Storage: consentState.analytics_Storage === Constant.Granted ? BooleanFlag.True : BooleanFlag.False,
//TODO: Add consentStatus as fallback once https://github.com/microsoft/clarity/pull/992/files is merged.
ad_Storage: consentValue(consentState.ad_Storage),
analytics_Storage: consentValue(consentState.analytics_Storage)
};

return consent;
Expand All @@ -202,6 +203,10 @@ function normalizeConsent(value: unknown, fallback: string = Constant.Denied): s
return typeof value === 'string' ? value.toLowerCase() : fallback;
}

function consentValue(value: string, fallback: BooleanFlag = BooleanFlag.False): BooleanFlag {
return value === Constant.Granted ? BooleanFlag.True : value === Constant.Denied ? BooleanFlag.False : fallback;
}

export function clear(): void {
// Clear any stored information in the cookie that tracks session information so we can restart fresh the next time
setCookie(Constant.SessionKey, Constant.Empty, 0);
Expand Down