Add parameter array to prevent command injection#21920
Open
sanjuyadav24 wants to merge 3 commits intomasterfrom
Open
Add parameter array to prevent command injection#21920sanjuyadav24 wants to merge 3 commits intomasterfrom
sanjuyadav24 wants to merge 3 commits intomasterfrom
Conversation
sanjuyadav24
requested review from
a team,
manolerazvan and
tarunramsinghani
as code owners
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses CWE-78 (OS Command Injection) vulnerabilities in three Azure Pipelines tasks where user-controlled inputs were being passed to shell execution via string interpolation (child_process.execSync with template literals or tl.execSync with string arguments).
Task Name
JavaToolInstallerV0
AzureResourceManagerTemplateDeploymentV3
AzureContainerAppsV1
Description
Converts shell-based command execution to array-based argument passing to eliminate OS command injection vectors:
Risk Assessment (Low / Medium / High)
Low
Change Behind Feature Flag (Yes / No)
No
Tech Design / Approach
NA
Documentation Changes Required (Yes/No)
NA
Unit Tests Added or Updated (Yes / No)
NA
Additional Testing Performed
Tested via canarytest pipeline
Logging Added/Updated (Yes/No)
No
Telemetry Added/Updated (Yes/No)
No
Rollback Scenario and Process (Yes/No)
NA
Dependency Impact Assessed and Regression Tested (Yes/No)
Yes
Checklist