Skip to content

L0 functional coverage for DownloadPackageV1, and NuGetToolInstaller (V0/V1)#21918

Open
AlexVTor wants to merge 11 commits intomasterfrom
usrs/alextorres/NuGetV0DownloadPackageV0L0s
Open

L0 functional coverage for DownloadPackageV1, and NuGetToolInstaller (V0/V1)#21918
AlexVTor wants to merge 11 commits intomasterfrom
usrs/alextorres/NuGetV0DownloadPackageV0L0s

Conversation

@AlexVTor
Copy link
Contributor

@AlexVTor AlexVTor commented Mar 10, 2026

Context

Describe the context or motivation for this PR. Include links to any related Azure DevOps Work Items or GitHub issues.
📌 How to link to ADO Work Items


Task Name

NpmV1
DownloadPackageV1
NuGetToolInstallerV0
NuGetToolInstallerV1


Description

  • Expands L0 coverage across NuGetV0, DownloadPackageV1, NuGetToolInstallerV0, and NuGetToolInstallerV1 with emphasis on functional behavior (eg: branching, routing, command/tool invocation, and failure paths).
  • Refactors NuGetV0 version-threshold logic into a small helper and adds unit-style L0 tests for logic.
  • Adds unit-style L0 tests for DownloadPackageV1 retry/backoff behavior and package-builder routing/mapping behavior.
  • Strengthens installer L0 assertions to verify branch exclusivity (explicit vs default/resolved version paths) and failure short-circuit behavior.
  • Keeps changes scoped to tests and low-risk helper extraction; no intended runtime behavior changes.

Risk Assessment (Low / Medium / High)

Low - Runtime behavior has not been changed


Change Behind Feature Flag (Yes / No)

N - Tests cannot be gated behind FF


Tech Design / Approach

  • Design has been written and reviewed.
  • Any architectural decisions, trade-offs, and alternatives are captured.
    N/A

Documentation Changes Required (Yes/No)

Indicate whether related documentation needs to be updated.

  • User guides, API specs, system diagrams, or runbooks are updated.
    N/A

Unit Tests Added or Updated (Yes / No)

Indicate whether unit tests were added or modified to reflect these changes.
Y


Additional Testing Performed

List all other tests performed (manual or automated, including integration, regression, scenario tests, etc.).


Logging Added/Updated (Yes/No)

  • Appropriate log statements are added with meaningful messages.
  • Logging does not expose sensitive data.
  • Log levels are used correctly (e.g., info, warn, error).
    Y

Telemetry Added/Updated (Yes/No)

  • Custom telemetry (e.g., counters, timers, error tracking) is added as needed.
  • Events are tagged with proper metadata for filtering and analysis.
  • Telemetry is validated in staging or test environments.
    Y

Rollback Scenario and Process (Yes/No)

  • Rollback plan is documented.
    Rollback via taskoverride can be applied

Dependency Impact Assessed and Regression Tested (Yes/No)

  • All impacted internal modules, APIs, services, and third-party libraries are analyzed.
  • Results are reviewed and confirmed to not break existing functionality.

Checklist

  • Related issue linked (if applicable)
  • Task version was bumped — see versioning guide
  • Verified the task behaves as expected

@AlexVTor AlexVTor requested a review from a team as a code owner March 10, 2026 21:45
@AlexVTor
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@AlexVTor AlexVTor changed the title L0 functional coverage for NuGetV0, DownloadPackageV1, and NuGetToolInstaller (V0/V1) L0 functional coverage for DownloadPackageV1, and NuGetToolInstaller (V0/V1) Mar 11, 2026
@AlexVTor
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@AlexVTor
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@AlexVTor
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@AlexVTor AlexVTor force-pushed the usrs/alextorres/NuGetV0DownloadPackageV0L0s branch from 73f4f23 to cc99e44 Compare March 11, 2026 02:35
@AlexVTor
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant