Skip to content

fix: clean up temp directory in JupyterCodeExecutor.stop() #7394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jah-yee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: clean up temp directory in JupyterCodeExecutor.stop() #7394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion python/packages/autogen-ext/src/autogen_ext/code_executors/jupyter/_jupyter_code_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,12 @@ def __init__(
if timeout < 1:
raise ValueError("Timeout must be greater than or equal to 1.")

self._output_dir: Path = Path(tempfile.mkdtemp()) if output_dir is None else Path(output_dir)
if output_dir is None:
self._temp_dir = tempfile.TemporaryDirectory()
self._output_dir = Path(self._temp_dir.name)
else:
self._output_dir = Path(output_dir)
self._temp_dir = None
self._output_dir.mkdir(exist_ok=True, parents=True)

self._temp_dir: Optional[tempfile.TemporaryDirectory[str]] = None
Expand Down Expand Up @@ -308,6 +313,11 @@ async def stop(self) -> None:
self._client = None
self._started = False

# Clean up the temporary directory if it was created internally
if self._temp_dir is not None:
self._temp_dir.cleanup()
self._temp_dir = None

def _to_config(self) -> JupyterCodeExecutorConfig:
"""Convert current instance to config object"""
return JupyterCodeExecutorConfig(
Expand Down