fix: move temp_dir cleanup after container stop in DockerCommandLineCodeExecutor.stop()#7390
Open
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: move temp_dir cleanup after container stop in DockerCommandLineCodeExecutor.stop()#7390Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Conversation
When output_dir is None, JupyterCodeExecutor creates a temp directory via tempfile.mkdtemp() but never cleans it up in stop(). This leaks a directory per executor lifetime. Fixes microsoft#7382
…odeExecutor.stop() Fixes microsoft#7383 - Ensures temporary directory cleanup happens after the Docker container is stopped, preventing potential issues with files being deleted while still in use by the container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7383 - Ensures temporary directory cleanup happens after the Docker container is stopped, preventing potential issues with files being deleted while still in use by the container.
Changes
temp_dir.cleanup()from the beginning ofstop()method to thefinallyblock