fix: clean up temporary directory in JupyterCodeExecutor.stop()#7382
Open
SinzoL wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: clean up temporary directory in JupyterCodeExecutor.stop()#7382SinzoL wants to merge 1 commit intomicrosoft:mainfrom
SinzoL wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When output_dir is None, JupyterCodeExecutor creates a temp directory via tempfile.mkdtemp() but never cleans it up in stop(). This leaks a directory per executor lifetime. Switch from mkdtemp() to TemporaryDirectory() and call cleanup() in stop() so the temp dir is properly removed when the executor is stopped. Fixes microsoft#7217
Jah-yee
pushed a commit
to Jah-yee/autogen
that referenced
this pull request
Mar 13, 2026
When output_dir is None, JupyterCodeExecutor creates a temp directory via tempfile.mkdtemp() but never cleans it up in stop(). This leaks a directory per executor lifetime. Fixes microsoft#7382
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When output_dir is None, JupyterCodeExecutor creates a temp directory via tempfile.mkdtemp() but never cleans it up in stop(). This leaks a directory per executor lifetime. Switch from mkdtemp() to TemporaryDirectory() and call cleanup() in stop() so the temp dir is properly removed when the executor is stopped. Fixes #7217