fix: fix build_python_functions_file generating malformed source#7381
Open
SinzoL wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: fix build_python_functions_file generating malformed source#7381SinzoL wants to merge 1 commit intomicrosoft:mainfrom
SinzoL wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When global_imports is empty, the function produced a leading blank line followed by an extra trailing newline per function. This resulted in source code that fails linting tools and confuses downstream parsing. Rewrite the assembly logic to: - Only emit the import block when there are actual imports - Sort imports for deterministic output - Use a single join with double newlines for clean separation - End with exactly one trailing newline (PEP 8) Fixes microsoft#7209
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When global_imports is empty, the function produced a leading blank line followed by an extra trailing newline per function. This resulted in source code that fails linting tools and confuses downstream parsing. Rewrite the assembly logic to only emit the import block when there are actual imports, sort imports for deterministic output, use a single join with double newlines for clean separation, and end with exactly one trailing newline (PEP 8). Fixes #7209