-
Notifications
You must be signed in to change notification settings - Fork 859
ci: add SynapseML-Internal compatibility check to OSS pipeline #2542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BrendanWalsh
wants to merge
7
commits into
master
Choose a base branch
from
brwals/internal-compat-check
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+212
−1
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
714f91f
ci: add optional SynapseML-Internal compatibility check
BrendanWalsh 28a9b07
Add PipAuthenticate for Synapse-Conda feed + Anaconda TOS accept
BrendanWalsh 47e16ca
Free disk space before conda env creation + bump timeout
BrendanWalsh 5f004b3
Disable SemPy parquet writer in InternalCompat job
BrendanWalsh 3143041
Fix test reporting and restrict to spark.aifunc only
BrendanWalsh 7d1b4d9
ci: add Internal Python tests to InternalCompat job
smamindl fb74a9d
fix: address review — guard OSS_VERSION + modern conda activate
smamindl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the
resources.repositoriesblock, declaring the pipeline repo (repository: self) is typically unnecessary (the pipeline already has an implicitselfrepo forcheckout: self). Consider removing this entry to reduce confusion and keep only the externalSynapseML-Internalrepository resource.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explicit
selfdeclaration is needed here. The original pipeline had- repo: self(shorthand syntax). When restructuring to the fullresources.repositoriesblock to add theSynapseML-Internalexternal repo, theselfentry must be included — ADO requires it in the list format for multi-repo checkout (checkout: self+checkout: SynapseML-Internal) to work correctly.