Skip to content

Security: Fix Local privilege escalation via DLL hijack #46145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vanzue wants to merge 11 commits into
base: main
Choose a base branch
from
+15 −4
Draft

Security: Fix Local privilege escalation via DLL hijack #46145

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ae309fa
Try fix a security issue
vanzue Mar 15, 2026
e63eb91
fix build
vanzue Mar 15, 2026
f1977b1
Potential fix for pull request finding
vanzue Mar 16, 2026
306de28
fix review for folder enforcement
vanzue Mar 16, 2026
a295d9e
Merge branch 'dev/vanzue/fix-sec' of github.com:microsoft/PowerToys i…
vanzue Mar 16, 2026
34643ed
fix ci
vanzue Mar 16, 2026
be048b5
add diagnostic
vanzue Mar 16, 2026
c100e5b
post modify dacl after package identity change.
vanzue Mar 16, 2026
c150938
fix spell again
vanzue Mar 16, 2026
5da7c81
yeah.. why do we need so many code
vanzue Mar 16, 2026
3a3a4e0
fix spell
vanzue Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/actions/spell-check/expect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,6 @@ jpnime
Jsons
jsonval
jxr
kbmcontrols
keybd
KEYBDDATA
KEYBDINPUT
Expand Down Expand Up @@ -818,7 +817,6 @@ Metadatas
metafile
metapackage
mfc
mfalse
Mgmt
Microwaved
midl
Expand Down Expand Up @@ -877,7 +875,6 @@ msrc
msstore
msvcp
MTND
mtrue
MULTIPLEUSE
multizone
muxc
Expand Down Expand Up @@ -1292,7 +1289,7 @@ SCREENFONTS
screensaver
screenshots
scrollviewer
SDDL
sddl
SDKDDK
sdns
searchterm
Expand Down
10 changes: 10 additions & 0 deletions installer/PowerToysSetupVNext/DscResources.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@

<ComponentGroup Id="DscResourcesComponentGroup">
<ComponentRef Id="PowerToysDSCReference" />
<?if $(var.PerUser) = "false" ?>
<Component Id="SecureDSCModulesFolder" Guid="7D2F4E57-CCB2-4F89-9B8B-62E9B3CC4E12" Directory="DSCModulesReferenceFolder" Bitness="always64">
<RegistryKey Root="$(var.RegistryScope)" Key="Software\Classes\powertoys\components">
<RegistryValue Type="string" Name="SecureDSCModulesFolder" Value="" KeyPath="yes" />
</RegistryKey>
<CreateFolder>
<PermissionEx Sddl="D:PAI(A;OICI;GA;;;SY)(A;OICI;GA;;;BA)(A;OICI;GRGX;;;BU)(A;OICIIO;GA;;;CO)" />
</CreateFolder>
</Component>
<?endif?>
<Component Id="RemoveDSCModulesFolder" Guid="A3C77D92-4E97-4C1A-9F2E-8B3C5D6E7F80" Directory="DSCModulesReferenceFolder">
<RegistryKey Root="$(var.RegistryScope)" Key="Software\Classes\powertoys\components">
<RegistryValue Type="string" Name="RemoveDSCModulesFolder" Value="" KeyPath="yes" />
Expand Down
Loading