CmdPal: Fix missing primary context command for late-bound items#46131
Open
jiripolasek wants to merge 1 commit intomainfrom
Open
CmdPal: Fix missing primary context command for late-bound items#46131jiripolasek wants to merge 1 commit intomainfrom
jiripolasek wants to merge 1 commit intomainfrom
Conversation
…d commands - Creates the default primary context-menu item lazily when Command or Command.Name becomes available after SlowInitializeProperties(). - Refreshes AllCommands, SecondaryCommand, and HasMoreCommands notifications for late command materialization and Show Details updates. - Keeps the snapshot-based context menu flow intact while ensuring the primary command participates in the context menu. - Adds a unit test for the issue.
jiripolasek
added
the
Product-Command Palette
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does fix a bug where an item that starts with a null or empty primary command never adds that primary action to the context menu after the extension later provides a real command.
CommandorCommand.Namebecomes available afterSlowInitializeProperties()AllCommands,SecondaryCommand, andHasMoreCommandsnotifications for late command materialization and Show Details updates.Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed