Conversation
jiripolasek
approved these changes
Mar 15, 2026
Collaborator
jiripolasek
left a comment
There was a problem hiding this comment.
LGTM. I have no issue deploying this locally... and that scares me. I'm going to circle back and figure out why I have a problem deploying it with the Extensions SDK from NuGet.org.
As a minor detail, I took the liberty of updating the SLNF for the extension: #46136 - but that just devexp.
Contributor
Author
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
At first version, tried to use the project reference instead of package reference, while it did not work in my local environment, so used package reference instead.
While planned to project reference for many reasons like first day problem explosure in sdk, maintain the strict consistent winmd with the extension host.
Hopefully to solve some of the extension not starting problem.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Built an installer and validated in my arm64 and x64 machine, works perfectly