[FancyZones] Add option to not cycle through the end of the zone list + Maximize/Minimize#45972
Open
romibi wants to merge 1 commit intomicrosoft:mainfrom
Open
[FancyZones] Add option to not cycle through the end of the zone list + Maximize/Minimize#45972romibi wants to merge 1 commit intomicrosoft:mainfrom
romibi wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to FancyZones not cycle through the end of the zone list + Maximize/Minimize
This allows:
Solves the base problem of issues #31098, #32069, #21214, #35397 and #18638 .
Does NOT solve the idea in issue #31098 to have an override key to temporarily disable "Override Windows Snap".
PR Checklist
(no temporary disable of "Override Window Snap)
(although not with Win+Enter)
(although not with Ctrl+Win+Up)
Added on the required places:no new binariesJSON for signing for new binariesWXS for installer for new binaries and localization folderYML for CI pipeline for new test projectsYML for signed pipelineDetailed Description of the Pull Request / Additional comments
In the code to cycle through the zones I added an early exit if cycle is disabled.
In the calling code I added maximizing/minimizing code when snapping was unsuccessful and the snap was called with VK_UP/VK_DOWN.
Something I also tried to implement but had to discard any attempts:
To add an override to temporarily disable "Override Windows Snap" while CTRL is pressed. But if I understand the code correctly that would already work in the unmodified version if Windows Snap would do anything while CTRL is pressed …
The Unit Tests don't work on my machine! Not even the ones on main branch.
But I added similar calls to places where I found "MoveWindowAcrossMonitors".
But for this more help is needed.
Screenshot of the Settings Dialog:

Validation Steps Performed
Modifications done because I was personally annoyed by the old behavior. I am using the modified version (minus the settings) productively since a few weeks. I am switching to the version with the settings today.