[Dev] Fix GenerateResourceFiles task: add path quoting to handle spaces in convert-resx-to-rc.ps1 invocation by snickler · Pull Request #45927 · microsoft/PowerToys

snickler · 2026-03-04T23:35:05Z

Summary of the Pull Request

Adds single-quote wrapping around the PowerShell script path and the $(MSBuildThisFileDirectory) parameter in every GenerateResourceFiles MSBuild target across the solution. Without quoting, the Exec command silently fails (or produces incorrect results) when the repository is checked out under a path that contains spaces.

The affected targets all invoke convert-resx-to-rc.ps1 like:

<!-- Before -->
<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted $(RepoRoot)tools\build\convert-resx-to-rc.ps1 $(MSBuildThisFileDirectory) ..." />

<!-- After -->
<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted &quot;$(RepoRoot)tools\build\convert-resx-to-rc.ps1&quot; &quot;$(MSBuildThisFileDirectory)&quot; ..." />

PR Checklist

Closes: #xxx
Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
Tests: No behavioral changes; build-time script quoting fix only. Verified locally that affected projects build correctly.
Localization: No user-facing strings changed
Dev docs: No doc changes needed
New binaries: N/A

Detailed Description of the Pull Request / Additional comments

The GenerateResourceFiles MSBuild <Exec> commands in 29 .vcxproj files were passing the PowerShell script path and the project directory path as unquoted arguments. PowerShell treats spaces as argument separators, so any path segment containing a space caused the script invocation to break.

Affected projects:

ActionRunner
Update
AdvancedPaste
AlwaysOnTop
ColorPicker
EnvironmentVariables
FancyZones
FileLocksmith (ContextMenu & Ext)
Hosts
ImageResizer (ContextMenu & dll)
KeyboardManager (Editor, EditorLibrary, dll)
Launcher
NewPlus (win10 & main)
PowerOCR
PowerRename (ContextMenu & dll)
PreviewPane (Markdown & powerpreview)
Runner
ShortcutGuide (ShortcutGuide & ModuleInterface)
Workspaces (Launcher, SnapshotTool, WindowArranger)

Validation Steps Performed

Built affected modules locally with a path containing spaces; GenerateResourceFiles target now completes without error.
Confirmed generated .rc / .h resource files are produced correctly.

Copilot

Pull request overview

This PR aims to make the MSBuild GenerateResourceFiles targets resilient to repo paths containing spaces by adding quoting around the convert-resx-to-rc.ps1 script path and the project directory argument across multiple .vcxproj files.

Changes:

Updated GenerateResourceFiles <Exec> commands to wrap the PowerShell script path in quotes.
Updated GenerateResourceFiles <Exec> commands to wrap the directory argument ($(MSBuildThisFileDirectory) or variants) in quotes.
(Incidental) Normalized formatting/line endings in KeyboardManager.vcxproj around the edited region.

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 29 comments.

Show a summary per file

File	Description
src/runner/runner.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/previewpane/powerpreview/powerpreview.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/previewpane/MarkdownPreviewHandlerCpp/MarkdownPreviewHandlerCpp.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/powerrename/dll/PowerRenameExt.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/powerrename/PowerRenameContextMenu/PowerRenameContextMenu.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/launcher/Microsoft.Launcher/Microsoft.Launcher.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/keyboardmanager/dll/KeyboardManager.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/keyboardmanager/KeyboardManagerEditorLibrary/KeyboardManagerEditorLibrary.vcxproj	Quote PowerShell script + editor directory arg in `GenerateResourceFiles`.
src/modules/keyboardmanager/KeyboardManagerEditor/KeyboardManagerEditor.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/imageresizer/dll/ImageResizerExt.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/imageresizer/ImageResizerContextMenu/ImageResizerContextMenu.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/fancyzones/FancyZonesLib/FancyZonesLib.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/colorPicker/ColorPicker/ColorPicker.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/alwaysontop/AlwaysOnTop/AlwaysOnTop.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/Workspaces/WorkspacesWindowArranger/WorkspacesWindowArranger.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/Workspaces/WorkspacesSnapshotTool/WorkspacesSnapshotTool.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/Workspaces/WorkspacesLauncher/WorkspacesLauncher.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/ShortcutGuide/ShortcutGuideModuleInterface/ShortcutGuideModuleInterface.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/ShortcutGuide/ShortcutGuide/ShortcutGuide.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/PowerOCR/PowerOCRModuleInterface/PowerOCRModuleInterface.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/NewPlus/NewShellExtensionContextMenu.win10/NewPlus.ShellExtension.win10.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/NewPlus/NewShellExtensionContextMenu/NewShellExtensionContextMenu.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/Hosts/HostsModuleInterface/HostsModuleInterface.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/FileLocksmith/FileLocksmithExt/FileLocksmithExt.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/FileLocksmith/FileLocksmithContextMenu/FileLocksmithContextMenu.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/EnvironmentVariables/EnvironmentVariablesModuleInterface/EnvironmentVariablesModuleInterface.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/modules/AdvancedPaste/AdvancedPasteModuleInterface/AdvancedPasteModuleInterface.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/Update/PowerToys.Update.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.
src/ActionRunner/actionRunner.vcxproj	Quote PowerShell script + directory args in `GenerateResourceFiles`.

Copilot · 2026-03-04T23:43:33Z

src/modules/Workspaces/WorkspacesLauncher/WorkspacesLauncher.vcxproj

  <Import Project="..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props')" />
  <Target Name="GenerateResourceFiles" BeforeTargets="PrepareForBuild">
-    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted $(SolutionDir)tools\build\convert-resx-to-rc.ps1 $(MSBuildThisFileDirectory) resource.base.h resource.h WorkspacesLauncherResource.base.rc WorkspacesLauncherResource.rc" />
+    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(SolutionDir)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h WorkspacesLauncherResource.base.rc WorkspacesLauncherResource.rc" />


Exec runs through cmd.exe, where single quotes are not treated as quoting characters. This means PowerShell receives the script path and $(MSBuildThisFileDirectory) with literal ' characters, so the script won’t be found / the directory argument will be wrong. Use double quotes (escaped as " in XML) or switch to powershell -File with properly quoted arguments instead of wrapping these in single quotes.

Suggested change

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(SolutionDir)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h WorkspacesLauncherResource.base.rc WorkspacesLauncherResource.rc" />

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted -File "$(SolutionDir)tools\build\convert-resx-to-rc.ps1" "$(MSBuildThisFileDirectory)" resource.base.h resource.h WorkspacesLauncherResource.base.rc WorkspacesLauncherResource.rc" />

Copilot · 2026-03-04T23:43:34Z

src/modules/Workspaces/WorkspacesSnapshotTool/WorkspacesSnapshotTool.vcxproj

  <Import Project="..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props')" />
  <Target Name="GenerateResourceFiles" BeforeTargets="PrepareForBuild">
-    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted $(SolutionDir)tools\build\convert-resx-to-rc.ps1 $(MSBuildThisFileDirectory) resource.base.h resource.h WorkspacesSnapshotToolResources.base.rc WorkspacesSnapshotToolResources.rc" />
+    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(SolutionDir)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h WorkspacesSnapshotToolResources.base.rc WorkspacesSnapshotToolResources.rc" />


Exec runs through cmd.exe, where single quotes are not treated as quoting characters. This means PowerShell receives the script path and $(MSBuildThisFileDirectory) with literal ' characters, so the script won’t be found / the directory argument will be wrong. Use double quotes (escaped as " in XML) or switch to powershell -File with properly quoted arguments instead of wrapping these in single quotes.

Suggested change

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(SolutionDir)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h WorkspacesSnapshotToolResources.base.rc WorkspacesSnapshotToolResources.rc" />

<Exec Command="powershell -NonInteractive -ExecutionPolicy Unrestricted -File "$(SolutionDir)tools\build\convert-resx-to-rc.ps1" "$(MSBuildThisFileDirectory)" resource.base.h resource.h WorkspacesSnapshotToolResources.base.rc WorkspacesSnapshotToolResources.rc" />

Copilot · 2026-03-04T23:43:34Z

src/modules/powerrename/dll/PowerRenameExt.vcxproj

  <Import Project="$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props')" />
  <Target Name="GenerateResourceFiles" BeforeTargets="PrepareForBuild">
-    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted $(RepoRoot)tools\build\convert-resx-to-rc.ps1 $(MSBuildThisFileDirectory) resource.base.h resource.h PowerRenameExt.base.rc PowerRenameExt.rc" />
+    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h PowerRenameExt.base.rc PowerRenameExt.rc" />


Exec runs through cmd.exe, where single quotes are not treated as quoting characters. This means PowerShell receives the script path and $(MSBuildThisFileDirectory) with literal ' characters, so the script won’t be found / the directory argument will be wrong. Use double quotes (escaped as " in XML) or switch to powershell -File with properly quoted arguments instead of wrapping these in single quotes.

Suggested change

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h PowerRenameExt.base.rc PowerRenameExt.rc" />

<Exec Command="powershell -NonInteractive -ExecutionPolicy Unrestricted -File "$(RepoRoot)tools\build\convert-resx-to-rc.ps1" "$(MSBuildThisFileDirectory)" resource.base.h resource.h PowerRenameExt.base.rc PowerRenameExt.rc" />

Copilot · 2026-03-04T23:43:34Z

src/Update/PowerToys.Update.vcxproj

  <Import Project="$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props')" />
  <Target Name="GenerateResourceFiles" BeforeTargets="PrepareForBuild">
-    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted $(RepoRoot)tools\build\convert-resx-to-rc.ps1 $(MSBuildThisFileDirectory) resource.base.h resource.h PowerToys.Update.base.rc PowerToys.Update.rc" />
+    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h PowerToys.Update.base.rc PowerToys.Update.rc" />


Exec runs through cmd.exe, where single quotes are not treated as quoting characters. This means PowerShell receives the script path and $(MSBuildThisFileDirectory) with literal ' characters, so the script won’t be found / the directory argument will be wrong. Use double quotes (escaped as " in XML) or switch to powershell -File with properly quoted arguments instead of wrapping these in single quotes.

Suggested change

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h PowerToys.Update.base.rc PowerToys.Update.rc" />

<Exec Command="powershell -NonInteractive -ExecutionPolicy Unrestricted -File "$(RepoRoot)tools\build\convert-resx-to-rc.ps1" "$(MSBuildThisFileDirectory)" resource.base.h resource.h PowerToys.Update.base.rc PowerToys.Update.rc" />

Copilot · 2026-03-04T23:43:34Z

...entVariables/EnvironmentVariablesModuleInterface/EnvironmentVariablesModuleInterface.vcxproj

  <Import Project="$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props')" />
  <Target Name="GenerateResourceFiles" BeforeTargets="PrepareForBuild">
-    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted $(RepoRoot)tools\build\convert-resx-to-rc.ps1 $(MSBuildThisFileDirectory) resource.base.h resource.h EnvironmentVariablesModuleInterface.base.rc EnvironmentVariablesModuleInterface.rc" />
+    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h EnvironmentVariablesModuleInterface.base.rc EnvironmentVariablesModuleInterface.rc" />


Exec runs through cmd.exe, where single quotes are not treated as quoting characters. This means PowerShell receives the script path and $(MSBuildThisFileDirectory) with literal ' characters, so the script won’t be found / the directory argument will be wrong. Use double quotes (escaped as " in XML) or switch to powershell -File with properly quoted arguments instead of wrapping these in single quotes.

Suggested change

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h EnvironmentVariablesModuleInterface.base.rc EnvironmentVariablesModuleInterface.rc" />

<Exec Command="powershell -NonInteractive -ExecutionPolicy Unrestricted -File "$(RepoRoot)tools\build\convert-resx-to-rc.ps1" "$(MSBuildThisFileDirectory)" resource.base.h resource.h EnvironmentVariablesModuleInterface.base.rc EnvironmentVariablesModuleInterface.rc" />

Copilot · 2026-03-04T23:43:40Z

src/modules/AdvancedPaste/AdvancedPasteModuleInterface/AdvancedPasteModuleInterface.vcxproj

  <Import Project="$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props')" />
  <Target Name="GenerateResourceFiles" BeforeTargets="PrepareForBuild">
-    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted ..\..\..\..\tools\build\convert-resx-to-rc.ps1 $(MSBuildThisFileDirectory) resource.base.h resource.h AdvancedPaste.base.rc AdvancedPaste.rc" />
+    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '..\..\..\..\tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h AdvancedPaste.base.rc AdvancedPaste.rc" />


Exec runs through cmd.exe, where single quotes are not treated as quoting characters. This means PowerShell receives the script path and $(MSBuildThisFileDirectory) with literal ' characters, so the script won’t be found / the directory argument will be wrong. Use double quotes (escaped as " in XML) or switch to powershell -File with properly quoted arguments instead of wrapping these in single quotes.

Suggested change

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '..\..\..\..\tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h AdvancedPaste.base.rc AdvancedPaste.rc" />

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted -File "..\..\..\..\tools\build\convert-resx-to-rc.ps1" "$(MSBuildThisFileDirectory)" resource.base.h resource.h AdvancedPaste.base.rc AdvancedPaste.rc" />

Copilot · 2026-03-04T23:43:40Z

src/modules/NewPlus/NewShellExtensionContextMenu.win10/NewPlus.ShellExtension.win10.vcxproj

  <Import Project="$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props')" />
  <Target Name="GenerateResourceFiles" BeforeTargets="PrepareForBuild">
-    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted $(RepoRoot)tools\build\convert-resx-to-rc.ps1 $(MSBuildThisFileDirectory) resource.base.h resource.h new.base.rc new.rc" />
+    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h new.base.rc new.rc" />


Exec runs through cmd.exe, where single quotes are not treated as quoting characters. This means PowerShell receives the script path and $(MSBuildThisFileDirectory) with literal ' characters, so the script won’t be found / the directory argument will be wrong. Use double quotes (escaped as " in XML) or switch to powershell -File with properly quoted arguments instead of wrapping these in single quotes.

Suggested change

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h new.base.rc new.rc" />

<Exec Command="powershell -NonInteractive -ExecutionPolicy Unrestricted -File "$(RepoRoot)tools\build\convert-resx-to-rc.ps1" "$(MSBuildThisFileDirectory)" resource.base.h resource.h new.base.rc new.rc" />

Copilot · 2026-03-04T23:43:40Z

src/modules/PowerOCR/PowerOCRModuleInterface/PowerOCRModuleInterface.vcxproj

  <Import Project="$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props')" />
  <Target Name="GenerateResourceFiles" BeforeTargets="PrepareForBuild">
-    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted $(RepoRoot)tools\build\convert-resx-to-rc.ps1 $(MSBuildThisFileDirectory) resource.base.h resource.h PowerOCR.base.rc PowerOCR.rc" />
+    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h PowerOCR.base.rc PowerOCR.rc" />


Exec runs through cmd.exe, where single quotes are not treated as quoting characters. This means PowerShell receives the script path and $(MSBuildThisFileDirectory) with literal ' characters, so the script won’t be found / the directory argument will be wrong. Use double quotes (escaped as " in XML) or switch to powershell -File with properly quoted arguments instead of wrapping these in single quotes.

Suggested change

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h PowerOCR.base.rc PowerOCR.rc" />

<Exec Command="powershell -NonInteractive -ExecutionPolicy Bypass -File "$(RepoRoot)tools\build\convert-resx-to-rc.ps1" "$(MSBuildThisFileDirectory)" resource.base.h resource.h PowerOCR.base.rc PowerOCR.rc" />

Copilot · 2026-03-04T23:43:40Z

src/modules/ShortcutGuide/ShortcutGuide/ShortcutGuide.vcxproj

  <Import Project="$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props')" />
  <Target Name="GenerateResourceFiles" BeforeTargets="PrepareForBuild">
-    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted $(RepoRoot)tools\build\convert-resx-to-rc.ps1 $(MSBuildThisFileDirectory) resource.base.h resource.h ShortcutGuide.base.rc ShortcutGuide.rc" />
+    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h ShortcutGuide.base.rc ShortcutGuide.rc" />


Exec runs through cmd.exe, where single quotes are not treated as quoting characters. This means PowerShell receives the script path and $(MSBuildThisFileDirectory) with literal ' characters, so the script won’t be found / the directory argument will be wrong. Use double quotes (escaped as " in XML) or switch to powershell -File with properly quoted arguments instead of wrapping these in single quotes.

Suggested change

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h ShortcutGuide.base.rc ShortcutGuide.rc" />

<Exec Command="powershell -NonInteractive -ExecutionPolicy Unrestricted -File "$(RepoRoot)tools\build\convert-resx-to-rc.ps1" "$(MSBuildThisFileDirectory)" resource.base.h resource.h ShortcutGuide.base.rc ShortcutGuide.rc" />

Copilot · 2026-03-04T23:43:41Z

src/modules/launcher/Microsoft.Launcher/Microsoft.Launcher.vcxproj

  <Import Project="$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('$(RepoRoot)packages\Microsoft.Windows.CppWinRT.2.0.250303.1\build\native\Microsoft.Windows.CppWinRT.props')" />
  <Target Name="GenerateResourceFiles" BeforeTargets="PrepareForBuild">
-    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted $(RepoRoot)tools\build\convert-resx-to-rc.ps1 $(MSBuildThisFileDirectory) resource.base.h resource.h Microsoft.Launcher.base.rc Microsoft.Launcher.rc" />
+    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h Microsoft.Launcher.base.rc Microsoft.Launcher.rc" />


Exec runs through cmd.exe, where single quotes are not treated as quoting characters. This means PowerShell receives the script path and $(MSBuildThisFileDirectory) with literal ' characters, so the script won’t be found / the directory argument will be wrong. Use double quotes (escaped as " in XML) or switch to powershell -File with properly quoted arguments instead of wrapping these in single quotes.

Suggested change

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(RepoRoot)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h Microsoft.Launcher.base.rc Microsoft.Launcher.rc" />

<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted "$(RepoRoot)tools\build\convert-resx-to-rc.ps1" "$(MSBuildThisFileDirectory)" resource.base.h resource.h Microsoft.Launcher.base.rc Microsoft.Launcher.rc" />

Copilot

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.

src/runner/runner.vcxproj

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

…ting Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

Copilot AI review requested due to automatic review settings March 4, 2026 23:35

Copilot started reviewing on behalf of snickler March 4, 2026 23:36 View session

snickler changed the title ~~Fix GenerateResourceFiles task: add path quoting to handle spaces in convert-resx-to-rc.ps1 invocation~~ [Dev] Fix GenerateResourceFiles task: add path quoting to handle spaces in convert-resx-to-rc.ps1 invocation Mar 4, 2026

snickler enabled auto-merge (squash) March 4, 2026 23:37

Copilot AI reviewed Mar 4, 2026

View reviewed changes

snickler force-pushed the dev/snickler/fix-resw-script branch 2 times, most recently from c5db0a2 to 97919d7 Compare March 5, 2026 00:02

snickler requested a review from Copilot March 5, 2026 00:04

Copilot started reviewing on behalf of snickler March 5, 2026 00:05 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

src/runner/runner.vcxproj Outdated Show resolved Hide resolved

snickler marked this pull request as draft March 5, 2026 00:42

auto-merge was automatically disabled March 5, 2026 00:42
Pull request was converted to draft

snickler added 18 commits March 4, 2026 19:47

[Runner] Fix GenerateResourceFiles task to add path quoting

0347ea3

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[ActionRunner] Fix GenerateResourceFiles task to add path quoting

feff804

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[Update] Fix GenerateResourceFiles task to add path quoting

464d002

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[FileLocksmith] Fix GenerateResourceFiles task to add path quoting

5bb0366

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[FancyZones] Fix GenerateResourceFiles task to add path quoting

d9725f9

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[KeyboardManager] Fix GenerateResourceFiles task to add path quoting

5e8afb3

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[ImageResizer] Fix GenerateResourceFiles task to add path quoting

692349f

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[ShortcutGuide] Fix GenerateResourceFiles task to add path quoting

30baff0

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[ColorPicker] Fix GenerateResourceFiles task to add path quoting

1f0758a

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[Hosts] Fix GenerateResourceFiles task to add path quoting

0f653ea

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[NewPlus] Fix GenerateResourceFiles task to add path quoting

46f32e6

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[PreviewPane] Fix GenerateResourceFiles task to add path quoting

85219e0

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[PowerRename] Fix GenerateResourceFiles task to add path quoting

977d74a

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[PowerOCR] Fix GenerateResourceFiles task to add path quoting

7037f3e

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[AlwaysOnTop] Fix GenerateResourceFiles task to add path quoting

19185b5

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[AdvancedPaste] Fix GenerateResourceFiles task to add path quoting

b560c20

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[EnvironmentVariables] Fix GenerateResourceFiles task to add path quo…

e5d6195

…ting Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

[Launcher] Fix GenerateResourceFiles task to add path quoting

0296370

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

snickler force-pushed the dev/snickler/fix-resw-script branch from 97919d7 to a82013e Compare March 5, 2026 00:50

[Workspaces] Fix GenerateResourceFiles task to add path quoting

987affd

Add single quotes around script path and directory parameters to handle paths with spaces in convert-resx-to-rc.ps1 invocation.

snickler force-pushed the dev/snickler/fix-resw-script branch from a82013e to 987affd Compare March 5, 2026 00:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dev] Fix GenerateResourceFiles task: add path quoting to handle spaces in convert-resx-to-rc.ps1 invocation#45927

[Dev] Fix GenerateResourceFiles task: add path quoting to handle spaces in convert-resx-to-rc.ps1 invocation#45927
snickler wants to merge 19 commits intomainfrom
dev/snickler/fix-resw-script

snickler commented Mar 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted '$(SolutionDir)tools\build\convert-resx-to-rc.ps1' '$(MSBuildThisFileDirectory)' resource.base.h resource.h WorkspacesLauncherResource.base.rc WorkspacesLauncherResource.rc" />
	<Exec Command="powershell -NonInteractive -executionpolicy Unrestricted -File "$(SolutionDir)tools\build\convert-resx-to-rc.ps1" "$(MSBuildThisFileDirectory)" resource.base.h resource.h WorkspacesLauncherResource.base.rc WorkspacesLauncherResource.rc" />

Conversation

snickler commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

snickler commented Mar 4, 2026 •

edited

Loading