Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@
<ItemsRepeater
x:Name="ProvidersRepeater"
x:Load="{x:Bind viewModel.Extensions.HasResults, Mode=OneWay}"
GettingFocus="ProvidersRepeater_GettingFocus"
ItemsSource="{x:Bind viewModel.Extensions.FilteredProviders, Mode=OneWay}"
Layout="{StaticResource VerticalStackLayout}">
<ItemsRepeater.ItemTemplate>
Expand All @@ -224,6 +225,7 @@
Click="SettingsCard_Click"
DataContext="{x:Bind}"
Description="{x:Bind ExtensionSubtext, Mode=OneWay}"
GotFocus="SettingsCard_GotFocus"
Header="{x:Bind DisplayName, Mode=OneWay}"
IsClickEnabled="True">
<controls:SettingsCard.HeaderIcon>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ public sealed partial class ExtensionsPage : Page
private readonly TaskScheduler _mainTaskScheduler = TaskScheduler.FromCurrentSynchronizationContext();

private readonly SettingsViewModel? viewModel;
private int _lastFocusedIndex;

public ExtensionsPage()
{
Expand Down Expand Up @@ -58,4 +59,81 @@ private async void MenuFlyoutItem_OnClick(object sender, RoutedEventArgs e)
Logger.LogError("Error when showing FallbackRankerDialog", ex);
}
}

private void SettingsCard_GotFocus(object sender, RoutedEventArgs e)
{
// Track focus whenever any part of the card gets focus (including children like ToggleSwitch)
if (sender is SettingsCard card && viewModel is not null)
{
var dataContext = card.DataContext as ProviderSettingsViewModel;
if (dataContext is not null)
{
var filteredProviders = viewModel.Extensions.FilteredProviders;
var index = filteredProviders.IndexOf(dataContext);
if (index >= 0)
{
_lastFocusedIndex = index;
}
}
}
}

private void ProvidersRepeater_GettingFocus(UIElement sender, GettingFocusEventArgs args)
{
if (viewModel is null || ProvidersRepeater is null)
{
return;
}

// Only intervene when focus is coming into the ItemsRepeater from outside
if (args.OldFocusedElement != null && IsElementInsideRepeater(args.OldFocusedElement))
{
return;
}

var filteredProviders = viewModel.Extensions.FilteredProviders;

if (filteredProviders.Count == 0)
{
return;
}

// Get the last focused index, defaulting to 0
var index = _lastFocusedIndex;
if (index < 0 || index >= filteredProviders.Count)
{
index = 0;
}

// Try to get the card at the saved index
var targetCard = ProvidersRepeater.TryGetElement(index) as SettingsCard;

if (targetCard != null)
{
// Use TrySetNewFocusedElement instead of canceling and deferring
args.TrySetNewFocusedElement(targetCard);
args.Handled = true;
}
}

private bool IsElementInsideRepeater(object element)
{
if (element is not DependencyObject depObj)
{
return false;
}

var parent = depObj;
while (parent != null)
{
if (ReferenceEquals(parent, ProvidersRepeater))
{
return true;
}

parent = Microsoft.UI.Xaml.Media.VisualTreeHelper.GetParent(parent);
}

return false;
}
}