Fix typo & bugs#2438
Merged
xiaoyu-work merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bug in OlivePackageConfig.get_pass_module_config when a dotted pass path is provided, and corrects a typo in the default olive_config.json so supported_algorithms is properly populated for IncQuantization.
Changes:
- Fix
get_pass_module_configto correctly parse dotted pass types viarsplit(".", 1). - Correct
supported_algrithmstosupported_algorithmsforIncQuantizationinolive_config.json. - Add unit tests covering dotted-path lookup and
IncQuantization.supported_algorithms.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/test_package_config.py |
Adds tests to validate dotted pass type lookup and correct supported_algorithms loading. |
olive/package_config.py |
Fixes dotted-path handling in get_pass_module_config by using rsplit(".", 1). |
olive/olive_config.json |
Fixes a misspelled key so supported_algorithms is read correctly for IncQuantization. |
jambayk
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix typo & bugs
Checklist before requesting a review
lintrunner -a(Optional) Issue link