Skip to content

Fix typo & bugs#2438

Merged
xiaoyu-work merged 1 commit intomainfrom
xiaoyu/bug
Apr 29, 2026
Merged

Fix typo & bugs#2438
xiaoyu-work merged 1 commit intomainfrom
xiaoyu/bug

Conversation

@xiaoyu-work
Copy link
Copy Markdown
Collaborator

Describe your changes

Fix typo & bugs

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

Copilot AI review requested due to automatic review settings April 28, 2026 18:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a bug in OlivePackageConfig.get_pass_module_config when a dotted pass path is provided, and corrects a typo in the default olive_config.json so supported_algorithms is properly populated for IncQuantization.

Changes:

  • Fix get_pass_module_config to correctly parse dotted pass types via rsplit(".", 1).
  • Correct supported_algrithms to supported_algorithms for IncQuantization in olive_config.json.
  • Add unit tests covering dotted-path lookup and IncQuantization.supported_algorithms.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/test_package_config.py Adds tests to validate dotted pass type lookup and correct supported_algorithms loading.
olive/package_config.py Fixes dotted-path handling in get_pass_module_config by using rsplit(".", 1).
olive/olive_config.json Fixes a misspelled key so supported_algorithms is read correctly for IncQuantization.

@xiaoyu-work xiaoyu-work merged commit a7a70dc into main Apr 29, 2026
15 checks passed
@xiaoyu-work xiaoyu-work deleted the xiaoyu/bug branch April 29, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants