Version needs to be set to actual version and not just keyword _latest_#2437
Merged
Version needs to be set to actual version and not just keyword _latest_#2437
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Sphinx documentation configuration so the displayed docs version is a concrete value rather than the placeholder "latest", aligning with the docs versioning approach used by the version switcher.
Changes:
- Set
versionindocs/source/conf.pyfrom"latest"to"0.12.1".
Comment on lines
+22
to
23
| version = "0.12.1" | ||
| release = version |
There was a problem hiding this comment.
version is used as the pydata-sphinx-theme version switcher version_match (see html_theme_options['switcher']['version_match']). On main, this should match the versions.json entry for the root docs (currently "main"), not a pinned release like 0.12.1, otherwise the switcher will not select the current docs version and the site will be mislabeled.
Suggested change
| version = "0.12.1" | |
| release = version | |
| release = "0.12.1" | |
| _docs_version = os.environ.get("READTHEDOCS_VERSION") or os.environ.get("GITHUB_REF_NAME") | |
| version = "main" if _docs_version == "latest" else (_docs_version or release) |
xiaoyu-work
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version needs to be set to actual version and not just keyword latest
Checklist before requesting a review
lintrunner -a(Optional) Issue link