-
Notifications
You must be signed in to change notification settings - Fork 307
[JS & Python] Add cancellation and structured error handling to live audio streaming #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rui-ren
wants to merge
11
commits into
main
Choose a base branch
from
ruiren/js-sdk-live-audio-cancellation-and-coreerror
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0da8ab7
Add CoreError and AbortSignal support to JS live audio streaming
rui-ren 21194a3
Fix abort listener leaks and native handle leak in live audio session
rui-ren 1d340ab
Address PR review feedback
rui-ren 83e8dc4
Demonstrate CoreError and AbortSignal in live-audio sample
rui-ren 2cf7df8
Address PR review round 2
rui-ren df4260c
Add session-level cancellation in JS + cancellation in Python
rui-ren eee2cbe
Drop per-call cancel parameter on start/append/stop/get_transcription…
rui-ren 42b40e5
Merge remote-tracking branch 'origin/main' into ruiren/js-sdk-live-au…
rui-ren 6ab38c4
Drop LiveAudioTranscriptionSessionOptions; pass signal directly
rui-ren 143a8b6
Demonstrate cancel_event in Python live-audio sample
rui-ren d5683c3
Document the cancellation poll interval constant
rui-ren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of creating a new class to represent the parameters passed into the session, can we instead make an optional parameter for
signalincreateLiveTranscriptionSession? Then, we can remove the need for theLiveAudioTranscriptionSessionOptionsclass. The new optional parameter forsignalcan behave similar to aCancellationTokenparameter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I will update the
cancellationpattern. ThanksThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 6ab38c4. Dropped
LiveAudioTranscriptionSessionOptionsand madesignala plain optional parameter oncreateLiveTranscriptionSession, matching C#'sCancellationTokenshape:(was
createLiveTranscriptionSession({ signal: shutdown.signal }))JS 19/19 tests pass; sample updated.