Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Enables the C++ SDK to build beyond Windows by removing Windows-only dependencies and introducing cross-platform shared-library loading for the Core interop layer.
Changes:
- Remove WIL from the C++ SDK’s vcpkg/CMake dependencies and replace WIL-based module path resolution.
- Implement cross-platform dynamic library loading (
LoadLibraryW/dlopen) and symbol lookup (GetProcAddress/dlsym) in Core interop. - Update CMake presets to consistently use the vcpkg toolchain file and link
dlwhere needed on Unix-like platforms.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/cpp/vcpkg.json | Drops the Windows-only wil dependency from the vcpkg manifest. |
| sdk/cpp/src/flcore_native.h | Makes function pointer calling convention portable via a platform macro. |
| sdk/cpp/src/core.h | Reworks Core shared-library loading and executable-dir discovery for Windows/Linux/macOS. |
| sdk/cpp/CMakePresets.json | Adds vcpkg toolchainFile wiring for Windows/Linux/macOS configure presets. |
| sdk/cpp/CMakeLists.txt | Removes Windows-only build guard, removes WIL linkage, and links ${CMAKE_DL_LIBS} on Unix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tested build on Windows & Linux, cannot on MacOS as I'm currently not in a possession of one