Skip to content

Simplify OrderedClientElection by reading quorum directly #26693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChumpChief wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Simplify OrderedClientElection by reading quorum directly #26693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
31afff2
Merge OrderedClientCollection into OrderedClientElection
ChumpChief Mar 9, 2026
60d37cc
Inline initFromSerializedState in OrderedClientElection
ChumpChief Mar 9, 2026
14eab52
Restore forceSend comments on sendPerformanceEvent calls
ChumpChief Mar 9, 2026
de4005b
Restore comments from upstream/main to minimize review delta
ChumpChief Mar 9, 2026
8b4a5a3
Re-wrap election tests in original describe blocks to minimize diff
ChumpChief Mar 9, 2026
2b1cc50
Move shared test helpers to outer describe scope to match upstream st…
ChumpChief Mar 9, 2026
88bb903
Restore initialState parameter comment from upstream
ChumpChief Mar 9, 2026
dfd6402
Convert isSummarizerClient and toTrackedClient to free functions
ChumpChief Mar 9, 2026
a2ba278
Restore original telemetry properties on InitialElectedClient error e…
ChumpChief Mar 10, 2026
c354785
Rename variables in addMember handler for clarity
ChumpChief Mar 10, 2026
8218c56
Consolidate findOldestEligibleParent and peekNextElectedClient to use…
ChumpChief Mar 10, 2026
285dc72
Restore wrap-around behavior in removeMember handler
ChumpChief Mar 10, 2026
b63db21
Extract findNextEligibleParent to consolidate wrap-around logic
ChumpChief Mar 10, 2026
510665e
Fix reference equality bug in resetElectedClient and restore shallow …
ChumpChief Mar 10, 2026
eca08a2
Restore JSDoc comments on getters, event handlers, and find methods
ChumpChief Mar 10, 2026
c44c9d3
Allow orphaned summarizer election to match upstream behavior
ChumpChief Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/runtime/container-runtime/src/containerRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@ import {
type ISummaryConfiguration,
type ISummaryMetadataMessage,
metadataBlobName,
OrderedClientCollection,
OrderedClientElection,
recentBatchInfoBlobName,
RetriableSummaryError,
Expand Down Expand Up @@ -2260,14 +2259,10 @@ export class ContainerRuntime
logger: this.baseLogger,
namespace: "OrderedClientElection",
});
const orderedClientCollection = new OrderedClientCollection(
const orderedClientElectionForSummarizer = new OrderedClientElection(
orderedClientLogger,
this.innerDeltaManager,
this._quorum,
);
const orderedClientElectionForSummarizer = new OrderedClientElection(
orderedClientLogger,
orderedClientCollection,
this.electedSummarizerData ?? this.innerDeltaManager.lastSequenceNumber,
SummarizerClientElection.isClientEligible,
this.mc.config.getBoolean(
Expand Down
2 changes: 0 additions & 2 deletions packages/runtime/container-runtime/src/summary/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,9 @@ export {
type ISummaryBaseConfiguration,
} from "./summarizerTypes.js";
export {
type IOrderedClientCollection,
type IOrderedClientElection,
type ISerializedElection,
type ITrackedClient,
OrderedClientCollection,
OrderedClientElection,
} from "./orderedClientElection.js";
export {
Expand Down
Loading
Loading