Skip to content

chore(docs): remove redundant playwright dependency#26665

Open
alexvy86 wants to merge 1 commit intomicrosoft:mainfrom
alexvy86:remove-redundant-playwright-dep
Open

chore(docs): remove redundant playwright dependency#26665
alexvy86 wants to merge 1 commit intomicrosoft:mainfrom
alexvy86:remove-redundant-playwright-dep

Conversation

@alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Mar 6, 2026

Summary

  • Removes the playwright bare package from docs/package.json — all test files (playwright.config.ts, Homepage.spec.ts, Nav.spec.ts) import exclusively from @playwright/test, making playwright unused.
  • Updated pnpm-lock.yaml accordingly.

🤖 Generated with Claude Code

All test files import exclusively from @playwright/test. The bare
playwright package was unused.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 6, 2026 18:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the redundant playwright direct dependency from the docs workspace since the docs site’s Playwright usage is via @playwright/test, and updates the docs lockfile to match.

Changes:

  • Removed playwright from docs/package.json devDependencies.
  • Updated docs/pnpm-lock.yaml to reflect the dependency removal and resulting lock resolution changes.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
docs/package.json Drops the direct playwright devDependency while retaining @playwright/test.
docs/pnpm-lock.yaml Removes playwright from the importer’s direct deps and updates affected lock entries.
Files not reviewed (1)
  • docs/pnpm-lock.yaml: Language not supported

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  257792 links
    1822 destination URLs
    2063 URLs ignored
       0 warnings
       0 errors


@alexvy86 alexvy86 requested review from Josmithr and WayneFerrao March 6, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants