Remove mocha exit flag

TODO/tasks.md

@@ -0,0 +1,33 @@
+## Completed
+
+[x] Fix property-dds tests hanging: added opProcessingController.reset() and objProvider.reset()
+    in afterEach hooks to dispose containers (clears GC sessionExpiryTimer).
+    Root cause: deltaConnectionServer.close() alone doesn't dispose containers.
+
+[x] Remove --exit from local-server-stress-tests: harness already properly disposes
+    containers and closes server in finally block.
+
+[x] Fix examples/data-objects/webflow - removed esm-loader-css from mocharc, changed layout.spec.ts
+    to import htmlFormatter directly (avoids CSS import chain), and fixed describeCompat/describeWithVersions
+    to call provider.reset() before driver.dispose() in cleanup hook.
+
+[x] Fix experimental/dds/tree - SummaryManager.dispose() not closing summarizer container,
+    and Summarizer.runCore() leaving dangling Promise.race() 2-minute timeout timers (root causes 8, 9)
+
+[x] Fix packages/framework/client-logger/fluid-telemetry - ApplicationInsights stopPollingInternalLogs
+
+[x] Fix packages/framework/react - already clean
+
+[x] Fix packages/service-clients/odsp-client - already clean
+
+[x] Fix packages/test/test-end-to-end-tests: two-part fix:
+    1. patch global.setTimeout in mocha-test-setup/mochaHooks.ts to unref() timers >10s
+       (handles N-1 compat timer hangs from Summarizer.runCore() Promise.race() timers)
+    2. fix compression.spec.ts describeInstallVersions block: create versionedProvider ONCE
+       in before/after hooks instead of per-test in beforeEach/afterEach (fixes socket leak)
+
+## Remaining
+
+- tools/test-tools/.mocharc.cjs: Standalone package (own pnpm-workspace.yaml, not part of main
+  monorepo). Tests appear to be trivially clean (just spawnSync) but can't verify without
+  separate install. Low priority.

examples/data-objects/inventory-app/.mocharc.cjs

@@ -8,9 +8,6 @@
 const getFluidTestMochaConfig = require("@fluid-internal/mocha-test-setup/mocharc-common");
 
 const config = getFluidTestMochaConfig(__dirname);
-// TODO: figure out why this package needs the --exit flag, tests might not be cleaning up correctly after themselves.
-// AB#7856
-config.exit = true;
 
 // Set up JSDOM before Quill is imported (Quill requires document at import time)
 config["node-option"] ??= [];

examples/data-objects/table-document/.mocharc.cjs

@@ -8,7 +8,4 @@
 const getFluidTestMochaConfig = require("@fluid-internal/mocha-test-setup/mocharc-common");
 
 const config = getFluidTestMochaConfig(__dirname);
-// TODO: figure out why this package needs the --exit flag, tests might not be cleaning up correctly after themselves
-// AB#7856
-config.exit = true;
 module.exports = config;

examples/data-objects/webflow/.mocharc.cjs

@@ -9,8 +9,4 @@ const packageDir = __dirname;
 
 const getFluidTestMochaConfig = require("@fluid-private/test-version-utils/mocharc-common");
 const config = getFluidTestMochaConfig(packageDir);
-config["node-option"].push("experimental-loader=esm-loader-css");
-// TODO: figure out why this package needs the --exit flag, tests might not be cleaning up correctly after themselves
-// AB#7856
-config.exit = true;
 module.exports = config;

examples/data-objects/webflow/src/test/layout.spec.ts

@@ -19,7 +19,10 @@ import {
 } from "@fluidframework/test-utils/internal";
 
 import { FlowDocument } from "../document/index.js";
-import { htmlFormatter } from "../index.js";
+// Import htmlFormatter directly to avoid loading webflowView.tsx which imports CSS files.
+// Using the main index.js would transitively import CSS via host/webflowView.tsx,
+// requiring --experimental-loader=esm-loader-css which prevents clean process exit in Node.js 20.
+import { htmlFormatter } from "../html/formatters.js";
 import { Layout } from "../view/layout.js";
 
 interface ISnapshotNode {

experimental/PropertyDDS/packages/property-common/.mocharc.json

@@ -2,7 +2,6 @@
 	"R": "spec",
 	"recursive": true,
 	"timeout": "180s",
-	"exit": true,
 	"full-trace": true,
 	"spec": ["test/setup.js", "test/**/*.spec.js"]
 }

experimental/PropertyDDS/packages/property-dds/.mocharc.cjs

@@ -8,5 +8,4 @@
 const getFluidTestMochaConfig = require("@fluid-internal/mocha-test-setup/mocharc-common");
 
 const config = getFluidTestMochaConfig(__dirname);
-config.exit = true;
 module.exports = config;

experimental/PropertyDDS/packages/property-dds/src/test/propertyTree.spec.ts

@@ -65,6 +65,7 @@ interface withSummarizer extends Result {
 
 describe("PropertyDDS summarizer", () => {
 	let objProvider: ITestObjectProvider;
+	let driver: LocalServerTestDriver;
 	const propertyDdsId = "PropertyTree";
 	const USERS = "users";
 	const getClient = async (withSummarizer = false, load = false) => {
@@ -97,7 +98,7 @@ describe("PropertyDDS summarizer", () => {
 	};
 
 	beforeEach(async () => {
-		const driver = new LocalServerTestDriver();
+		driver = new LocalServerTestDriver();
 		const registry = [[propertyDdsId, new PropertyTreeFactory()]] as ChannelFactoryRegistry;
 
 		objProvider = new TestObjectProvider(
@@ -111,6 +112,11 @@ describe("PropertyDDS summarizer", () => {
 		);
 	});
 
+	afterEach(async () => {
+		objProvider.reset();
+		await driver.dispose();
+	});
+
 	it("Scenario 1", async function () {
 		/**
 		 * This test produces a scenario where a summarizer creates a summary with an empty remoteChanges array.
@@ -401,6 +407,11 @@ function executePerPropertyTreeType(
 			sharedPropertyTree2 = await dataObject2.getSharedObject(propertyDdsId);
 		});
 
+		afterEach(async () => {
+			opProcessingController.reset();
+			await deltaConnectionServer.close();
+		});
+
 		describe("APIs", () => {
 			it("Can create a PropertyTree", () => {
 				expect(sharedPropertyTree1).to.not.be.equal(undefined);

experimental/PropertyDDS/packages/property-dds/src/test/rebasing.spec.ts

@@ -1135,6 +1135,11 @@ describe("PropertyDDS", () => {
 			await setupContainers();
 		});
 
+		afterEach(async () => {
+			opProcessingController.reset();
+			await deltaConnectionServer.close();
+		});
+
 		rebaseTests();
 	});
 
@@ -1143,6 +1148,11 @@ describe("PropertyDDS", () => {
 			await setupContainers(false);
 		});
 
+		afterEach(async () => {
+			opProcessingController.reset();
+			await deltaConnectionServer.close();
+		});
+
 		rebaseTests();
 	});
 });

experimental/PropertyDDS/packages/property-properties/.mocharc.json

@@ -2,7 +2,6 @@
 	"R": "spec",
 	"recursive": true,
 	"timeout": "180s",
-	"exit": true,
 	"full-trace": true,
 	"spec": ["test/setup.js", "test/**/*.spec.js"]
 }

experimental/dds/tree/.mocharc.cjs

@@ -8,5 +8,4 @@
 const getFluidTestMochaConfig = require('@fluid-internal/mocha-test-setup/mocharc-common');
 
 const config = getFluidTestMochaConfig(__dirname);
-config.exit = true;
 module.exports = config;

experimental/dds/tree/src/test/utilities/TestUtilities.ts

@@ -286,9 +286,13 @@ export interface LocalServerSharedTreeTestingOptions {
 }
 
 const testObjectProviders: TestObjectProvider[] = [];
-afterEach(() => {
+afterEach(async () => {
 	for (const provider of testObjectProviders) {
-		provider.reset();
+		try {
+			provider.reset();
+		} finally {
+			await provider.driver.dispose?.();
+		}
 	}
 	testObjectProviders.length = 0;
 });
@@ -369,10 +373,14 @@ export async function setUpLocalServerTestSharedTree(
 
 	if (testObjectProvider !== undefined) {
 		provider = testObjectProvider;
-		const driver = new LocalServerTestDriver();
 		const loader = makeTestLoader(provider);
 		// Once ILoaderOptions is specificable, this should use `provider.loadTestContainer` instead.
-		container = await loader.resolve({ url: await driver.createContainerUrl(treeId), headers }, pendingLocalState);
+		// Use the provider's existing driver to get the URL rather than creating a new LocalServerTestDriver
+		// (which would create an unused LocalDeltaConnectionServer with a running DeliLambda timer).
+		container = await loader.resolve(
+			{ url: await provider.driver.createContainerUrl(treeId), headers },
+			pendingLocalState
+		);
 		await waitContainerToCatchUp(container);
 	} else {
 		const driver = new LocalServerTestDriver();

packages/dds/map/src/test/memory/.mocharc.cjs

@@ -8,7 +8,6 @@
  */
 
 module.exports = {
-	"exit": true,
 	"fgrep": ["@Benchmark", "@MemoryUsage"],
 	"node-option": ["expose-gc", "gc-global", "unhandled-rejections=strict"], // without leading "--"
 	"recursive": true,

packages/dds/matrix/src/test/memory/.mocharc.cjs

@@ -8,7 +8,6 @@
  */
 
 module.exports = {
-	"exit": true,
 	"fgrep": ["@Benchmark", "@MemoryUsage"],
 	"node-option": ["expose-gc", "gc-global", "unhandled-rejections=strict"], // without leading "--"
 	"recursive": true,

packages/dds/sequence/src/test/memory/.mocharc.cjs

@@ -8,7 +8,6 @@
  */
 
 module.exports = {
-	"exit": true,
 	"fgrep": ["@Benchmark", "@MemoryUsage"],
 	"node-option": ["expose-gc", "gc-global", "unhandled-rejections=strict"], // without leading "--"
 	"recursive": true,

packages/dds/tree/.mocharc.cjs

@@ -16,8 +16,4 @@ const config = getFluidTestMochaConfig(
 	[],
 	process.argv.includes("--emulateProduction") ? "PROD" : undefined,
 );
-// TODO: figure out why this package needs the --exit flag, tests might not be cleaning up correctly after themselves
-// In this package, tests which use `TestTreeProvider.create` cause this issue, but there might be other cases as well.
-// AB#7856
-config.exit = true;
 module.exports = config;

packages/dds/tree/src/test/feature-libraries/node-identifier/nodeIdentifier.spec.ts

@@ -30,7 +30,10 @@ async function getIIDCompressor(): Promise<IIdCompressor> {
 			runtime: IFluidDataStoreRuntime;
 		}
 	).runtime;
-	return runtime.idCompressor ?? fail("Expected IIdCompressor to be present in runtime");
+	const compressor =
+		runtime.idCompressor ?? fail("Expected IIdCompressor to be present in runtime");
+	await provider.dispose();
+	return compressor;
 }
 
 describe("Node Identifier", () => {