Skip to content

Improve applySerializedChange to support cross-session usage and transactions #26662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noencke wants to merge 4 commits into
base: main
Choose a base branch
from

assert root revision

b82ee62
Select commit
Loading
Failed to load commit list.
Open

Improve applySerializedChange to support cross-session usage and transactions #26662

assert root revision
b82ee62
Select commit
Loading
Failed to load commit list.
Azure Pipelines / Build - client packages failed Mar 10, 2026 in 46m 25s

Build #383345 had test failures

8 errors / 9 warnings

Details

Tests

  • Failed: 13 (0.03%)
  • Passed: 37,968 (93.00%)
  • Other: 2,843 (6.96%)
  • Total: 40,824
Code coverage

  • 262028 of 326396 line covered (80.28%)

Annotations

Check failure on line 16 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

Build log #L16 

1ES PT Non-Blocking Error: The artifact linux-1es-gpt-prerequisites is deprecated. Please update the artifact to linux-1es-pt-prerequisites-v2. For more information visit https://aka.ms/1espt/v1-prerequisite-deprecation-linux . Small-eastus2/agent-image-ubuntu-22.04_2026-02-20.15-30-22

Check failure on line 16 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

Build log #L16 

1ES PT Non-Blocking Error: The artifact linux-1es-gpt-prerequisites is deprecated. Please update the artifact to linux-1es-pt-prerequisites-v2. For more information visit https://aka.ms/1espt/v1-prerequisite-deprecation-linux . Large-eastus2/agent-image-ubuntu-22.04_2026-02-20.15-30-22

Check failure on line 16 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

Build log #L16 

1ES PT Non-Blocking Error: The artifact linux-1es-gpt-prerequisites is deprecated. Please update the artifact to linux-1es-pt-prerequisites-v2. For more information visit https://aka.ms/1espt/v1-prerequisite-deprecation-linux . Large-eastus2/agent-image-ubuntu-22.04_2026-02-20.15-30-22

Check failure on line 16 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

Build log #L16 

1ES PT Non-Blocking Error: The artifact linux-1es-gpt-prerequisites is deprecated. Please update the artifact to linux-1es-pt-prerequisites-v2. For more information visit https://aka.ms/1espt/v1-prerequisite-deprecation-linux . Large-eastus2/agent-image-ubuntu-22.04_2026-02-20.15-30-22

Check failure on line 1 in can be applied to a different branch

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

can be applied to a different branch 

Test failed
Raw output 
Malformed serialized change, revision should be "root"
Error: Malformed serialized change, revision should be "root"
    at failPrivate (file:///mnt/vss/_work/1/s/FluidFramework/packages/common/core-utils/src/assert.ts:56:16)
    at assert (file:///mnt/vss/_work/1/s/FluidFramework/packages/common/core-utils/src/assert.ts:39:3)
    at TreeCheckout.applySerializedChange (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/shared-tree/treeCheckout.ts:788:3)
    at _classThis.applyChange (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/shared-tree/schematizingTreeView.ts:174:17)
    at file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:144:18
    at Breakable.run (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:87:11)
    at _classThis.replacementMethod (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:143:23)
    at Context.<anonymous> (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/test/simple-tree/api/tree.spec.ts:308:10)
    at processImmediate (node:internal/timers:483:21)

Check failure on line 1 in can be applied to a view with a different session

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

can be applied to a view with a different session 

Test failed
Raw output 
Malformed serialized change, revision should be "root"
Error: Malformed serialized change, revision should be "root"
    at failPrivate (file:///mnt/vss/_work/1/s/FluidFramework/packages/common/core-utils/src/assert.ts:56:16)
    at assert (file:///mnt/vss/_work/1/s/FluidFramework/packages/common/core-utils/src/assert.ts:39:3)
    at TreeCheckout.applySerializedChange (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/shared-tree/treeCheckout.ts:788:3)
    at _classThis.applyChange (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/shared-tree/schematizingTreeView.ts:174:17)
    at file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:144:18
    at Breakable.run (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:87:11)
    at _classThis.replacementMethod (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:143:23)
    at Context.<anonymous> (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/test/simple-tree/api/tree.spec.ts:327:10)
    at processImmediate (node:internal/timers:483:21)

Check failure on line 1 in can be undone

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

can be undone 

Test failed
Raw output 
Malformed serialized change, revision should be "root"
Error: Malformed serialized change, revision should be "root"
    at failPrivate (file:///mnt/vss/_work/1/s/FluidFramework/packages/common/core-utils/src/assert.ts:56:16)
    at assert (file:///mnt/vss/_work/1/s/FluidFramework/packages/common/core-utils/src/assert.ts:39:3)
    at TreeCheckout.applySerializedChange (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/shared-tree/treeCheckout.ts:788:3)
    at _classThis.applyChange (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/shared-tree/schematizingTreeView.ts:174:17)
    at file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:144:18
    at Breakable.run (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:87:11)
    at _classThis.replacementMethod (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:143:23)
    at Context.<anonymous> (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/test/simple-tree/api/tree.spec.ts:359:10)
    at processImmediate (node:internal/timers:483:21)

Check failure on line 1 in can apply alongside a transaction

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

can apply alongside a transaction 

Test failed
Raw output 
Malformed serialized change, revision should be "root"
Error: Malformed serialized change, revision should be "root"
    at failPrivate (file:///mnt/vss/_work/1/s/FluidFramework/packages/common/core-utils/src/assert.ts:56:16)
    at assert (file:///mnt/vss/_work/1/s/FluidFramework/packages/common/core-utils/src/assert.ts:39:3)
    at TreeCheckout.applySerializedChange (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/shared-tree/treeCheckout.ts:788:3)
    at _classThis.applyChange (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/shared-tree/schematizingTreeView.ts:174:17)
    at file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:144:18
    at Breakable.run (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:87:11)
    at _classThis.replacementMethod (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:143:23)
    at file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/test/simple-tree/api/tree.spec.ts:380:11
    at _classThis.runTransaction (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/shared-tree/schematizingTreeView.ts:301:37)
    at file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:144:18
    at Breakable.run (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:87:11)
    at _classThis.replacementMethod (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/util/breakable.ts:143:23)
    at Context.<anonymous> (file:///mnt/vss/_work/1/s/FluidFramework/packages/dds/tree/src/test/simple-tree/api/tree.spec.ts:378:10)
    at processImmediate (node:internal/timers:483:21)
View more details on Azure Pipelines