Skip to content

Remove DacFx bits from SDK package, use package reference instead #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zijchen wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove DacFx bits from SDK package, use package reference instead #407

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2aeced
Remove DLLs from nupkg
zijchen Feb 10, 2024
f0833d1
Merge branch 'main' of https://github.com/microsoft/DacFx into zijche…
zijchen Feb 12, 2024
629804f
Add copy task
zijchen Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.Build.Sql/Microsoft.Build.Sql.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<PackageReference Include="System.IO.Packaging" Version="5.0.0" GeneratePathProperty="true" />
</ItemGroup>

<Target Name="CopyBuildBinaries" BeforeTargets="Build">
<!-- <Target Name="CopyBuildBinaries" BeforeTargets="Build">
<Message Text="Using DacFx version '$(DacFxPackageVersion)'" Importance="high" />
<ItemGroup>
<PackageFiles Include="$(PkgMicrosoft_SqlServer_DacFx)\lib\netstandard2.1\*.dll" />
Expand All @@ -34,7 +34,7 @@
<PackageFiles Include="$(PkgSystem_IO_Packaging)\lib\netstandard2.0\System.IO.Packaging.dll" />
</ItemGroup>
<Copy SourceFiles="@(PackageFiles)" DestinationFolder="$(BuildBinariesPath)" />
</Target>
</Target> -->

<Target Name="DeleteToolsFolder" AfterTargets="Clean">
<RemoveDir Directories="$(MSBuildThisFileDirectory)\tools" />
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Build.Sql/Microsoft.Build.Sql.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
</metadata>
<files>
<file src="sdk\**" target="sdk" />
<file src="tools\**" target="tools" />
<!-- <file src="tools\**" target="tools" /> -->
<file src="..\..\LICENSE.txt" target="LICENSE.txt" />
<file src="..\..\images\nuspecicon.png" target="images\nuspecicon.png" />
</files>
Expand Down
Loading