fix: CLI capabilities parsing and Go relay SQLite read/write race#44
Merged
fix: CLI capabilities parsing and Go relay SQLite read/write race#44
Conversation
Two fixes: 1. CLI: RelayInfo struct now correctly reads capabilities from the nested `capabilities` object in the well-known response instead of expecting top-level `proof`/`content` fields (which always deserialized as false). 2. Go relay: HTTP read handlers (routes, auth) now use a read-only SQLiteStore view that always reads from the WAL read connection pool, never from an active write transaction. Previously, concurrent HTTP reads could grab the ingestion transaction via readerDB(), then fail with "transaction has already been committed" when ingestion committed the batch mid-query. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RelayInfostruct now correctly parses the nestedcapabilitiesobject from the relay well-known response. Previouslyproofandcontentfields deserialized asfalsebecause the struct expected them at the top level, not undercapabilities.SQLiteStoreview that always reads from the WAL read connection pool. Previously,readerDB()could return an active write transaction to concurrent HTTP handlers, which would fail with "transaction has already been committed" when ingestion committed the batch mid-query. The ingestion path still sees the write transaction for within-batch read consistency.Test plan
relay infoandrelay listshow correctcontent: yes/proof: yesGenerated with Claude Code