Resolves bug #15560 - evaluate qt dependencies without qt framework#15623
Open
boulette42 wants to merge 1 commit intomesonbuild:masterfrom
Open
Resolves bug #15560 - evaluate qt dependencies without qt framework#15623boulette42 wants to merge 1 commit intomesonbuild:masterfrom
boulette42 wants to merge 1 commit intomesonbuild:masterfrom
Conversation
Member
|
Please update the commit message to use a standard format. e.g. following the guidance at https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html In particular, "resolves #15560" should be part of "more detailed explanatory text" because it is a citation that explains "detect non-framework Qt on macOS" -- the bug reference isn't the actual one-line summary itself. Also, "resolves #xxx" is a keyword recognized by GitHub to automatically close linked tickets, but "resolves bug #xxx" is unfortunately not part of the GitHub regex, so please never use the latter. |
If qt5 was built from source with parameter '-no-framework', meson did not find the Qt-libraries. Now instead of changing an internal flag, the return code of the probing function is used to determine the existence of the qt framework. The internal flag has to keep its value. This resolves mesonbuild#15560
Contributor
Author
|
Thank you for your advice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If qt5 is built from source with parameter '-no-framework', meson did not find the Qt-libraries. Instead of changing an internal flag, the return code of the probing function is now used to determine the existence of the qt framework. The internal flag has to keep its value.