Fixes to run_project_tests XML log#15620
Open
jon-turney wants to merge 3 commits intomesonbuild:masterfrom
Open
Fixes to run_project_tests XML log#15620jon-turney wants to merge 3 commits intomesonbuild:masterfrom
jon-turney wants to merge 3 commits intomesonbuild:masterfrom
Conversation
Annotate each testcase with the time to run the test, not the total elapsed time. This is wrong by my reading of the JUnit XML schema, and doesn't seem very useful. It looks like this has been wrong since forever.
Unfortunately, the idiot who wrote bee4dc9 (me!) assumed that the 'test category' (the 'testsuite' name) is the same as the directory. (That is, that TestCategory.category == TestCategory.subdir). These are not the same (e.g. 'failing-test' vs 'failing test' etc.) which is why they are separate things. Rather than adding yet another function argument to pass yet another attribute of the TestCategory object around, just pass the object itself.
At the moment, all testcases are children of the last testsuite listed. It seems like this was something I failed to notice in bee4dc9, which only fixed the classname in the testcase node, not it's parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a couple of issues I noticed with the
meson-test-run.xmlfile produced byrun_project_tests.testcasenode'stimeattribute is the total elapsed time, rather than the time it took to run that test.testcasenodes are children of thetestsuitenode created for the last testsuite listed.However, since nobody seems to have noticed these problems since the last time I looked at this piece of code in #8917, I'm not sure if this file is actually being used by anyone?
Maybe we should remove it? or in the alternative, remove the
meson-test-run.txtsince having both just seems pointless.