Clean up list of introspection commands#15535
Open
bonzini wants to merge 3 commits intomesonbuild:masterfrom
Open
Clean up list of introspection commands#15535bonzini wants to merge 3 commits intomesonbuild:masterfrom
bonzini wants to merge 3 commits intomesonbuild:masterfrom
Conversation
Pass the arguments directly to the list_* functions instead of going through a lambda, which is just what the no_bd case already does. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This is now clearer to mypy, so remove some useless checks. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
dnicolodi
reviewed
Feb 9, 2026
| no_bd: T.Optional[T.Callable[[IntrospectionInterpreter], T.Union[dict, list]]] = None | ||
|
|
||
| def __post_init__(self) -> None: | ||
| self.desc += '.' |
Member
There was a problem hiding this comment.
Isn't it easier to add the full stop to the string passed to the constructor and be done with it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trade off some unused arguments with simpler code: just make all the functions that implement introspection commands have the same signature.