[ui] Refine ending logo animation timing and convergence flow#164
Closed
Oluwatunmise-olat wants to merge 5 commits intomeshery-extensions:masterfrom
Closed
[ui] Refine ending logo animation timing and convergence flow#164Oluwatunmise-olat wants to merge 5 commits intomeshery-extensions:masterfrom
Oluwatunmise-olat wants to merge 5 commits intomeshery-extensions:masterfrom
Conversation
Signed-off-by: Oluwatunmise-olat <oluwatunmiseolatunbosun2001@gmail.com>
|
Signed-off-by: Oluwatunmise-olat <oluwatunmiseolatunbosun2001@gmail.com>
Bhumikagarggg
requested changes
Mar 15, 2026
Contributor
Bhumikagarggg
left a comment
There was a problem hiding this comment.
On first go it is perfect. But when I go up and come down there is still a problem.
Contributor
Author
Okay would check it out in a bit |
Signed-off-by: Oluwatunmise-olat <oluwatunmiseolatunbosun2001@gmail.com>
Signed-off-by: Oluwatunmise-olat <oluwatunmiseolatunbosun2001@gmail.com>
Signed-off-by: Oluwatunmise-olat <oluwatunmiseolatunbosun2001@gmail.com>
Contributor
Author
|
Please help with a review @yi-nuo426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Context
Issue #141 asks for refinement of the final logo animation sequence in the browser section, specifically the moment where the floating Kanvas logo pieces converge into the assembled logo.
Based on issue discussion, the rough edges were most visible when scrolling quickly.
Root Cause Areas Addressed
This PR focuses on three concrete problem areas in the current animation pipeline:
Behavior Impact
After this change, the final browser-section logo assembly should:
Validation Performed
node --check static/scripts/main.jsmake buildBoth completed successfully.
Files Updated
static/scripts/main.jsSigned commits