Skip to content

Fix: Enforce upper bounds for rxdelay, txdelay, and direct.txdelay#2443

Open
kizniche wants to merge 1 commit intomeshcore-dev:devfrom
kizniche:fix-rxdelay-txdelay
Open

Fix: Enforce upper bounds for rxdelay, txdelay, and direct.txdelay#2443
kizniche wants to merge 1 commit intomeshcore-dev:devfrom
kizniche:fix-rxdelay-txdelay

Conversation

@kizniche
Copy link
Copy Markdown

@kizniche kizniche commented Apr 29, 2026

Fixes #2433 by enforcing upper bounds for rxdelay, txdelay, and direct.txdelay, based on what is written in the CLI docs.

@kizniche kizniche changed the title Fnforce upper bounds for rxdelay, txdelay, and direct.txdelay Enforce upper bounds for rxdelay, txdelay, and direct.txdelay Apr 29, 2026
@kizniche kizniche changed the title Enforce upper bounds for rxdelay, txdelay, and direct.txdelay Fix: Enforce upper bounds for rxdelay, txdelay, and direct.txdelay Apr 29, 2026
@dreirund
Copy link
Copy Markdown
Contributor

dreirund commented Apr 30, 2026

Maybe increasing the limits can be useful? As There:
https://github.com/user-attachments/files/26126001/Proposal-.MeshCore.factors.in.selecting.rxdelay.txdelay.and.direct.txdelay.pdf (linked at #2053 (comment)) txdelay = 2.5 is also within the range of proposed settings.

Or just the documentation would need correction, whatever suits the intention?

@kizniche
Copy link
Copy Markdown
Author

Perhaps changing the defaults is warranted, but something that should be discussed in the issue, not the PR. This PR is simply aligning the code with the expected behavior (the docs).

@CullenShane
Copy link
Copy Markdown

Denver already recommends values that are higher than these limits: https://denvermc.com/guides/repeater-setup

@dreirund
Copy link
Copy Markdown
Contributor

Denver already recommends values that are higher than these limits: https://denvermc.com/guides/repeater-setup

So this PR would break existing use cases -- then I would say find the current maximum values and do a PR that aligns the docs with reality ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants