fn Rav1dPictureDataComponent::wrap_buf: make unsafe to enforce buf outlives Self#1416
Open
fn Rav1dPictureDataComponent::wrap_buf: make unsafe to enforce buf outlives Self#1416
fn Rav1dPictureDataComponent::wrap_buf: make unsafe to enforce buf outlives Self#1416Conversation
…uf` outlives `Self` Adding proper lifetimes is difficult (see #1317), so we instead make this an `unsafe` precondition, that `buf` must outlive the returned `Self`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding proper lifetimes is difficult (see #1317), so we instead make this an
unsafeprecondition, thatbufmust outlive the returnedSelf.Since all of the uses use lifetime extension to easily guarantee that
bufoutlives the returnedRav1dPictureDataComponent(with an extended lifetime), I thought I might at least be able to use a macro to do this to encapsulate theunsafe, but it didn't work with lifetime extension. I don't think there's a way. Hopefully, someone can eventually fix #1317 and do this more properly.This will also help untangle #1327.