perf: fn rav1d_create_lf_mask_{intra,inter}: store as u16s#1403
Merged
Conversation
kkysen
commented
May 20, 2025
Collaborator
Author
kkysen
left a comment
There was a problem hiding this comment.
@iximeow, @coderkalyan, if you want to review.
djc
reviewed
May 20, 2025
coderkalyan
reviewed
May 20, 2025
coderkalyan
left a comment
There was a problem hiding this comment.
Pending the open comments, LGTM.
fn rav1d_create_lf_mask_intra: store as u16sfn rav1d_create_lf_mask_{intra,inter}: store as u16s
|
Will try to take a look at this tomorrow! |
djc
reviewed
Jun 12, 2025
Previously, two adjacent 8-bit stores were done. By doing them as `u16`s instead of `[u8]`s/`[u8; 2]`s, we can get a single 16-bit store to be emitted instead.
Same as for `fn rav1d_create_lf_mask_intra`.
10da56b to
f7fd7df
Compare
…can safely treat it as `u16`s
coderkalyan
approved these changes
Jun 13, 2025
coderkalyan
left a comment
There was a problem hiding this comment.
Oops, forgot about this - but with the AlignedVec2, LGTM!
djc
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, two adjacent 8-bit stores were done. By doing them as
u16s instead of[u8]s/[u8; 2]s, we can get a single 16-bit store to be emitted instead.This gets
strhs emitted instead of the pair ofstrbs previously.Based on what @iximeow found in iximeow@e133a89 and #1401 (comment).
Before:
After: