struct {Rav1dContext,TaskThreadDataDelayedFg}: Remove TODOed unsafe impl Send + Syncs#1329
Open
kkysen wants to merge 1 commit intokkysen/Rav1dPictureDataComponentInner-ptr-Uniquefrom
Conversation
rinon
approved these changes
Jul 18, 2024
|
This PR was approved but never merged. Are there any blockers left, or is just waiting for a maintainer to push the "merge" button? |
Collaborator
Author
The PR it's merging into (#1327) isn't approved yet and has some issues we've been meaning to get to. |
Merged
kkysen
force-pushed
the
kkysen/Rav1dPictureDataComponentInner-ptr-Unique
branch
from
64390bb to
5366e5a
Compare
kkysen
force-pushed
the
kkysen/remove-TODO-unsafe-impl-Send-Sync
branch
from
61707d6 to
878cf52
Compare
…e impl Send + Sync`s.
kkysen
force-pushed
the
kkysen/Rav1dPictureDataComponentInner-ptr-Unique
branch
from
5366e5a to
4369d09
Compare
kkysen
force-pushed
the
kkysen/remove-TODO-unsafe-impl-Send-Sync
branch
from
878cf52 to
0c8a19b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unsafe impl {Send,Sync} for {Rav1dContext,TaskThreadData_delayed_fg}#1177.#![deny(clippy::undocumented_unsafe_blocks)]and#![deny(clippy::missing_safety_doc)]#1270.Ideally we now run
cargo clippyin CI, too, to ensure #1270 stays fixed, but we can do that later.