feat(e2e): Migrate RF tests to detox. Optimize CI to run faster. Run smoke test by default

[yasserfaraazkhan]

Jira:

• https://mattermost.atlassian.net/browse/SEC-9886
• https://mattermost.atlassian.net/browse/SEC-9887
• https://mattermost.atlassian.net/browse/SEC-9911
• https://mattermost.atlassian.net/browse/MM-68080

Summary

This PR has three main areas of work:

1. E2E test migration — Rainforest → Detox & Maestro

Migrates a large set of Rainforest test cycles to Detox and Maestro, covering:

• Channel bookmarks (create, edit, delete, permissions, search)
• iPad (account view, channel navigation, post message, sidebar)
• Messaging (file preview/upload, gallery, image attachment options, GIF, mark as unread, pin/unpin, emoji display, misc)
• Search (recent mentions, search behaviors)
• Threads smoke test (updated)
• Share extension (share link, text, image to channel)
• Maestro flows: channel bookmark file, multi-device messaging, timezone, help URL

2. CI optimizations

• Build cache: JS-only PRs skip native rebuilds (~15 min → ~18s); Android limited to single ABI for CI emulator
• Smoke test on every PR: messaging smoke test runs on all PRs, not just scheduled runs
• iPad Detox CI job: new scheduled job targeting iPad Pro 13-inch (M5) / iOS 26.3
• Maestro jobs: integrated into both PR and scheduled workflows

3. App-side bug fixes (found while writing/running E2E tests)

Crashes:

• scrollTo -Infinity RN bridge crash from keyboard animation (useKeyboardScrollAdjustment)
• progressViewOffset: NaN RCTRefreshControl crash + CALayer position contains NaN (3 propagation paths through post list and keyboard hook)
• OpenGraph null crash when page has no <title> tag
• Thread transformer crash when raw.post is undefined
• processReceivedThreads crash on null post/participants fields

Logic bugs:

• Saved posts race condition: unsaving a post caused the bookmark icon to snap back due to an immediate WebSocket PREFERENCE_CHANGED event; fixed with
  EphemeralStore tracking + stale event filter across post list, thread overview, post options, and saved messages
• savePreferences was fire-and-forget (errors silently swallowed)
• markThreadAsUnread showed stale unread count until WS event arrived
• Thread reply_count not updated locally on new reply; missing auto-follow when ThreadAutoFollow is enabled
• Archived posts always included in search due to Boolean('false') === true
• Users kicked from archived channels when ExperimentalViewArchivedChannels was unset (undefined treated as not-'true' → kick fired)
• Pinned messages shown in reversed order (spurious .reverse())
• Archive channel modal not dismissed in some modal stack states (dismissModal → dismissAllModals)
• Category collapse animation not cancellable on rapid taps (useDerivedValue → useSharedValue with cancelAnimation)

Also merged from main: GIF animation URL fix, SQLite concurrent access crash (iOS, 36K users), Android RNN race condition, keyboard stuck fix, pre-auth
header case-insensitive check, duplicate hashtag search, search results layout overlap.

NONE

[github-actions]

Coverage Comparison Report

Generated on April 16, 2026 at 12:15:37 UTC

+-----------------+------------+------------+-----------+
| Metric          | Main       | This PR    | Diff      |
+-----------------+------------+------------+-----------+
| Lines           |     85.17% |     85.15% |    -0.02% |
| Statements      |     85.03% |     85.03% |     0.00% |
| Branches        |     72.22% |     72.18% |    -0.04% |
| Functions       |     84.03% |     84.12% |     0.09% |
+-----------------+------------+------------+-----------+
| Total           |     81.61% |     81.62% |     0.01% |
+-----------------+------------+------------+-----------+

[coderabbitai]

📝 Walkthrough

Walkthrough

Skip traversal of ipad/ spec files during spec discovery; add iPad/Maestro E2E pipelines and many Detox device/config updates; introduce ephemeral “recently unsaved” saved-post tracking integrated into observables; add numerous test helpers, server API wrappers, CI/workflow changes, testIDs, and assorted app defensive guards.

Changes

Cohort / File(s)	Summary
Spec discovery & CI actions .github/actions/generate-specs/split-tests.js, .github/actions/prepare-node-deps/action.yaml, .github/actions/prepare-ios-build/action.yaml, .github/actions/test/action.yaml	Ignore ipad/ in Specs.findFiles(); simplify node/npm and pods caching; run lint + tsc concurrently and handle exit codes explicitly.
Workflows & templates .github/workflows/... (compatibility-matrix-testing.yml, e2e-*.yml, e2e-maestro-template.yml, e2e-android-template.yml, e2e-ios-template.yml), .github/workflows/e2e-cancel-on-label-removal.yml	Add iPad/maestro/android jobs, new inputs (search_path, parallelism, detox_config), change defaults (API 35, AVD names), propagate report metrics, add cancel-on-label-removal workflow.
Detox config, emulator & scripts detox/.detoxrc.json, detox/detox/.detoxrc.json, detox/android_emulator/config.ini, detox/create_android_emulator.sh, detox/e2e/config.js, detox/e2e/global_setup.js	Add iPad simulator entries, bump Android API to 35/Pixel8, tune emulator RAM/skins, add SDK retry logic, add Jest globalSetup to clean zombie simulators and perform server bootstrap (health/auth/config/plugins).
Detox support libs & helpers detox/e2e/support/utils/index.ts, detox/e2e/support/utils/detoxhelpers.ts, detox/CLAUDE.md, detox/README.md	Add isIpad/isIpad helper, extended timeouts, polling and long-press-retry helpers, contributor guidance and README updates.
Server API helpers for E2E detox/e2e/support/server_api/* (client.ts, post.ts, plugin.ts, channel_bookmark.ts, command.ts, custom_profile_attributes.ts, system.ts, webhook.ts, index.ts)	New and expanded test-side API wrappers (bookmarks, commands, plugins, files, trial license, webhook checks); HTTP client: IPv4 forcing, 401 re-login and 5xx retry logic, clearCookies export.
Detox screens & tests detox/e2e/support/ui/screen/*, detox/e2e/test/... (many new/modified specs, including .../ipad/*)	Add ChannelBookmark screen; update 30+ screen objects with polling, timeouts, retry/sync helpers; add many new and updated E2E suites (iPad-specific, bookmarks, file/gallery, messaging, search, threads, etc.).
Ephemeral saved-post tracking & observables app/store/ephemeral_store.ts, app/queries/servers/post.ts, app/queries/servers/post.test.ts, app/actions/websocket/preferences.ts, app/actions/remote/preference.ts, app/actions/remote/preference.test.ts	Introduce ephemeral “recently unsaved saved post” with 2‑minute expiry, observable subjects, APIs to add/clear/observe; integrate filtering into saved-post observables and preference save/delete flows (awaits and EphemeralStore updates).
Thread, unread & preference flows app/actions/local/thread.ts, app/actions/local/thread.test.ts, app/actions/remote/thread.ts, app/actions/remote/thread.test.ts, app/actions/remote/search.ts	createThreadFromNewPost now backfills thread from root post when needed and marks following; markThreadAsUnread updates unread counts from REST response; use getConfigBooleanValue for boolean config reads.
UI components — testIDs & accessibility app/components/**, app/screens/**, app/products/calls/** (30+ files)	Added many testID props and small accessibility tweaks (bottom sheet modal flag, accessible flags) for robust E2E targeting.
Keyboard/animation guards & UI HOCs app/components/post_list/*, app/components/floating_input/*, app/hooks/useKeyboardAwarePostDraft.ts, app/hooks/useKeyboardScrollAdjustment.ts, app/components/post_with_channel_info/*, app/components/thread_overview/*, app/components/post_list/index.ts	Add finite-number guards to animated values, defensive contentInset handling, Android keyboardDismissMode adjustments, thread/post saved-state HOC changes to accept optional serverUrl and wrap with withServerUrl.
Misc & repo config android/gradle.properties, .gitignore	Enable Gradle parallel & caching; update .gitignore for mobile artifacts, Maestro files, and Detox outputs.

Sequence Diagram(s)

sequenceDiagram
    participant Client as UI (user)
    participant App as Mobile app logic
    participant Server as REST API
    participant Ephemeral as EphemeralStore
    participant DB as Local observers / Database

    Client->>App: User taps "Unsave post"
    App->>Server: await DELETE /api/v4/preferences
    alt server 200
        Server-->>App: success
        App->>Ephemeral: addRecentlyUnsavedSavedPost(serverUrl, postId)
        Ephemeral-->>DB: emits updated Set / post boolean
        DB-->>App: saved-post observable emits false
        App-->>Client: UI updates (post shown unsaved)
    else server error
        Server-->>App: error
        App->>Client: surface error, do not mark ephemeral saved state
    end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• Add AGENT tag in at-mention autocomplete for AI agents #9507 — Adds iPad-specific E2E tests and workflows; directly related to skipping ipad/ specs and iPad CI additions.
• Improve docs for e2e testing in iOS #9674 — Updates detox/e2e/support/test_config.ts URL fallback logic; related to new iPad/maestro workflows and test server URLs.
• mattermost/mattermost-mobile#??? — (No other strong code-level matches found; additional related PRs may exist for ephemeral-store or saved-post observables.)

Suggested Labels

2: Dev Review, Build Apps for PR, 3: QA Review

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch SEC-9886-2

[coderabbitai]

Actionable comments posted: 5

Note

Due to the large number of review comments, Critical severity comments were prioritized as inline comments.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (9)

detox/e2e/support/ui/screen/notification_settings.ts (1)

45-52: ⚠️ Potential issue | 🟠 Major

Do not swallow back-navigation failures in screen helpers.

Catching and only warning here can let tests pass even when navigation is broken. Please rethrow after logging (or remove the catch) so failures remain actionable.

Suggested fix

     back = async () => {
-        try {
-            await waitFor(this.backButton).toExist().withTimeout(timeouts.TEN_SEC);
-            await this.backButton.tap();
-            await expect(this.notificationSettingsScreen).not.toBeVisible();
-        } catch (error) {
-            // Back button may not exist if screen failed to load or already navigated away
-            console.warn('[NotificationSettingsScreen.back] Navigation failed:', error); // eslint-disable-line no-console
-        }
+        await waitFor(this.backButton).toExist().withTimeout(timeouts.TEN_SEC);
+        await this.backButton.tap();
+        await expect(this.notificationSettingsScreen).not.toBeVisible();
     };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/support/ui/screen/notification_settings.ts` around lines 45 - 52,
The current catch block in the back navigation helper for
NotificationSettingsScreen swallows errors (around
waitFor(this.backButton).toExist(), this.backButton.tap(), and
expect(this.notificationSettingsScreen).not.toBeVisible()), which lets
navigation failures go unnoticed; update the catch to log the error (keep the
existing console.warn) and then rethrow the caught error (or simply remove the
try/catch) so the failure surfaces to the test runner instead of being silently
ignored.

detox/e2e/support/ui/screen/auto_responder_notification_settings.ts (1)

40-48: ⚠️ Potential issue | 🟠 Major

Don't swallow failed back navigation here.

If the back button never appears, the tap fails, or the screen stays mounted, this helper still resolves successfully and the test keeps running from the wrong state. That makes the real failure much harder to diagnose.

Suggested fix

     back = async () => {
-        try {
-            await waitFor(this.backButton).toExist().withTimeout(timeouts.TEN_SEC);
-            await this.backButton.tap();
-            await expect(this.autoResponderNotificationSettingsScreen).not.toBeVisible();
-        } catch (error) {
-            // Back button may not exist if screen failed to load or already navigated away
-            console.warn('[AutoResponderNotificationSettingsScreen.back] Navigation failed:', error); // eslint-disable-line no-console
-        }
+        await waitFor(this.backButton).toExist().withTimeout(timeouts.TEN_SEC);
+        await this.backButton.tap();
+        await expect(this.autoResponderNotificationSettingsScreen).not.toBeVisible();
     };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/support/ui/screen/auto_responder_notification_settings.ts` around
lines 40 - 48, The back() helper currently swallows navigation failures in its
try/catch, so change it to surface errors: in the back() function, after
awaiting waitFor(this.backButton).toExist(), await this.backButton.tap(), then
await expect(this.autoResponderNotificationSettingsScreen).not.toBeVisible(); if
any of those steps fail, do not just console.warn — rethrow the caught error (or
throw a new Error with context) so the test fails; alternatively, validate the
final state and throw a descriptive error when the screen is still visible.
Ensure the change references the same symbols: back(), this.backButton, and
this.autoResponderNotificationSettingsScreen.

.github/workflows/compatibility-matrix-testing.yml (1)

219-237: ⚠️ Potential issue | 🟠 Major

The final commit status still only reflects the iOS Detox job.

Adding the new jobs to needs is not enough here: lines 235-236 still publish STATUS and TARGET_URL from detox-e2e only. If Android, iPad, or Maestro fails while iOS passes, this workflow will still report green. Please aggregate all new job results before updating the commit status.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/compatibility-matrix-testing.yml around lines 219 - 237,
The step calling mattermost/actions/delivery/update-commit-status@main currently
uses only needs.detox-e2e.outputs.STATUS and TARGET_URL so the final commit
status reflects iOS only; update that step to aggregate outputs from all
dependent jobs (detox-e2e, detox-android-e2e, detox-ipad-e2e, maestro-ios-e2e,
maestro-android-e2e) by computing an overall STATUS (e.g., fail if any job
STATUS == "failure", otherwise success) and choose a TARGET_URL that points to
the first failing job or a combined summary link, then pass those aggregated
values into the update-commit-status inputs instead of the single detox-e2e
outputs.

detox/e2e/test/products/channels/interactive_dialog/interactive_dialog_plugin.e2e.ts (1)

102-107: ⚠️ Potential issue | 🟡 Minor

Missing .tap() call on iOS alert dismissal.

The iOS branch finds the element but never taps it. This will silently fail to dismiss the alert.

🐛 Proposed fix

 async function dismissErrorAlert() {
     try {
-        isAndroid() ? await element(by.text('OK')).tap() : await element(by.label('OK')).atIndex(1);
+        isAndroid() ? await element(by.text('OK')).tap() : await element(by.label('OK')).atIndex(1).tap();
         await wait(300);
     } catch {}
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@detox/e2e/test/products/channels/interactive_dialog/interactive_dialog_plugin.e2e.ts`
around lines 102 - 107, In dismissErrorAlert(), the iOS branch locates the OK
button via element(by.label('OK')).atIndex(1) but never performs the tap; update
the iOS branch to await a .tap() on that element (mirror the Android branch's
await element(...).tap()) so the alert is actually dismissed (references:
dismissErrorAlert, isAndroid, element(by.label('OK')).atIndex(1)).

detox/e2e/support/ui/screen/saved_messages.ts (1)

52-57: ⚠️ Potential issue | 🟠 Major

Ensure savedMessagesTab is visible before tapping in HomeScreen.

The "View is not visible around point" error occurs because HomeScreen.savedMessagesTab.tap() is called without verifying the element is ready. The HomeScreen.toBeVisible() method only checks channelListTab availability, leaving savedMessagesTab unchecked. Add visibility polling for savedMessagesTab in HomeScreen.toBeVisible() to prevent this flake:

toBeVisible = async () => {
    const timeout = isAndroid() ? timeouts.TWENTY_SEC : timeouts.TEN_SEC;
    await waitFor(this.channelListTab).toExist().withTimeout(timeout);
    await waitFor(this.savedMessagesTab).toExist().withTimeout(timeout);
};

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/support/ui/screen/saved_messages.ts` around lines 52 - 57, The
HomeScreen.open calls HomeScreen.savedMessagesTab.tap() without ensuring the
savedMessagesTab element is present; update HomeScreen.toBeVisible() to also
wait for savedMessagesTab (in addition to channelListTab) to exist before
returning—use the same timeout logic used for channelListTab (e.g., isAndroid()
? timeouts.TWENTY_SEC : timeouts.TEN_SEC) and call
waitFor(this.savedMessagesTab).toExist().withTimeout(timeout) so
savedMessagesTab is visible before open() taps it.

detox/e2e/support/ui/screen/search_messages.ts (1)

82-87: ⚠️ Potential issue | 🟡 Minor

Add visibility check before tapping searchTab in the open() method.

The searchTab.tap() call needs a visibility wait before it, following the pattern already established in HomeScreen.logout() (lines 40-51 in home.ts). Add waitFor(HomeScreen.searchTab).toExist().withTimeout(timeout) using an appropriate timeout constant before the tap to prevent "View is not hittable" errors across platforms.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/support/ui/screen/search_messages.ts` around lines 82 - 87, In the
open() method of search_messages.ts, add a visibility wait before calling
HomeScreen.searchTab.tap(): call
waitFor(HomeScreen.searchTab).toExist().withTimeout(timeout) (using the same
timeout constant/pattern used in HomeScreen.logout) immediately before
HomeScreen.searchTab.tap() so the tap only occurs after the element is present
and avoid "View is not hittable" errors.

detox/e2e/test/products/channels/channels/convert_to_private_channel.e2e.ts (1)

82-85: ⚠️ Potential issue | 🟠 Major

Dismiss the scheduled-post tooltip in the cancel flow too.

The first test clears this overlay before navigating away, but this path still goes straight into channel info. If the tooltip renders here, ChannelScreen.back() at the end can leave the suite on the channel screen, which matches the logout timeout showing up in CI.

🛠️ Suggested fix

         await CreateOrEditChannelScreen.openCreateChannel();
         await CreateOrEditChannelScreen.displayNameInput.replaceText(channelDisplayName);
         await CreateOrEditChannelScreen.createButton.tap();
+        await ChannelScreen.dismissScheduledPostTooltip();
         await ChannelInfoScreen.open();
         await ChannelInfoScreen.openChannelSettings();

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/test/products/channels/channels/convert_to_private_channel.e2e.ts`
around lines 82 - 85, The cancel flow can leave the scheduled-post tooltip
active after creating a channel and opening ChannelInfoScreen; update the test
flow that calls CreateOrEditChannelScreen.openCreateChannel(),
displayNameInput.replaceText(...), createButton.tap(), and
ChannelInfoScreen.open() to explicitly dismiss the tooltip before navigating
away by invoking the scheduled-post tooltip helper (e.g.
ScheduledPostTooltip.dismissIfVisible() or ScheduledPostsTooltip.dismiss())
after ChannelInfoScreen.open() and prior to ChannelScreen.back(), ensuring the
overlay cannot block the back/navigation step.

detox/e2e/test/products/channels/threads/follow_and_unfollow_thread.e2e.ts (1)

180-210: ⚠️ Potential issue | 🟠 Major

Return to the channel list before ending this test.

This case stops on GlobalThreadsScreen, so afterAll logs out from the wrong surface and the suite leaks state into teardown. Please navigate back to the channel list after the final assertion.

As per coding guidelines, "Each test should navigate back to channel list at the end to ensure clean state for the next test".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/test/products/channels/threads/follow_and_unfollow_thread.e2e.ts`
around lines 180 - 210, The test ends on GlobalThreadsScreen and never returns
to the channel list; after the final assertion add navigation back to the
channel list by calling await GlobalThreadsScreen.back(); (if that back helper
isn't available in this screen, instead call await
ChannelScreen.open(channelsCategory, testChannel.name)) so the test finishes on
the channel list and does not leak state for subsequent tests.

detox/e2e/test/products/channels/smoke_test/threads.e2e.ts (1)

270-272: ⚠️ Potential issue | 🟡 Minor

Potential navigation state mismatch.

After ThreadScreen.back() on line 258 and ThreadOptionsScreen.openInChannelOption flow, you navigate through PermalinkScreen and end on ChannelScreen. The GlobalThreadsScreen.back() call on line 272 appears unreachable since you're not on the GlobalThreadsScreen at this point - you're on ChannelScreen (confirmed by line 266-268).

🔧 Suggested fix

         // # Go back to channel list screen
         await ChannelScreen.back();
-        await GlobalThreadsScreen.back();

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/test/products/channels/smoke_test/threads.e2e.ts` around lines 270
- 272, The GlobalThreadsScreen.back() call is unreachable after the
ThreadScreen.back() -> ThreadOptionsScreen.openInChannelOption ->
PermalinkScreen -> ChannelScreen flow; remove the dangling
GlobalThreadsScreen.back() invocation (or if the intent was to return to
GlobalThreadsScreen, instead call GlobalThreadsScreen.back() before navigating
into the channel/permalink flow). Update the sequence around
ThreadScreen.back(), ThreadOptionsScreen.openInChannelOption, PermalinkScreen,
and ChannelScreen to either delete GlobalThreadsScreen.back() or reposition it
so it is executed while the app is actually on GlobalThreadsScreen.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33a52e39-af83-49b1-b5ae-a2037cb022c0

📥 Commits

Reviewing files that changed from the base of the PR and between 1e169c7 and 1938bb1.

⛔ Files ignored due to path filters (5)

• detox/e2e/support/fixtures/audio.mp3 is excluded by !**/*.mp3
• detox/e2e/support/fixtures/image.png is excluded by !**/*.png
• detox/e2e/support/fixtures/sample.pdf is excluded by !**/*.pdf
• detox/package-lock.json is excluded by !**/package-lock.json
• maestro/package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (282)

• .github/actions/generate-specs/split-tests.js
• .github/actions/prepare-ios-build/action.yaml
• .github/actions/prepare-node-deps/action.yaml
• .github/actions/test/action.yaml
• .github/workflows/compatibility-matrix-testing.yml
• .github/workflows/e2e-android-template.yml
• .github/workflows/e2e-cancel-on-label-removal.yml
• .github/workflows/e2e-detox-pr.yml
• .github/workflows/e2e-detox-release.yml
• .github/workflows/e2e-detox-scheduled.yml
• .github/workflows/e2e-ios-template.yml
• .github/workflows/e2e-maestro-template.yml
• .gitignore
• android/gradle.properties
• app/actions/local/thread.test.ts
• app/actions/local/thread.ts
• app/actions/remote/preference.test.ts
• app/actions/remote/preference.ts
• app/actions/remote/search.ts
• app/actions/remote/thread.test.ts
• app/actions/remote/thread.ts
• app/actions/websocket/channel.ts
• app/actions/websocket/preferences.test.ts
• app/actions/websocket/preferences.ts
• app/components/channel_bookmarks/add_bookmark.tsx
• app/components/channel_bookmarks/bookmark_type.tsx
• app/components/channel_bookmarks/channel_bookmark/bookmark_details.tsx
• app/components/channel_bookmarks/channel_bookmark/channel_bookmark.tsx
• app/components/channel_bookmarks/channel_bookmarks.tsx
• app/components/common_post_options/save_option.tsx
• app/components/floating_input/floating_input_container.tsx
• app/components/floating_input/floating_text_input_label.tsx
• app/components/keyboard_aware_post_draft_container.tsx
• app/components/post_list/index.ts
• app/components/post_list/post_list.tsx
• app/components/post_list/thread_overview/index.ts
• app/components/post_with_channel_info/index.ts
• app/components/pressable_opacity/index.tsx
• app/hooks/useKeyboardAwarePostDraft.ts
• app/hooks/useKeyboardScrollAdjustment.ts
• app/products/calls/components/current_call_bar/current_call_bar.tsx
• app/products/calls/components/join_call_banner/join_call_banner.tsx
• app/queries/servers/post.test.ts
• app/queries/servers/post.ts
• app/queries/servers/system.test.ts
• app/queries/servers/system.ts
• app/queries/servers/thread.test.ts
• app/queries/servers/thread.ts
• app/screens/bottom_sheet/index.tsx
• app/screens/browse_channels/browse_channels.tsx
• app/screens/browse_channels/index.ts
• app/screens/channel_bookmark/components/bookmark_detail.tsx
• app/screens/channel_bookmark/components/bookmark_file/bookmark_file.tsx
• app/screens/channel_bookmark/components/bookmark_link.tsx
• app/screens/channel_bookmark/index.tsx
• app/screens/channel_settings/archive/index.ts
• app/screens/gallery/footer/actions/action.tsx
• app/screens/gallery/footer/actions/index.tsx
• app/screens/gallery/header/index.tsx
• app/screens/home/channel_list/categories_list/categories/categories.tsx
• app/screens/home/channel_list/categories_list/categories/header/header.tsx
• app/screens/home/channel_list/categories_list/categories/header/index.ts
• app/screens/home/channel_list/categories_list/categories/helpers/observe_flattened_categories.ts
• app/screens/home/channel_list/categories_list/header/header.tsx
• app/screens/home/saved_messages/index.ts
• app/screens/pinned_messages/pinned_messages.tsx
• app/screens/post_options/index.ts
• app/screens/post_priority_picker/post_priority_picker.test.tsx
• app/screens/thread_options/index.ts
• app/screens/user_profile/custom_attributes.tsx
• app/store/ephemeral_store.ts
• app/utils/opengraph.ts
• detox/.detoxrc.json
• detox/CLAUDE.md
• detox/README.md
• detox/android_emulator/config.ini
• detox/create_android_emulator.sh
• detox/detox/.detoxrc.json
• detox/e2e/config.js
• detox/e2e/global_setup.js
• detox/e2e/support/fixtures/sample.txt
• detox/e2e/support/server_api/channel_bookmark.ts
• detox/e2e/support/server_api/client.ts
• detox/e2e/support/server_api/command.ts
• detox/e2e/support/server_api/common.ts
• detox/e2e/support/server_api/custom_profile_attributes.ts
• detox/e2e/support/server_api/index.ts
• detox/e2e/support/server_api/plugin.ts
• detox/e2e/support/server_api/post.ts
• detox/e2e/support/server_api/system.ts
• detox/e2e/support/server_api/webhook.ts
• detox/e2e/support/test_config.ts
• detox/e2e/support/ui/component/alert.ts
• detox/e2e/support/ui/component/autocomplete.ts
• detox/e2e/support/ui/screen/account.ts
• detox/e2e/support/ui/screen/add_members.ts
• detox/e2e/support/ui/screen/auto_responder_notification_settings.ts
• detox/e2e/support/ui/screen/browse_channels.ts
• detox/e2e/support/ui/screen/channel.ts
• detox/e2e/support/ui/screen/channel_bookmark.ts
• detox/e2e/support/ui/screen/channel_dropdown_menu.ts
• detox/e2e/support/ui/screen/channel_info.ts
• detox/e2e/support/ui/screen/channel_list.ts
• detox/e2e/support/ui/screen/channel_settings.ts
• detox/e2e/support/ui/screen/create_direct_message.ts
• detox/e2e/support/ui/screen/create_or_edit_channel.ts
• detox/e2e/support/ui/screen/display_settings.ts
• detox/e2e/support/ui/screen/edit_post.ts
• detox/e2e/support/ui/screen/edit_profile.ts
• detox/e2e/support/ui/screen/edit_server.ts
• detox/e2e/support/ui/screen/email_notification_settings.ts
• detox/e2e/support/ui/screen/emoji_picker.ts
• detox/e2e/support/ui/screen/global_threads.ts
• detox/e2e/support/ui/screen/home.ts
• detox/e2e/support/ui/screen/index.ts
• detox/e2e/support/ui/screen/login.ts
• detox/e2e/support/ui/screen/manage_channel_members.ts
• detox/e2e/support/ui/screen/mention_notification_settings.ts
• detox/e2e/support/ui/screen/notification_settings.ts
• detox/e2e/support/ui/screen/permalink.ts
• detox/e2e/support/ui/screen/pinned_messages.ts
• detox/e2e/support/ui/screen/post_options.ts
• detox/e2e/support/ui/screen/push_notification_settings.ts
• detox/e2e/support/ui/screen/recent_mentions.ts
• detox/e2e/support/ui/screen/saved_messages.ts
• detox/e2e/support/ui/screen/search_messages.ts
• detox/e2e/support/ui/screen/server.ts
• detox/e2e/support/ui/screen/server_list.ts
• detox/e2e/support/ui/screen/settings.ts
• detox/e2e/support/ui/screen/table.ts
• detox/e2e/support/ui/screen/team_dropdown_menu.ts
• detox/e2e/support/ui/screen/thread.ts
• detox/e2e/support/utils/detoxhelpers.ts
• detox/e2e/support/utils/index.ts
• detox/e2e/test/products/agents/channel_summary.e2e.ts
• detox/e2e/test/products/agents/tool_calls_in_channels.e2e.ts
• detox/e2e/test/products/channels/account/account_menu.e2e.ts
• detox/e2e/test/products/channels/account/account_profile_picture.e2e.ts
• detox/e2e/test/products/channels/account/advanced_settings.e2e.ts
• detox/e2e/test/products/channels/account/auto_responder_notification_settings.e2e.ts
• detox/e2e/test/products/channels/account/clock_display_settings.e2e.ts
• detox/e2e/test/products/channels/account/custom_status.e2e.ts
• detox/e2e/test/products/channels/account/edit_profile.e2e.ts
• detox/e2e/test/products/channels/account/notification_settings.e2e.ts
• detox/e2e/test/products/channels/account/theme_color_picker.e2e.ts
• detox/e2e/test/products/channels/account/user_attributes.e2e.ts
• detox/e2e/test/products/channels/autocomplete/at_mention_name_matching.e2e.ts
• detox/e2e/test/products/channels/autocomplete/at_mention_user_suggestions.e2e.ts
• detox/e2e/test/products/channels/autocomplete/channel_mention.e2e.ts
• detox/e2e/test/products/channels/autocomplete/channel_post_draft.e2e.ts
• detox/e2e/test/products/channels/autocomplete/edit_channel.e2e.ts
• detox/e2e/test/products/channels/autocomplete/edit_post.e2e.ts
• detox/e2e/test/products/channels/autocomplete/search.e2e.ts
• detox/e2e/test/products/channels/channel_settings/channel_copy_tests.e2e.ts
• detox/e2e/test/products/channels/channel_settings/channel_create_edit.e2e.ts
• detox/e2e/test/products/channels/channel_settings/channel_join_leave.e2e.ts
• detox/e2e/test/products/channels/channel_settings/channel_members.e2e.ts
• detox/e2e/test/products/channels/channel_settings/channel_navigation.e2e.ts
• detox/e2e/test/products/channels/channel_settings/channel_notifications.e2e.ts
• detox/e2e/test/products/channels/channel_settings/channel_settings_smoke.e2e.ts
• detox/e2e/test/products/channels/channel_settings/channel_system_messages.e2e.ts
• detox/e2e/test/products/channels/channels/archive_channel.e2e.ts
• detox/e2e/test/products/channels/channels/browse_channels.e2e.ts
• detox/e2e/test/products/channels/channels/channel_bookmarks.e2e.ts
• detox/e2e/test/products/channels/channels/channel_bookmarks_permissions.e2e.ts
• detox/e2e/test/products/channels/channels/channel_bookmarks_search.e2e.ts
• detox/e2e/test/products/channels/channels/channel_info.e2e.ts
• detox/e2e/test/products/channels/channels/channel_list.e2e.ts
• detox/e2e/test/products/channels/channels/convert_to_private_channel.e2e.ts
• detox/e2e/test/products/channels/channels/create_channel_and_edit_channel_header.e2e.ts
• detox/e2e/test/products/channels/channels/create_direct_message.e2e.ts
• detox/e2e/test/products/channels/channels/edit_channel.e2e.ts
• detox/e2e/test/products/channels/channels/favorite_and_unfavorite_channel.e2e.ts
• detox/e2e/test/products/channels/channels/find_channels.e2e.ts
• detox/e2e/test/products/channels/channels/leave_channel.e2e.ts
• detox/e2e/test/products/channels/channels/manage_own_channel_membership.e2e.ts
• detox/e2e/test/products/channels/channels/mute_and_unmute_channel.e2e.ts
• detox/e2e/test/products/channels/channels/unarchive_channel.e2e.ts
• detox/e2e/test/products/channels/interactive_dialog/interactive_dialog_plugin.e2e.ts
• detox/e2e/test/products/channels/ipad/ipad_account_view.e2e.ts
• detox/e2e/test/products/channels/ipad/ipad_channel_navigation.e2e.ts
• detox/e2e/test/products/channels/ipad/ipad_post_message.e2e.ts
• detox/e2e/test/products/channels/ipad/ipad_sidebar_always_visible.e2e.ts
• detox/e2e/test/products/channels/localization/language.e2e.ts
• detox/e2e/test/products/channels/messaging/at_mention.e2e.ts
• detox/e2e/test/products/channels/messaging/channel_link.e2e.ts
• detox/e2e/test/products/channels/messaging/channel_mention.e2e.ts
• detox/e2e/test/products/channels/messaging/emoji_display.e2e.ts
• detox/e2e/test/products/channels/messaging/emojis_and_reactions.e2e.ts
• detox/e2e/test/products/channels/messaging/file_preview_gallery.e2e.ts
• detox/e2e/test/products/channels/messaging/file_type_preview.e2e.ts
• detox/e2e/test/products/channels/messaging/file_upload.e2e.ts
• detox/e2e/test/products/channels/messaging/image_attachment_post_options.e2e.ts
• detox/e2e/test/products/channels/messaging/large_gif_not_rendered.e2e.ts
• detox/e2e/test/products/channels/messaging/mark_as_unread.e2e.ts
• detox/e2e/test/products/channels/messaging/markdown_code.e2e.ts
• detox/e2e/test/products/channels/messaging/markdown_table.e2e.ts
• detox/e2e/test/products/channels/messaging/message_delete.e2e.ts
• detox/e2e/test/products/channels/messaging/message_edit.e2e.ts
• detox/e2e/test/products/channels/messaging/message_permalink.e2e.ts
• detox/e2e/test/products/channels/messaging/message_post.e2e.ts
• detox/e2e/test/products/channels/messaging/messaging_misc.e2e.ts
• detox/e2e/test/products/channels/messaging/pin_and_unpin_message.e2e.ts
• detox/e2e/test/products/channels/scheduled_messages/create_schedule_message.e2e.ts
• detox/e2e/test/products/channels/search/cross_team_search.e2e.ts
• detox/e2e/test/products/channels/search/hashtag_search.e2e.ts
• detox/e2e/test/products/channels/search/pinned_messages.e2e.ts
• detox/e2e/test/products/channels/search/recent_mentions.e2e.ts
• detox/e2e/test/products/channels/search/search_behaviors.e2e.ts
• detox/e2e/test/products/channels/search/search_cycle.e2e.ts
• detox/e2e/test/products/channels/search/search_messages.e2e.ts
• detox/e2e/test/products/channels/server_login/connect_to_server.e2e.ts
• detox/e2e/test/products/channels/server_login/server_list.e2e.ts
• detox/e2e/test/products/channels/smoke_test/channels.e2e.ts
• detox/e2e/test/products/channels/smoke_test/messaging.e2e.ts
• detox/e2e/test/products/channels/smoke_test/server_login.e2e.ts
• detox/e2e/test/products/channels/smoke_test/threads.e2e.ts
• detox/e2e/test/products/channels/teams/invite_people.e2e.ts
• detox/e2e/test/products/channels/threads/follow_and_unfollow_thread.e2e.ts
• detox/e2e/test/products/channels/threads/open_thread_in_channel.e2e.ts
• detox/e2e/test/products/channels/threads/reply_to_thread.e2e.ts
• detox/e2e/test/products/playbooks/playbooks-e2e.ts
• detox/e2e/test/products/playbooks/playbooks.ts
• detox/e2e/test/setup.ts
• detox/generate_unified_report.js
• detox/inject-detox-settings.js
• detox/package.json
• detox/provision_server.js
• detox/scripts/postinstall.js
• detox/scripts/run_android_gradle_build.sh
• detox/scripts/run_detox.sh
• detox/utils/disable_ios_autofill.js
• detox/utils/generate_detox_config_ci.js
• detox/utils/maestro_report.js
• detox/utils/report.js
• fastlane/Fastfile
• index.ts
• ios/MattermostShare/Views/ContentViews/ChannelListView/ChannelItemView.swift
• ios/MattermostShare/Views/ContentViews/ContentView.swift
• ios/MattermostShare/Views/NavigationButtons/PostButton.swift
• maestro/AGENTS.md
• maestro/README.md
• maestro/fixtures/calls_seed.ts
• maestro/fixtures/poll_for_message.ts
• maestro/fixtures/seed.ts
• maestro/fixtures/seed_file_preview.ts
• maestro/flows/account/help_url.yml
• maestro/flows/calls/call_ui_permission.yml
• maestro/flows/calls/device_a_start_call.yml
• maestro/flows/calls/device_b_join_call.yml
• maestro/flows/calls/leave_call.yml
• maestro/flows/calls/mute_unmute.yml
• maestro/flows/calls/start_call.yml
• maestro/flows/channels/channel_bookmark_file.yml
• maestro/flows/channels/channel_bookmark_file_android_picker.yml
• maestro/flows/channels/channel_bookmark_file_ios_picker.yml
• maestro/flows/channels/file_type_preview.yml
• maestro/flows/multi_device/user_a_sends_message.yml
• maestro/flows/multi_device/user_b_receives_message.yml
• maestro/flows/share_extension/share_image_to_channel.yml
• maestro/flows/share_extension/share_link_to_channel.yml
• maestro/flows/share_extension/share_text_to_channel.yml
• maestro/flows/timezone/clock_display.yml
• maestro/package.json
• maestro/scripts/reset_timezone.js
• maestro/scripts/run_calls_two_device.sh
• maestro/scripts/run_timezone_test.sh
• maestro/scripts/run_two_device.sh
• maestro/scripts/set_timezone.js
• maestro/tsconfig.json
• maestro/utils/connect_server.yml
• maestro/utils/login.yml
• maestro/utils/logout.yml
• maestro/utils/navigate_to_channel.yml
• maestro/utils/setup.yml
• patches/@gorhom+bottom-sheet+5.1.2.patch
• patches/react-native+0.77.3.patch
• patches/react-native-reanimated+3.17.3.patch
• share_extension/components/channel_item/channel_item.tsx
• share_extension/components/content_view/options/option.tsx
• share_extension/components/content_view/options/options.tsx
• share_extension/components/header/post_button.tsx

💤 Files with no reviewable changes (1)

• .github/actions/prepare-node-deps/action.yaml

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

The new out-of-channel autocomplete flow is still flaky.

Line 187 waits for the generic list after searching with a prefix that only matches a freshly-created user. In CI that user is not always indexed locally yet, so Autocomplete.sectionAtMentionList never appears and the test times out. Seed autocomplete with a known in-channel match first, or poll for the actual out-of-channel suggestion instead of sectionAtMentionList.

🧰 Tools

🪛 GitHub Actions: E2E

[error] 187-187: Detox test failed. Test Failed: Timed out while waiting for expectation: TOEXIST WITH MATCHER(id == “autocomplete.at_mention.section_list”) TIMEOUT(30s). (at_mention list not found)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/test/products/channels/messaging/at_mention.e2e.ts` around lines
167 - 188, The test is flaky because it waits for the generic
Autocomplete.sectionAtMentionList which may never appear if the freshly-created
outOfChannelUser isn’t indexed yet; update the check to poll for the specific
suggestion for outOfChannelUser instead of the generic list (e.g., waitFor an
item like Autocomplete.atMentionListItem(outOfChannelUser.username) or
Autocomplete.suggestionFor(outOfChannelUser.username) after typing into
ChannelScreen.postInput using usernamePrefix), and as a fallback seed the
autocomplete first with a known in-channel username (type a
knownInChannelUser.username briefly before typing `@${usernamePrefix}`) so the
component has results to display while the out-of-channel user is being indexed.

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

This new thread-delete flow is already red in CI.

Line 126 hits the same visibility-threshold failure as MM-T4784_3, so this adds another blocker instead of covering the regression. Please make ThreadScreen.openPostOptionsFor(...) reliably scroll to a fully hittable target in thread view before reusing it here.

🧰 Tools

🪛 GitHub Actions: E2E

[error] 126-126: Detox test failed (MM-T112): View is not hittable/visible around point. Error: View is not visible: View does not pass visibility percent threshold (100). Root call: longPressWithScrollRetry (support/utils/index.ts:196).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/test/products/channels/messaging/message_delete.e2e.ts` around
lines 125 - 128, ThreadScreen.openPostOptionsFor currently can target a post
that's not fully hittable in thread view; update openPostOptionsFor to reliably
scroll the thread list until the target post element is completely
visible/hittable before performing the long-press (so the call in
message_delete.e2e.ts no longer flakes). Specifically, inside
ThreadScreen.openPostOptionsFor locate the target post element (the same
selector used there), perform scrolling (loop if necessary) to bring it to the
center/fully visible area and verify hittability with a visibility/hittable
check before invoking the long-press that triggers
PostOptionsScreen.deletePost({confirm:true}); ensure the method returns only
after the element is confirmed hittable.

[mm-cloud-bot]

❌ E2E Test Setup Failed

Failed to create E2E test instances: failed to create installation: failed with status code 409

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (7)

detox/e2e/support/utils/index.ts (1)

308-331: Redundant require('detox') calls in final checks.

Both waitForElementToNotExist and waitForElementToExist import detoxExpect at the start of the function, then import it again as detoxExpectFinal for the final check outside the loop. Since the same detoxExpect reference would work, the second import is unnecessary.

♻️ Proposed simplification

 export async function waitForElementToNotExist(
     detoxElement: Detox.NativeElement,
     timeout: number = timeouts.HALF_MIN,
     pollInterval: number = timeouts.HALF_SEC,
 ): Promise<void> {
     const {expect: detoxExpect} = require('detox');
     const startTime = Date.now();
     /* eslint-disable no-await-in-loop */
     while (Date.now() - startTime < timeout) {
         try {
             await detoxExpect(detoxElement).not.toExist();
             return; // Element no longer exists
         } catch (error) {
             if ((Date.now() - startTime) + pollInterval >= timeout) {
                 throw error;
             }
             await wait(pollInterval);
         }
     }
     /* eslint-enable no-await-in-loop */
     // Final check - will throw if still exists
-    const {expect: detoxExpectFinal} = require('detox');
-    await detoxExpectFinal(detoxElement).not.toExist();
+    await detoxExpect(detoxElement).not.toExist();
 }

Apply the same pattern to waitForElementToExist.

Also applies to: 353-376

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/support/utils/index.ts` around lines 308 - 331, The final explicit
require('detox') call is redundant: in waitForElementToNotExist (and similarly
in waitForElementToExist) you already destructured detoxExpect at the top;
remove the second require and reuse the initial detoxExpect instead of
detoxExpectFinal for the final check and any other post-loop assertions to avoid
duplicate requires and keep behavior identical.

detox/e2e/test/products/channels/ipad/ipad_post_message.e2e.ts (2)

136-140: Redundant assertion after waitFor.

At line 139, await expect(postListPostItem).toExist() immediately follows await waitFor(postListPostItem).toExist().withTimeout(...) at line 138. If the waitFor succeeds, the expect is guaranteed to pass and adds no value.

♻️ Remove redundant assertion

         const {post} = await Post.apiGetLastPostInChannel(siteOneUrl, testChannel.id);
         const {postListPostItem} = ChannelScreen.getPostListPostItem(post.id, message);
         await waitFor(postListPostItem).toExist().withTimeout(timeouts.TEN_SEC);
-        await expect(postListPostItem).toExist();
     });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/test/products/channels/ipad/ipad_post_message.e2e.ts` around lines
136 - 140, The second explicit assertion is redundant: after awaiting
waitFor(postListPostItem).toExist().withTimeout(...), the element existence is
already verified, so remove the duplicate await
expect(postListPostItem).toExist(); Delete the expect line that references
postListPostItem in the test using ChannelScreen.getPostListPostItem and rely on
the waitFor(...) call to assert existence.

---

61-82: Test doesn't navigate back to channel list at end.

Per coding guidelines, each test should navigate back to channel list at the end for clean state for next test. While beforeEach relaunches the app on iPad which provides isolation, for consistency and to align with guidelines, consider adding navigation back to channel list.

This applies to all five tests in this file (MM-TIPAD_15 through MM-TIPAD_19).

♻️ Proposed fix for MM-TIPAD_15

         // * Verify the sidebar is still visible after posting (tablet split view).
         // On iPad the software keyboard (UITextEffectsWindow) may cover the lower portion of
         // the channel_list.screen SafeAreaView, dropping its visible percentage below the 75%
         // threshold required by toBeVisible().  Use toExist() to confirm the view is in the
         // hierarchy regardless of transient keyboard obstruction.
         await waitFor(ChannelListScreen.channelListScreen).toExist().withTimeout(timeouts.TEN_SEC);
+
+        // # Navigate back to channel list for clean state
+        await ChannelScreen.back();
     });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/test/products/channels/ipad/ipad_post_message.e2e.ts` around lines
61 - 82, The test MM-TIPAD_15 does not navigate back to the channel list at the
end; update the test to return the app to the channel list after the final
assertion by invoking the navigation helper (e.g., call
ChannelScreen.backToChannelList() — or the existing helper that performs the
same action) immediately after the
waitFor(ChannelListScreen.channelListScreen)...withTimeout(...) line so the test
leaves the app in the channel-list state for subsequent tests; apply the same
change to MM-TIPAD_16 through MM-TIPAD_19.

detox/e2e/test/products/channels/channels/archive_channel.e2e.ts (2)

105-130: Android fallback in closeBrowseChannelsChannel may cause unexpected navigation.

In the Android branch (lines 112-121), if the close button isn't found, the code falls back to device.pressBack(). However, if Browse Channels was already dismissed, pressBack() might navigate further back than intended (e.g., to a previous screen in the stack).

Consider whether the catch block should simply do nothing (like the iOS branch) rather than calling pressBack().

♻️ Proposed fix for safer fallback

     if (isAndroid()) {
         // On Android the modal stack can collapse differently — use pressBack
         // which reliably dismisses the current screen regardless of stack depth.
         try {
             await waitFor(BrowseChannelsScreen.closeButton).toExist().withTimeout(timeouts.FOUR_SEC);
             await BrowseChannelsScreen.closeButton.tap();
         } catch {
             // Browse Channels was already dismissed when Channel.back() popped the stack
-            await device.pressBack();
+            // No action needed — navigation already complete
         }
     } else {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/test/products/channels/channels/archive_channel.e2e.ts` around
lines 105 - 130, The Android fallback in closeBrowseChannelsChannel currently
calls device.pressBack() inside the catch when BrowseChannelsScreen.closeButton
isn't found, which can over-navigate; change the catch to mirror the iOS branch
by doing nothing (no pressBack) or alternatively perform a safe existence check
before calling device.pressBack(); update the catch block that references
BrowseChannelsScreen.closeButton and device.pressBack so that if the close
button is missing after ChannelScreen.back()/switchToChannelById, the function
simply returns without invoking device.pressBack().

---

666-733: Search test properly handles synchronization around tapReturnKey.

The test at MM-T1679_1 correctly disables synchronization before tapReturnKey() and re-enables it after waiting for results. However, if waitForElementToBeVisible throws, synchronization would be left disabled.

♻️ Proposed fix for synchronization safety

         // * Verify the search result contains the message from the archived channel
         // Disable synchronization before tapReturnKey: the search keeps the dispatch
         // queue busy while processing network/DB work, which would otherwise cause
         // tapReturnKey to block indefinitely waiting for Detox idle.
         await device.disableSynchronization();
-        await SearchMessagesScreen.searchInput.tapReturnKey();
-
-        // Wait for the search result text to appear (text element, not the composed matcher
-        // which uses withDescendant and can be unreliable when text is highlighted/split).
-        const searchResultText = element(
-            by.
-                text(uniqueMessage).
-                withAncestor(by.id(SearchMessagesScreen.postList.testID.flatList)),
-        );
-        await waitForElementToBeVisible(searchResultText, timeouts.ONE_MIN);
-        await device.enableSynchronization();
+        try {
+            await SearchMessagesScreen.searchInput.tapReturnKey();
+
+            // Wait for the search result text to appear (text element, not the composed matcher
+            // which uses withDescendant and can be unreliable when text is highlighted/split).
+            const searchResultText = element(
+                by.
+                    text(uniqueMessage).
+                    withAncestor(by.id(SearchMessagesScreen.postList.testID.flatList)),
+            );
+            await waitForElementToBeVisible(searchResultText, timeouts.ONE_MIN);
+        } finally {
+            await device.enableSynchronization();
+        }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/test/products/channels/channels/archive_channel.e2e.ts` around
lines 666 - 733, The test disables Detox synchronization before calling
SearchMessagesScreen.searchInput.tapReturnKey() but re-enables it only after
waitForElementToBeVisible, so if that wait throws the test leaves
synchronization disabled; wrap the disable/enable sequence in a try/finally
(call device.disableSynchronization() then try { tapReturnKey(); await
waitForElementToBeVisible(searchResultText, ...) } finally {
device.enableSynchronization() }) to guarantee device.enableSynchronization()
always runs; update the MM-T1679_1 test around
SearchMessagesScreen.searchInput.tapReturnKey / waitForElementToBeVisible to use
this pattern.

detox/e2e/support/ui/screen/thread.ts (1)

91-107: Tooltip dismissal could verify dismissal completed.

The dismissScheduledPostTooltip method taps the close button but doesn't verify the tooltip actually disappeared. The relevant code snippet from account.ts (lines 115-125) shows a more robust pattern that waits for the tooltip to not exist after tapping.

This is a minor concern since the wait(HALF_SEC) provides some buffer, but for reliability on slower CI environments, consider adding the verification.

♻️ Proposed improvement for robustness

     dismissScheduledPostTooltip = async () => {
         // Try to close scheduled post tooltip if it exists (try both regular and admin account versions)
         try {
             await waitFor(this.scheduledPostTooltipCloseButton).toBeVisible().withTimeout(timeouts.FOUR_SEC);
             await this.scheduledPostTooltipCloseButton.tap();
-            await wait(timeouts.HALF_SEC);
+            await waitFor(this.scheduledPostTooltipCloseButton).not.toExist().withTimeout(timeouts.FIVE_SEC);
         } catch {
             // Try admin account version
             try {
                 await waitFor(this.scheduledPostTooltipCloseButtonAdminAccount).toBeVisible().withTimeout(timeouts.FOUR_SEC);
                 await this.scheduledPostTooltipCloseButtonAdminAccount.tap();
-                await wait(timeouts.HALF_SEC);
+                await waitFor(this.scheduledPostTooltipCloseButtonAdminAccount).not.toExist().withTimeout(timeouts.FIVE_SEC);
             } catch {
                 // Tooltip not visible, continue
             }
         }
     };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/support/ui/screen/thread.ts` around lines 91 - 107, The
dismissScheduledPostTooltip function currently taps the close buttons
(scheduledPostTooltipCloseButton and
scheduledPostTooltipCloseButtonAdminAccount) but only waits a fixed HALF_SEC;
update both tap paths in dismissScheduledPostTooltip to explicitly verify the
tooltip is gone after tapping by waiting for the corresponding tooltip element
to be not visible/not exist (use the same waitFor(...).toBeNotVisible() or
.toNotExist() pattern used in account.ts) with an appropriate timeout instead of
relying on wait(timeouts.HALF_SEC), so each branch confirms dismissal completed.

detox/e2e/support/ui/screen/channel.ts (1)

420-446: Comment about locale-dependent behavior is incorrect.

The comment at line 442 mentions moment.weekday() being locale-dependent, but the code uses new Date().getDay() which returns 0-6 (Sunday-Saturday) regardless of locale. The comment should be updated to reflect the actual implementation.

Additionally, the logic for Sunday (day 0) falls through to scheduleMessageForMonday() per the comment at lines 441-444, but the docstring at line 424 states Sunday should use "Tomorrow". Consider clarifying which behavior is intended.

📝 Proposed comment fix

     scheduleMessageForAvailableOption = async () => {
         const day = new Date().getDay(); // 0 = Sunday … 6 = Saturday
         if (day === 5 || day === 6) {
             // Friday or Saturday: only "Monday" is available
             await this.scheduleMessageForMonday();
         } else if (day === 1) {
             // Monday: "Tomorrow" and "Next Monday" are available; pick "Next Monday"
             await this.scheduleMessageForNextMonday();
         } else {
-            // Sunday, Tuesday–Thursday: "Tomorrow" is available but may not match on
-            // all CI server locales (moment.weekday() is locale-dependent). Use "Monday"
-            // which is always present as a stable fallback on weekdays.
+            // Sunday, Tuesday–Thursday: "Tomorrow" is available. Use "Monday"
+            // as a stable fallback since it's reliably present on these days.
             await this.scheduleMessageForMonday();
         }
     };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/support/ui/screen/channel.ts` around lines 420 - 446, The docstring
and inline comment for scheduleMessageForAvailableOption are inconsistent and
incorrect about locale dependence: replace the mention of moment.weekday() with
an accurate note that new Date().getDay() returns 0–6 (Sunday–Saturday)
regardless of locale, and then reconcile the Sunday behavior—either change the
code to call scheduleMessageForTomorrow when day === 0 (if you intend Sunday to
pick "Tomorrow") or update the docstring's schedule table to state that Sunday
falls through to scheduleMessageForMonday; adjust the comment block and any
mention near scheduleMessageForMonday and scheduleMessageForNextMonday
accordingly so comments match the actual logic.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@detox/e2e/support/ui/screen/channel_list.ts`:
- Around line 138-190: The recovery relaunch in ChannelListScreen.toBeVisible
uses the wrong launch arg key/value (detoxDisableSynchronization: 'YES') so
synchronization isn't actually disabled; update the device.launchApp call in
toBeVisible to pass launchArgs with the correct key detoxEnableSynchronization
and set it to 0 (or "NO") to disable Detox synchronization during the recovery
relaunch.

---

Nitpick comments:
In `@detox/e2e/support/ui/screen/channel.ts`:
- Around line 420-446: The docstring and inline comment for
scheduleMessageForAvailableOption are inconsistent and incorrect about locale
dependence: replace the mention of moment.weekday() with an accurate note that
new Date().getDay() returns 0–6 (Sunday–Saturday) regardless of locale, and then
reconcile the Sunday behavior—either change the code to call
scheduleMessageForTomorrow when day === 0 (if you intend Sunday to pick
"Tomorrow") or update the docstring's schedule table to state that Sunday falls
through to scheduleMessageForMonday; adjust the comment block and any mention
near scheduleMessageForMonday and scheduleMessageForNextMonday accordingly so
comments match the actual logic.

In `@detox/e2e/support/ui/screen/thread.ts`:
- Around line 91-107: The dismissScheduledPostTooltip function currently taps
the close buttons (scheduledPostTooltipCloseButton and
scheduledPostTooltipCloseButtonAdminAccount) but only waits a fixed HALF_SEC;
update both tap paths in dismissScheduledPostTooltip to explicitly verify the
tooltip is gone after tapping by waiting for the corresponding tooltip element
to be not visible/not exist (use the same waitFor(...).toBeNotVisible() or
.toNotExist() pattern used in account.ts) with an appropriate timeout instead of
relying on wait(timeouts.HALF_SEC), so each branch confirms dismissal completed.

In `@detox/e2e/support/utils/index.ts`:
- Around line 308-331: The final explicit require('detox') call is redundant: in
waitForElementToNotExist (and similarly in waitForElementToExist) you already
destructured detoxExpect at the top; remove the second require and reuse the
initial detoxExpect instead of detoxExpectFinal for the final check and any
other post-loop assertions to avoid duplicate requires and keep behavior
identical.

In `@detox/e2e/test/products/channels/channels/archive_channel.e2e.ts`:
- Around line 105-130: The Android fallback in closeBrowseChannelsChannel
currently calls device.pressBack() inside the catch when
BrowseChannelsScreen.closeButton isn't found, which can over-navigate; change
the catch to mirror the iOS branch by doing nothing (no pressBack) or
alternatively perform a safe existence check before calling device.pressBack();
update the catch block that references BrowseChannelsScreen.closeButton and
device.pressBack so that if the close button is missing after
ChannelScreen.back()/switchToChannelById, the function simply returns without
invoking device.pressBack().
- Around line 666-733: The test disables Detox synchronization before calling
SearchMessagesScreen.searchInput.tapReturnKey() but re-enables it only after
waitForElementToBeVisible, so if that wait throws the test leaves
synchronization disabled; wrap the disable/enable sequence in a try/finally
(call device.disableSynchronization() then try { tapReturnKey(); await
waitForElementToBeVisible(searchResultText, ...) } finally {
device.enableSynchronization() }) to guarantee device.enableSynchronization()
always runs; update the MM-T1679_1 test around
SearchMessagesScreen.searchInput.tapReturnKey / waitForElementToBeVisible to use
this pattern.

In `@detox/e2e/test/products/channels/ipad/ipad_post_message.e2e.ts`:
- Around line 136-140: The second explicit assertion is redundant: after
awaiting waitFor(postListPostItem).toExist().withTimeout(...), the element
existence is already verified, so remove the duplicate await
expect(postListPostItem).toExist(); Delete the expect line that references
postListPostItem in the test using ChannelScreen.getPostListPostItem and rely on
the waitFor(...) call to assert existence.
- Around line 61-82: The test MM-TIPAD_15 does not navigate back to the channel
list at the end; update the test to return the app to the channel list after the
final assertion by invoking the navigation helper (e.g., call
ChannelScreen.backToChannelList() — or the existing helper that performs the
same action) immediately after the
waitFor(ChannelListScreen.channelListScreen)...withTimeout(...) line so the test
leaves the app in the channel-list state for subsequent tests; apply the same
change to MM-TIPAD_16 through MM-TIPAD_19.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7989c8d8-1776-4c81-879a-3ff4dbc0a565

📥 Commits

Reviewing files that changed from the base of the PR and between 1938bb1 and 491abc1.

📒 Files selected for processing (12)

• app/products/calls/connection/websocket_client.ts
• detox/e2e/support/ui/screen/channel.ts
• detox/e2e/support/ui/screen/channel_info.ts
• detox/e2e/support/ui/screen/channel_list.ts
• detox/e2e/support/ui/screen/thread.ts
• detox/e2e/support/utils/index.ts
• detox/e2e/test/products/agents/agent_mention.e2e.ts
• detox/e2e/test/products/channels/autocomplete/search.e2e.ts
• detox/e2e/test/products/channels/channels/archive_channel.e2e.ts
• detox/e2e/test/products/channels/ipad/ipad_post_message.e2e.ts
• detox/e2e/test/products/channels/messaging/large_gif_not_rendered.e2e.ts
• detox/e2e/test/products/channels/search/cross_team_search.e2e.ts

✅ Files skipped from review due to trivial changes (3)

• app/products/calls/connection/websocket_client.ts
• detox/e2e/test/products/channels/messaging/large_gif_not_rendered.e2e.ts
• detox/e2e/test/products/channels/autocomplete/search.e2e.ts

🚧 Files skipped from review as they are similar to previous changes (2)

• detox/e2e/support/ui/screen/channel_info.ts
• detox/e2e/test/products/channels/search/cross_team_search.e2e.ts

[coderabbitai]

🧹 Nitpick comments (4)

detox/e2e/test/products/channels/channels/archive_channel.e2e.ts (1)

99-129: Duplicated logic between iOS and Android branches.

The closeBrowseChannelsChannel helper has nearly identical code in both the if (isAndroid()) and else branches. Consider consolidating:

💡 Suggested simplification

 async function closeBrowseChannelsChannel() {
     await ChannelScreen.back();
     await wait(timeouts.ONE_SEC);

-    // After the app awaits switchToChannelById, the Browse Channels modal may already
-    // be dismissed (dismissAllModalsAndPopToScreen closes it during navigation). Check
-    // whether Browse Channels is still on screen before trying to close it.
-    if (isAndroid()) {
-        // On Android the modal stack can collapse differently — tap close button if present.
-        try {
-            await waitFor(BrowseChannelsScreen.closeButton).toExist().withTimeout(timeouts.FOUR_SEC);
-            await BrowseChannelsScreen.closeButton.tap();
-        } catch {
-            // Browse Channels was already dismissed when Channel.back() popped the stack
-            // No action needed — navigation already complete
-        }
-    } else {
-        try {
-            await waitFor(BrowseChannelsScreen.closeButton).toExist().withTimeout(timeouts.FOUR_SEC);
-            await BrowseChannelsScreen.closeButton.tap();
-        } catch {
-            // Browse Channels was already dismissed by switchToChannelById navigation
-        }
-    }
+    // After the app awaits switchToChannelById, the Browse Channels modal may already
+    // be dismissed (dismissAllModalsAndPopToScreen closes it during navigation). Check
+    // whether Browse Channels is still on screen before trying to close it.
+    try {
+        await waitFor(BrowseChannelsScreen.closeButton).toExist().withTimeout(timeouts.FOUR_SEC);
+        await BrowseChannelsScreen.closeButton.tap();
+    } catch {
+        // Browse Channels was already dismissed — navigation already complete
+    }
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/test/products/channels/channels/archive_channel.e2e.ts` around
lines 99 - 129, The helper closeBrowseChannelsChannel contains duplicated
try/catch logic in both the if (isAndroid()) and else branches; consolidate into
a single code path that calls ChannelScreen.back(), waits, then runs one try {
await
waitFor(BrowseChannelsScreen.closeButton).toExist().withTimeout(timeouts.FOUR_SEC);
await BrowseChannelsScreen.closeButton.tap(); } catch { /* swallow: Browse
Channels already dismissed */ } so you remove the duplicated branches but keep
the pre-check wait(timeouts.ONE_SEC) and any Android-specific comment if you
want to document modal-stack differences for future readers.

detox/e2e/support/utils/index.ts (1)

308-330: Consider adding diagnostic information to the timeout error.

When waitForElementToNotExist times out, the thrown error comes from the underlying detoxExpect which may not include context about which element was being waited for. This makes debugging flaky tests harder.

💡 Suggested improvement

 export async function waitForElementToNotExist(
     detoxElement: Detox.NativeElement,
     timeout: number = timeouts.HALF_MIN,
     pollInterval: number = timeouts.HALF_SEC,
 ): Promise<void> {
     const {expect: detoxExpect} = require('detox');
     const startTime = Date.now();
     /* eslint-disable no-await-in-loop */
     while (Date.now() - startTime < timeout) {
         try {
             await detoxExpect(detoxElement).not.toExist();
             return; // Element no longer exists
         } catch (error) {
             if ((Date.now() - startTime) + pollInterval >= timeout) {
-                throw error;
+                throw new Error(`Element still exists after ${timeout}ms timeout`);
             }
             await wait(pollInterval);
         }
     }
     /* eslint-enable no-await-in-loop */
     // Final check - will throw if still exists
     await detoxExpect(detoxElement).not.toExist();
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/support/utils/index.ts` around lines 308 - 330, The timeout error
from waitForElementToNotExist lacks contextual diagnostics; update the function
(referencing waitForElementToNotExist, detoxElement, detoxExpect, timeout and
pollInterval) to catch the underlying errors both inside the loop and on the
final check and rethrow a new Error that includes identifying context (e.g.,
stringified detoxElement or a brief selector/description and the timeout value)
plus the original error message/stack (attach as cause or include text) so test
logs show which element and timeout caused the failure.

detox/e2e/support/ui/screen/channel.ts (1)

420-446: Day-of-week logic comment is slightly inconsistent with implementation.

The comment states:

• "Sunday (0): Tomorrow"
• "Tue–Thu (2–4): Tomorrow, Monday"

But the implementation (lines 441-444) uses scheduleMessageForMonday() for Sunday and Tuesday–Thursday, not "Tomorrow". While this works (Monday is available on those days), the comment implies "Tomorrow" would be selected.

Consider aligning the comment with the actual implementation or using scheduleMessageForTomorrow() where the comment says "Tomorrow" is the option.

💡 Suggested comment fix

     /**
      * Picks the first available schedule option regardless of the current day.
      *
      * The picker shows different options depending on the day of the week:
      *   Sunday  (0): Tomorrow
      *   Monday  (1): Tomorrow, Next Monday
      *   Tue–Thu (2–4): Tomorrow, Monday
      *   Friday  (5): Monday
      *   Saturday(6): Monday
      *
-     * This method always selects a valid option so tests pass on any day.
+     * This method selects "Monday" (or "Next Monday" on Monday) for stability,
+     * since "Monday" is available on all days except Sunday where we also use it.
      */

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/support/ui/screen/channel.ts` around lines 420 - 446, The comment
describing day-of-week behavior for scheduleMessageForAvailableOption is out of
sync with the implementation: the code calls scheduleMessageForMonday() for
Sunday and Tue–Thu but the comment says "Tomorrow" is selected for those days;
either update the comment to state that Monday is chosen as a stable fallback on
Sunday and Tue–Thu, or change the logic to call scheduleMessageForTomorrow() for
the days where the comment expects "Tomorrow" (keep
scheduleMessageForNextMonday() for Monday and scheduleMessageForMonday() for
Fri/Sat). Ensure references to scheduleMessageForAvailableOption,
scheduleMessageForMonday, scheduleMessageForNextMonday, and
scheduleMessageForTomorrow are used so reviewers can locate the changes.

detox/e2e/support/ui/screen/channel_list.ts (1)

105-124: Category order may cause incorrect tap when channel appears in multiple categories.

If a channel appears in both 'unreads' and 'channels' (e.g., after receiving a new message), this method will always tap the 'channels' entry first since that's the order of iteration. This is likely acceptable for test scenarios but worth documenting.

The error message is clear about the failure mode but doesn't indicate which categories were searched, which could help debug flaky tests.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@detox/e2e/support/ui/screen/channel_list.ts` around lines 105 - 124, The
tapSidebarPublicChannelDisplayName function may tap the wrong category due to
fixed iteration order and the thrown Error lacks context; update the error
thrown at the end of tapSidebarPublicChannelDisplayName to include the
categories that were searched (use the local categories constant and
channelName) so failures show which lists were probed (reference
tapSidebarPublicChannelDisplayName and getChannelItemDisplayName and the
categories array), e.g. build a message like "Sidebar channel item not found for
channel: X; searched categories: [..]" and throw that.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@detox/e2e/support/ui/screen/channel_list.ts`:
- Around line 105-124: The tapSidebarPublicChannelDisplayName function may tap
the wrong category due to fixed iteration order and the thrown Error lacks
context; update the error thrown at the end of
tapSidebarPublicChannelDisplayName to include the categories that were searched
(use the local categories constant and channelName) so failures show which lists
were probed (reference tapSidebarPublicChannelDisplayName and
getChannelItemDisplayName and the categories array), e.g. build a message like
"Sidebar channel item not found for channel: X; searched categories: [..]" and
throw that.

In `@detox/e2e/support/ui/screen/channel.ts`:
- Around line 420-446: The comment describing day-of-week behavior for
scheduleMessageForAvailableOption is out of sync with the implementation: the
code calls scheduleMessageForMonday() for Sunday and Tue–Thu but the comment
says "Tomorrow" is selected for those days; either update the comment to state
that Monday is chosen as a stable fallback on Sunday and Tue–Thu, or change the
logic to call scheduleMessageForTomorrow() for the days where the comment
expects "Tomorrow" (keep scheduleMessageForNextMonday() for Monday and
scheduleMessageForMonday() for Fri/Sat). Ensure references to
scheduleMessageForAvailableOption, scheduleMessageForMonday,
scheduleMessageForNextMonday, and scheduleMessageForTomorrow are used so
reviewers can locate the changes.

In `@detox/e2e/support/utils/index.ts`:
- Around line 308-330: The timeout error from waitForElementToNotExist lacks
contextual diagnostics; update the function (referencing
waitForElementToNotExist, detoxElement, detoxExpect, timeout and pollInterval)
to catch the underlying errors both inside the loop and on the final check and
rethrow a new Error that includes identifying context (e.g., stringified
detoxElement or a brief selector/description and the timeout value) plus the
original error message/stack (attach as cause or include text) so test logs show
which element and timeout caused the failure.

In `@detox/e2e/test/products/channels/channels/archive_channel.e2e.ts`:
- Around line 99-129: The helper closeBrowseChannelsChannel contains duplicated
try/catch logic in both the if (isAndroid()) and else branches; consolidate into
a single code path that calls ChannelScreen.back(), waits, then runs one try {
await
waitFor(BrowseChannelsScreen.closeButton).toExist().withTimeout(timeouts.FOUR_SEC);
await BrowseChannelsScreen.closeButton.tap(); } catch { /* swallow: Browse
Channels already dismissed */ } so you remove the duplicated branches but keep
the pre-check wait(timeouts.ONE_SEC) and any Android-specific comment if you
want to document modal-stack differences for future readers.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2cfeaf68-5a65-40c8-b76c-e70098263b14

📥 Commits

Reviewing files that changed from the base of the PR and between 491abc1 and 8d1573d.

📒 Files selected for processing (6)

• detox/e2e/support/ui/screen/channel.ts
• detox/e2e/support/ui/screen/channel_list.ts
• detox/e2e/support/ui/screen/thread.ts
• detox/e2e/support/utils/index.ts
• detox/e2e/test/products/channels/channels/archive_channel.e2e.ts
• detox/e2e/test/products/channels/ipad/ipad_post_message.e2e.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• detox/e2e/support/ui/screen/thread.ts