SEC-10094 feat(workflow): PR test analysis#9690
Conversation
📝 WalkthroughWalkthroughTwo new GitHub Actions workflows are added to enable PR test analysis and override functionality. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/pr-test-analysis-override.yml:
- Around line 22-23: The current guard uses
startsWith(github.event.comment.body, '/test-analysis-override') which allows
empty or whitespace-only reasons; update the condition to require a non-empty
reason by replacing the startsWith check with a regex match that enforces a
space and at least one non-whitespace character (e.g.
matches(github.event.comment.body, '^/test-analysis-override\\s+\\S+')) while
keeping the contains(...) author_association check unchanged so only
OWNER/MEMBER/COLLABORATOR comments are allowed.
- Around line 9-10: Change the concurrency group to be workflow-specific so runs
from pr-test-analysis.yml and pr-test-analysis-override.yml don’t share a
namespace: update the existing "group: test-analyzer-${{
github.event.issue.number }}" to include a workflow identifier (for example
append or prefix with the workflow name or use ${{ github.workflow }}) so the
key becomes unique to this override workflow, and keep "cancel-in-progress:
false" as-is; modify the "group" entry referenced in this file to reflect that
change.
In @.github/workflows/pr-test-analysis.yml:
- Line 40: Replace the mutable `@main` reference with a pinned commit SHA for the
reusable workflow; locate the uses line currently written as "uses:
mattermost/mattermost-test-automation-toolkit/.github/workflows/pr-test-analysis.yml@main"
(and the analogous entry in pr-test-analysis-override.yml) and change the `@main`
suffix to the specific commit SHA of the external repo you want to lock to,
update both occurrences to the same verified SHA, and commit the change so the
workflow uses an immutable reference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2690c160-ba77-4a5a-86b8-8ba84d913af7
📒 Files selected for processing (2)
.github/workflows/pr-test-analysis-override.yml.github/workflows/pr-test-analysis.yml
Coverage Comparison ReportGenerated on April 15, 2026 at 05:02:31 UTC |
|
Merging this now |
Summary
Per rollout plan - https://hub.mattermost.com/private-core/pl/gt5hkzyrfiduze6rq3bta91www
mainandrelease-*branches/test-analysis-override <reason>commentTicket Link
https://mattermost.atlassian.net/browse/SEC-10094
Release Note