Conversation
Contributor
AltamashShaikh
left a comment
AltamashShaikh
left a comment
There was a problem hiding this comment.
@krezreb I set log_format as log_format = "json" in my config.ini.php and I don't see the message as JSON, do I need to do anything else ? I am already on jsonlogs branch for core and plugin.
Contributor
Author
|
No that's how it's supposed to work, in the LogViewer it should display as it did before in non json format |
snake14
reviewed
Mar 27, 2025
Contributor
snake14
left a comment
snake14
left a comment
There was a problem hiding this comment.
Looks good. I just had one question.
snake14
approved these changes
Mar 27, 2025
snake14
approved these changes
Jun 25, 2025
Contributor
There was a problem hiding this comment.
Apologies @krezreb . I didn't realise that this hadn't been merged yet. @AltamashShaikh are you aware of any reason not to merge this PR?
Edit: I guess that the PR which it's dependent on hasn't been merged yet, so there isn't a rush.
AltamashShaikh
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Complements matomo-org/matomo#23167
Updates the LogViewer view to correctly display logs when set to json format
Issue No
Complements matomo-org/matomo#23167
Steps to Replicate the Issue
Checklist