Skip to content

[WIP] Update static collections#1401

Open
esoteric-ephemera wants to merge 4 commits intodevelopfrom
misc-static
Open

[WIP] Update static collections#1401
esoteric-ephemera wants to merge 4 commits intodevelopfrom
misc-static

Conversation

@esoteric-ephemera
Copy link
Collaborator

@esoteric-ephemera esoteric-ephemera commented Mar 19, 2026

Updating data models / fields for static collections per discussion with @tsmathis:

  • Data schema for Atlas search results in Synthesis data
  • Ensure structure field in surface properties is structure and not CIF str
  • Replace grain boundaries cif field with structure

@esoteric-ephemera esoteric-ephemera changed the base branch from main to develop March 19, 2026 23:34
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.96%. Comparing base (210e706) to head (d346564).

Files with missing lines Patch % Lines
emmet-core/emmet/core/grain_boundary.py 60.00% 6 Missing ⚠️
emmet-core/emmet/core/surface_properties.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1401      +/-   ##
===========================================
- Coverage    85.99%   85.96%   -0.03%     
===========================================
  Files          243      243              
  Lines        19246    19272      +26     
===========================================
+ Hits         16551    16568      +17     
- Misses        2695     2704       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants